Bug 1394820

Change-Id: I710098cb96ac7d0868926a95c4b4488df4753e4c

* changes:
  Quota percent 'divide by zero' error (Bug 1393584)
  Fixing type checking on min/max values (Bug #1394732)

Scenario/testing:

- Create an account, say User A and logout as admin.
- In one browser login (this will be the hacker user)
- In another browser reset pass via forgotten pass link

What should happen:
User in browser two should be able to reset pass then navigate about
as when normally logged in. User in browser one should be forced to
login again as their user sessionid is not valid anymore.

Before patch:
malicious user still has access until $USER->logout_time time expires

After patch:
malicious user foreced to re-login straight away on next page load

Change-Id: I42ad907e5ffa7c128742a159116cf20dc6cd9b8a
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Change-Id: Ic29fccfa3f523a984af60871afe89f7c157b33fa
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Change-Id: I4f75dfc9f34c3f9e3f01d8d459b6ec7a43f13689
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Change-Id: I252c5f763ccc83d846f5dcc7fd086d723b31e2e6
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Change-Id: I042c1127f7601483e8723b2e31bf07683accf2c0
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Bug 1394330

In most places in mahara we specify that we want base 10 number
returned (or base 16 in case of a hexidecimal css colour)

But there are a few places where we don't specify the radix at all

It's best practice to always include the radix because for older
browsers it interprets leading 0 as octal by default.

Also makes it clearer to developers what type of number is expected to
be retrieved from the string.

Change-Id: Iaecc85cbed875f85b313188c4e96cc1b77c77b31
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Change-Id: I408ae6c39ab05eefb8348836a6b85ee80ad8825c
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Getting the user's institution comment sort order to sort the comments
for the artefacts on the view page. So that the expand out comment
areas are sorted either earliest -> latest or visa versa.

Change-Id: I13b37b0a42c818ccc21147e4a0469015a020dd80
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

This allows for artefact comments on the view page to be ordered by
either 'earliest' or 'latest'

Change-Id: I50f2b2091618109be1579a53308a2bb169a199f0
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

If the taggedblog block is set to display full entries then comments
also show

Change-Id: Iea4f6c3df3f61d0b58e8f7b0b06c1fb3713fedd8
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

To handle the fact that blog blocks have more than one blogpost and
therefore more than one comment link I've passed the artefact id and
block id in together and appended a '0'
to the front of the id so that the artefact id + block id does not
clash with another block of the same id.

Change-Id: Iddd4dab7afe70e8926a8556cdb55ea8d4dceda06
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Getting the rendering of the blogpost comment count to be done by the
block instance in a similar fashion as the other artefact blocks.

Change-Id: I67805ac33a9850c1fded17b32873e5ad90c7489f
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

This is only for the displaying of a folder as a gallery
in either the thumbs, square thumbs, or slideshow.

The allow comments is based on the allowing the folder to have
comments so this means any folder comments will display whether they
have been added following the link in gallery block or the folder
block as both end up at the same artefact on artefact/artefact.php page

Change-Id: I787a730861823ef3f731fb5209bf3470b00a7ed3
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Change-Id: I50a5cd56ca87b9625dcf59462db822c222fc0a24
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Change-Id: I85dd598e7cce09ec3fd3edaa6e6c946008cc81c8
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Change-Id: I2ca1392ca92c248ce1c752cda640b2ce39e89367
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>