GitLab

Cecilia Vela Gurovic authored Oct 11, 2018 and Robert Lyon committed Oct 17, 2018

at the moment we are assuming the string to get
the title of a blocktype is 'title'
but this doesnt have to be the case,
like in the blocktype myviews

behatnotneeded

Change-Id: Ifeaac2731df6f495f00f3e12a806327e65ff63a9
(cherry picked from commit 2b8287dc)
(cherry picked from commit c38a17ef)

Robert Lyon authored Sep 26, 2018 and Cecilia Vela Gurovic committed Sep 28, 2018

When sending watchlist notification for block changes in a view

behatnotneeded

Change-Id: Ieeb89c6662acabd8438486702e10433ea6feab70
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 0866ac93)

And also with calling $USER->logout();

And also with showing missing ldap server info for a user

behatnotneeded

Change-Id: I03656d286bbf2e56416151a52b2051235f9364df
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 254103d6)

Cecilia Vela Gurovic authored Sep 07, 2018 and Robert Lyon committed Sep 14, 2018

Also stop showing the copy page button on the collection rows

behatnotneeded
Change-Id: I2cfb78609b37fc56fdbf1f12be2f29c08e63a411

Robert Lyon authored Jun 01, 2018 and Cecilia Vela Gurovic committed Aug 30, 2018

Instead of the MaharaException when doing user delete via webservices

behatnotneeded

Change-Id: I71db2ab3a3552918992a66310cdc3244f8d7c3a1
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 7c8f5f5b)

Sarah Kirby authored Jul 16, 2018 and Cecilia Vela Gurovic committed Aug 30, 2018

behatnotneeded

Change-Id: I5353e13e4e41bfcf742cb013e5640288e6f03bda
(cherry picked from commit 71f16160)

To allow for using newer PHPUnit version that uses Namespaced clases

behatnotneeded

Change-Id: I9e33c2542dda76691b32df78335ce511b06174c7
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

behatnotneeded

Change-Id: I8df12c5b2ec35a9c92231de8bfa90f1909af6afc
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

behatnotneeded

Change-Id: I1f54b6d7649c1ff60661ba65cf0e1ac0d7c26af3
(cherry picked from commit a4c63b44)

So that we now can search by title/description/tag for valid artefacts

behatnotneeded

Change-Id: I9c514f98998b0a97326a8ba7c1de4566453a38aa
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

This allows to get an element out of been hidden by a topbar menu

Change-Id: Ib6b8f704919ac141e7170e10ad25e247e645b16d
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit b22a6c43)

Kenneth Hendricks authored Jun 12, 2018 and Robert Lyon committed Jun 19, 2018

This flag will set whether the function should
attempt to create the file if it doesn't exist.

E.g. image resizes.

This allows an external file system to call
get_local_path with this flag set to false to
skip the processing. This allows an external
file system to avoid an infinate loop when calling
get_local_path to check local file availibility.

Sponsored by Central Queensland University

behatnotneeded

Change-Id: Iaade0b06fcc2cd1755467231e0bafea6b90a99ec
(cherry picked from commit 63d04fd1)

Signed-off-by: Cecilia Vela Gurovic <ceciliavg@catalyst.net.nz>

Signed-off-by: Cecilia Vela Gurovic <ceciliavg@catalyst.net.nz>

The fix in Bug 1774309 fails to work correctly when the site
is in a subdirectory of the apache root.

To test:
1) Adjust your site's apache file and set the DocumentRoot to be
parent of htdocs
2) Change the 'wwwroot' db value for site to include the 'htdocs/' bit
3) Restart the apache server
4) Go to site, adding 'htdocs/' to url
5) Try logging in

before patch: end up not found page with url containing two 'htdocs/'

after patch: end up at correct place

behatnotneeded

Change-Id: Ic5e1de2c5edaf96bbdd9b2403f0f65e45a4b80c0
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit d9ce7d92)

Ghada El-Zoghbi authored May 29, 2018 and Robert Lyon committed Jun 01, 2018

Pass error number and message correctly to the
MaharaException call when coming back from the
externalfeed curl call.

Sponsored by Central Queensland University

behatnotneeded

Change-Id: I03a2b666bde3905d2466ffbe35f1b35ca8a088bf
(cherry picked from commit 23287554)

If trying to access a page requiring login the system remembers the
path (QUERY_STRING) you were trying to access when login is successful

But if you login from the homepage there can be no QUERY_STRING set

Noticed when doing behat tests

behatnotneeded

Change-Id: I38cf1f6df7432d70ced5fe5df84bd56b47f1f163
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 1c3d039b)

Robert Lyon authored Apr 27, 2018 and Cecilia Vela Gurovic committed May 31, 2018

behatnotneeded

Change-Id: I0eef9a361cda68ca6274d64308354dc239cc46bc
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit c185b03d)

Signed-off-by: Cecilia Vela Gurovic <ceciliavg@catalyst.net.nz>

Signed-off-by: Cecilia Vela Gurovic <ceciliavg@catalyst.net.nz>

Change-Id: Ieb4ebab6ac57ff0ef4f4f89b409884e9d6bc3db7
(cherry picked from commit d5b47224)

Robert Lyon authored May 13, 2018 and Cecilia Vela Gurovic committed May 30, 2018

If zipped up Leap2A files are uploaded containing files with viruses we need to
check them before finishing the importation.

Also we should check existing zipped files for viruses as well, eg:

1) Upload a zip file with virus
2) Turn on clamav
3) Try extracting the zip file

behatnotneeded

Change-Id: I7635deb5f69e6fdb60e89d11ddf9362bb7928994
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 814cbaea)

Robert Lyon authored May 21, 2018 and Cecilia Vela Gurovic committed May 30, 2018

By using redirect to avoid exposing sensitive data after login /
password reset

behatnotneeded

Change-Id: I4d64c7c51bb1af81dac594de0563be243a990ed6
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 520d915d)

a few changes copied from patch https://reviews.mahara.org/#/c/8607 
(whishlist for 18.10)

to fix 18.04

behatnotneeded

Change-Id: I8a6d64601005c708c11e719f94254c43e8fb2833

* changes:
  Bug 1771473: tags search - filter and sort selectors update each other
  Bug 1771473: Confusion of sorting

makes it possible to select date sorting
for each artefact type

behatnotneeded

Change-Id: I7e74bdfbbe8b4df35028e1890833298e73516a45

Robert Lyon authored May 25, 2018 and Cecilia Vela Gurovic committed May 29, 2018

The baseurl for the pagination was not getting set correctly if 'all'
tags was joined with a special sort/filter.

behatnotneeded

Change-Id: Ic5ebcd4388b7808062a91ea463031e4c5ffa2083
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

behatnotneeded

Change-Id: I798d052506c9acefa0e4b55c993135f3b70d27c5
(cherry picked from commit a0ccda3e)

This can be missing in collection object when upgrading from older
site and new db field is not created yet

behatnotneeded

Change-Id: I275a6387546eb8adaefd8b35f8b96dc754979cf5
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Cecilia Vela Gurovic authored May 25, 2018 and Robert Lyon committed May 27, 2018

behatnotneeded

Change-Id: Ide581c47d02772478fe04a85673e8d72cdd919e0
(cherry picked from commit 5f6a89a7)

Cecilia Vela Gurovic authored May 23, 2018 and Robert Lyon committed May 24, 2018

behatnotneeded

Change-Id: Idcd2689e6c196a6604e5f4706fb9019c4f0e3c88
(cherry picked from commit 00ed9a98)

Robert Lyon authored May 07, 2018 and Cecilia Vela Gurovic committed May 22, 2018

Otherwise the query just hangs

behatnotneeded

Change-Id: If3d022f87f83e14a512527a47cca2093b2ba74aa
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 94c1c750)

Robert Lyon authored Apr 17, 2018 and Cecilia Vela Gurovic committed May 21, 2018

In Mahara we compare supplied usernames in lower case to what exists
in the database. This avoids problems of 'test01' vs 'Test01'.

The LTI plugin needs to also adhere to this convention

behatnotneeded

Change-Id: I822ccf9e3e3c3b43533c503f1600ef3c3af8008e
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 80c5e70a)

Added 'I click on "button" delete button' step so that the delete
buttons with 'confirm' popup get accepted

Change-Id: I0ec7d268cd275efb1398b58c26d87f3e8ffdc092
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit cfed69ea)

Rebecca Blundell authored May 09, 2018 and Robert Lyon committed May 19, 2018

behatnotneeded

Change-Id: Ie5b2f00eb7ce0a49174243fe58b505d4a6365e22
(cherry picked from commit 1cf522e6)

Before the change in Bug 1698257 the offset of <body> was 0 but now it
is the height of the site messages + navbar

behatnotneeded

Change-Id: I6331f95d54eef4d159c7cc9731d48a0c9eb5d003
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit f28839c6)

Kristina Hoeppner authored May 07, 2018 and Cecilia Vela Gurovic committed May 14, 2018

Mention that the subscribe / unsubscribe options are
only available when not subscribed to the forum.

behatnotneeded

Change-Id: I5c34aed233a75a9e26346df69a52137518e44218
(cherry picked from commit a6636e56)

When site public pages are turned off.

If the user is a member of a group that has 'public' access and the
site 'Allow public pages' are turned off, the user should be able to
view the group's home page - therefore allowing them to paginate
through the "Group portfolios" block in the group home page.

behatnotneeded

Change-Id: I1ea49927532f967c8a676b8a1590d1db3787cfc2
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 7d9d1b29)