Skip to content
GitLab
  1. 05 Mar, 2019 1 commit
  3. 26 Feb, 2019 4 commits
  5. 13 Feb, 2019 1 commit
  7. 24 Jan, 2019 1 commit
  9. 11 Dec, 2018 1 commit
    • Cecilia Vela Gurovic's avatar
      Bug 1791544: MENUINTEM not defined in artefact page · 9c54d4b4
      Cecilia Vela Gurovic authored and Robert Lyon's avatar Robert Lyon committed 
      MENUITEM needs to be defined in artefact/artefact.php
way to access this page:
in a page owned by other user, click on an artefact
they have shared in it

Also need to check if MENUITEM is defined before trying to access it
as some pages don't need a MENUITEM set, eg artefact/file/download.php

behatnotneeded

Change-Id: Idb8479393034fe42dce8d88ed7f23c72fa20c337
      9c54d4b4
  11. 03 Dec, 2018 1 commit
  13. 20 Nov, 2018 1 commit
  15. 11 Nov, 2018 1 commit
  17. 01 Nov, 2018 2 commits
  19. 29 Oct, 2018 1 commit
  21. 24 Oct, 2018 2 commits
  23. 16 Oct, 2018 1 commit
  25. 05 Oct, 2018 1 commit
  27. 30 Sep, 2018 1 commit
  29. 25 Sep, 2018 1 commit
  31. 24 Sep, 2018 1 commit
  33. 09 Sep, 2018 1 commit
  35. 06 Sep, 2018 1 commit
  37. 31 Aug, 2018 1 commit
  39. 14 Aug, 2018 3 commits
    • Rebecca Blundell's avatar
      Bug 1773892: Upgrade Dwoo for PHP 7.2 · 3f821e53
      Rebecca Blundell authored and Robert Lyon's avatar Robert Lyon committed 
      Upgraded to 1.3.7

Issues:

Needed to change calls to class names to not use underscores
Changed calls to the Dwoo/$dwoo class to Core/$core
discovered that wrong file path wass being called for the dataroot
changes to use namespaces instead of requires
Changed Mahara plugins to camelcase naming.

Dwoo now uses composer to autoload files and
composer needs to cache the paths to classes before Dwoo will run.

behatnotneeded

Change-Id: Ia6b7f41c96fe5695a1ed94476e21eca5a9f1c9ee
      3f821e53
    • Rebecca Blundell's avatar
      Bug 1752743: replace php 7.2 deprecated functions · c6c6c295
      Rebecca Blundell authored and Robert Lyon's avatar Robert Lyon committed 
      replaced each() with foreach in core code.
replaced create_function() with anonymous function in core code.

Also removed some functions that were not used anymore

behatnotneeded

Change-Id: I300396a1ec04c75d7882b7ec5c9de76c3763e70d
      c6c6c295
    • Robert Lyon's avatar
      Bug 1781527: Removing paths to account/activity/index.php · 4ff97913
      Robert Lyon authored 
      

And getting that file to redirect to correct place

behatnotneeded

Change-Id: Ifa6cebbcd6282b9eb3a39df90debc9ca9fdb9b71
Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
      4ff97913
  41. 07 Aug, 2018 1 commit
    • Cecilia Vela Gurovic's avatar
      Bug 1741987: Update jquery - Events · 3d1abcc2
      Cecilia Vela Gurovic authored and Robert Lyon's avatar Robert Lyon committed 
      Event
   Breaking change: .load(), .unload(), and .error() removed
   Breaking change: .on("ready", fn) removed
   Breaking change: event.pageX and event.pageY normalization removed
   Breaking change: jQuery.event.props and jQuery.event.fixHooks removed
   Breaking change: Delegated events with bad selectors throw immediately
   Deprecated: .bind() and .delegate()
     no calls to .bind() for events in core.
     Only calls to bind() refer to the js bind of arguments to functions.
     no calls to unbind() for event in core.
     Only calls to unbind refer to the unbind method defined in
     formChangeManager not related to the jQuery method.

    Warnings fix
    JQMIGRATE: jQuery.fn.click() event shorthand is deprecated
    - also applies to the other event shorthands, including:
     blur, focus, focusin, focusout, resize, scroll, dblclick, mousedown,
     mouseup, mousemove, mouseover, mouseout, mouseenter, mouseleave,
     change, select, submit, keydown, keypress, keyup, and contextmenu.

    JQMIGRATE: jQuery.fn.hover() is deprecated
    JQMIGRATE: jQuery(window).on('load'...) called after load event occurred
	(for FileBrowser we can see this error when editing a block in a page)

behatnotneeded

Change-Id: I1a50050f882b864ad63d273de160e0b441a77705
      3d1abcc2
  43. 19 Jul, 2018 1 commit
  45. 17 Jul, 2018 1 commit
  47. 17 Jun, 2018 1 commit
    • Maria Sorica's avatar
      Bug 1722861: Add the institution tags page · fd5dc8fa
      Maria Sorica authored and Robert Lyon's avatar Robert Lyon committed 
      1. If a visible institution enables the
institution tags, a "Tags" link will appear
under the Institutions menu.

2. The link will take the user to the
institution tags page.

Change-Id: I29b2777c34253ebf57d0a3bd294081b7727cdc9b
      fd5dc8fa
  49. 31 May, 2018 1 commit
    • Mark Webster's avatar
      Bug 1771362: Fix timezone issues. · bc25beec
      Mark Webster authored and Robert Lyon's avatar Robert Lyon committed 
      Adds timezone dropdown the site settings. If no timezone selected
it uses site settings country to determine correct timezone and sets
that in the database.
PHP and DB session timezones will then assume this setting for all times.

This makes setting $cfg->dbtimezone obsolete - there is a warning to
admins to update their timezone setting on admin dashboard.

Limitations:
- A timezone or country MUST be selected in site options.

- Will not correct existing incorrect times, as no timezone info was
stored in the DB for dates/times, so it's impossible to determine what timezone
was used when saving.

- Changing the timezone will not adjust the display of existing times, for the
same reason.

behatnotneeded

Change-Id: I34c64cd51ece6758e76dd8c37007dcb316005845
      bc25beec
  51. 22 Mar, 2018 2 commits
  53. 05 Mar, 2018 1 commit
    • Gregor Anzelj's avatar
      Bug 845263: Password policy · 9c26c145
      Gregor Anzelj authored and Robert Lyon's avatar Robert Lyon committed 
      Improve the password policy enforcement and configuration in Mahara.
Have a pre-defined password policy of a minimum of 8 characters with
type "alphanumeric mixed case + symbols".

Also allow site administrators to set the desired password policy in
Site Options > Security Settings. In all locations where password
is set, the password input should also include a password strength
indicator.

Change-Id: I020af58a6cf1635fe295f5434783ce5b6f6daacb
      9c26c145
  55. 01 Mar, 2018 1 commit
  57. 23 Feb, 2018 1 commit
    • Glenn Walbran's avatar
      Bug 1729079: Create a mechanism to build manual links · dbf1ef2b
      Glenn Walbran authored and Robert Lyon's avatar Robert Lyon committed 
      This commits adds a mechanism that will build links to the manual pages
such that:

- user's language is used if manual exists in that language, else en
- the manual for this mahara/series is used

The key -> manual page map will need to be populated and these links added to
pages.

Change-Id: Id7871395821dce660841341dda200f231e75de16
      dbf1ef2b
  59. 22 Feb, 2018 1 commit
  61. 21 Feb, 2018 1 commit
  63. 16 Feb, 2018 1 commit
    • Cecilia Vela Gurovic's avatar
      Bug 1734178: allow user to delete own account · 9837f182
      Cecilia Vela Gurovic authored and Robert Lyon's avatar Robert Lyon committed 
      added settings

- institution level: reviewselfdeletion
    0 if the institution does not require approval
      from an admin to delete an account
    1 if the institution requires an admin to approve
      account deletion requests from users
    if not set, it takes the value from the site's
    default

- site level: defaultreviewselfdeletion
  (Site options->User Settings -> Review account before self-deletion)
    1 if the site's default is requiring approval
    null otherwise

Account deletion by a user

when a user accesses to the account settings, a
'Delete account' button is displayed.

This will:
- If the user belongs to an institution that requires
  approval (or does not have the settings but the site
  requires approval by default)
    then a notification will be sent to the admins
    of the institutions that require approval that
    the user belongs to
- if the user belongs to institutions and none of them
  require approval (or does not have the setting
  but the site does not require approval by default)
    then the account is deleted
- if the user does not belong to any institution
    then the action will depend on the setting of
    the 'mahara' institution or sites default if
    'mahara' doesn't have the setting

Approval by institution admins

An institution admin can see the pending deletion
requests in Admin menu-> Institution -> Pending deletions
After approving/denying a request, the user
that requested the account deletion will receive
a notification

behatnotneeded
Change-Id: I4ccd9c798cab065ec557eaddf7dfc3a51920b6d0
      9837f182