Change-Id: I5e440374e952fbda50a79ff4141683b63b628c3c
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

* changes:
  Remove unnecessary global declaration
  Fix error messages for group access dates (bug #894592)
  Fix warnings when rendering access type after error (bug #894592)
  Display stopdate fields which have errors in them (bug #894592)
  Fix display of view access rows after error on submission (bug #894592)

Sometimes when creating a thumbnail image, getimagesize doesn't return
a value for bits per pixel on certain gifs.  This creates warnings in
the logs when approximating the required memory consumption, and also
refuses to create the thumbnail.  We can check the mimetype of the
image when 'bits' is not set, and when it's a gif, just assume the
maximum value (8 bpp).

Change-Id: Ie4a7161f8e17fa17291448084a57fa13873e0e4a
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

Change-Id: I349d2dde48e14cc59a51729cfefe4f360a70a858
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

These were using undefined strings and gave messages like "The end
date for '[[group/view]]' access cannot be in the past".

Change-Id: If087014fc608747eee8c9533e36df1fd90856456
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

When the view access page is submitted with an error, php warnings
are emitted when the rendering the access rows.

First because the pieform element assumes that an 'accesstype' index
exists in the accesslist value, but this is only true when the
accesslist still contains database records rather than the list
submitted by the form.

Second,  disabled public access record causes a warning because
'public' isn't in the list of 'presets' allowed to be added to the
view, so we need to keep track of the allowed presets and the full
list of presets that may have been allowed in the past.

Change-Id: Ic4db20738d53a52caeb3ebef0b44660dcb7c9ee6
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

When you get an 'end date in the past' error from the view access page,
the offending record is not displayed because the form removes stale
records as it pulls them out of the database.  However, when we're just
validating a bad stop date entered by the user, we need to make sure
it's still displayed to avoid confusion over the error.

Change-Id: I22c8876a599a2f00280058f32b4757d8eb523ea0
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

When you submit the view access page and there's an error in the form
submission (due to bad start/stopdates, etc.), sometimes an item is
removed from the array of access records by unsetting the array key.
Messing with the ordering of the array keys causes a javascript error
which stops the access list from being displayed.

Change-Id: Iaa686c8adecc322a6b779ee3247b28c945031854
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

We removed info from the email subject and added it to headers. However
people generally don't see the headers, so this patch adds the info back
as pseudoheaders, while removing duplicate info such as poster name,
topic and time.

Change-Id: I1063c70693e3b6345d41225b8fed53e0c20e7d95
Signed-off-by: Melissa Draper <melissa@catalyst.net.nz>

Urls stored in the url field of notification_internal_activity contain
the site's wwwroot.  This leads to broken links when the wwwroot is
changed.  It also dangerously turns what should be local links into
remote ones when for example a production database is copied into a
test Mahara instance.

This patch does three things:
- Removes the wwwroot from urls passed to ActivityType constructors
- Adds the wwwroot back on the url when sending email and emaildigest
  notifications, and when displaying them on the site.
- Removes the wwwroot from the url in all existing rows of
  notification_internal_activity.

Change-Id: I00ae1abc65be79030ed4c572ce951edc43f7a034
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

These are mostly just missing semicolons. No code changes.

If you use emacs already: apt-get install js2-mode
If you don't use emacs: apt-get install emacs js2-mode ;-)

Change-Id: Ie81c438c673084ee9e29a950bafe628a7c3ca7d9
Signed-off-by: Francois Marier <francois@catalyst.net.nz>

Change-Id: Id45194b3fa0c27e20cccd46b0acc29aeb4c0ec48
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

When a user has many views shared with them, the view_search query
may exceed mysql's max_join_size and cause an unrecoverable error on
a user's dashboard, among other places.  Replacing a bunch of these
outer joins with subselects fixes the issue, and in a few tests on a
large postgres db, also improved performance.

Change-Id: Ic3b82518e4571807ceae4747ab086eb4a9baa5db
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

Change-Id: I9ab910ebad9449ae2125e100d653e1c0cd460495
Signed-off-by: Kristina D.C. Hoeppner <kristina@catalyst.net.nz>

The submenu under settings in not usable with drop-down navigation,
because there's no top-level item for it to hang from.  This patch
changes it to group-style tabs within the page when drop-down
navigation is configured.  Just creating a link from the inbox to
the notification prefs is not sufficient because plugins can now
hook into the right menu (see bug #834171).

Change-Id: I7cd6009ed77d5795a9a6880e64d90f8742e47f92
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

* changes:
  Add a class on each right_nav menu item
  Use string keys in right_nav menu array
  Remove unread message count from profile sideblock (bug #854403)

In IE, when dragging a blocktype image into the content area of the
view editor, the image appears to slip underneath the white box saying
"This area shows a preview of what your page will look like..." and
then out the other side again.  Setting the z-index property on the
element containing blocktype list fixes the issue.

Change-Id: I6bc28bcf790b89d7513144012e210527b8ae1710
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

When dragging a blocktype in the view editor in IE, dragging it very
slowly usually causes the block to suddenly disappear, and the cursor
to turn into a crossed circle.  If you let go of the mouse, the
blocktype image appears at the cursor, and clicking the mouse again
will drop the blocktype.  This can be fixed by disabling IE's default
startdrag function.

Change-Id: I03b3150dbdef7f59f6f638d0cc71a773df5de576
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

There are several places in the code where we make directories
for stuff, both in the filesystem and in the artefacts table.
If they have trailing spaces, then this can mess up users html
exports etc. This patch should make exports safe for existing
folders with whitespace at the end, and prevent new folders from
from being made with the problem.

Change-Id: Ia593f7f773e5ffe91ce74e8a736074b1fe1026b2
Signed-off-by: Melissa Draper <melissa@catalyst.net.nz>

Bug #890530

Change-Id: I05258849635d7d5f8de6dc2f32ff2e535c6d01a8
Signed-off-by: Hugh Davenport <hugh@catalyst.net.nz>

Forum email subjects are unwieldy so move forum name and group name to
custom headers so users can filter as well as have a more concise
subject line. Values in headers trimmed to 100 char based on information
at http://stackoverflow.com/questions/2721605/maximum-size-of-email-x-headers



Change-Id: Iad9c7c3101ff81f19f3beafbe1811f28f3d3faa5
Signed-off-by: Melissa Draper <melissa@catalyst.net.nz>

Bug #568140

This problem only occurs when Javascript is disabled.
This is one possible fix, which doesn't require changes to
the database schema.

Change-Id: I434a2806010acd9848622032258fca84e91e5b16
Signed-off-by: Hugh Davenport <hugh@catalyst.net.nz>