GitLab

behatnotneeded

Change-Id: Ie6426e1fb1d7fa206f94553ac9435327f32a3951

Needed to mke new string have it's own key

Change-Id: Ia6fd4ad577c40753246637ed303099ce050b293f
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Doris Tam authored Nov 25, 2020 and Kristina Hoeppner committed Apr 26, 2021

Change-Id: If6fcc81a0a29482f50ab40ff6fff4e8417568a4f

Lisa Seeto authored Apr 07, 2021 and Robert Lyon committed Apr 23, 2021

 - add in code for allocomments on notes to be set
 - default to allowing comments

Change-Id: Iaa770f7708453d5702300b42aeb9039fae331459
Signed-off-by: Lisa Seeto <lisaseeto@catalyst.net.nz>

Turning the radio buttons into singular select options

Also allowing one to have local files that will override
the piertables.js and piertables.css files if they wish

Change-Id: I757deefd0438997745fa33331b0fedc16ba9f41c
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Alexander Del Ponte authored Nov 20, 2020 and Robert Lyon committed Apr 22, 2021

This plugin adds a comfortable management of current and already
released group submissions by providing a sort and filterable table in
its own group tab including direct access to the portfolios resp. their
archived version.

Additional metadata is also provided together with the possibility to
release the portfolio or to assign an evaluator and an evaluation result.

behatnotneeded: Behat tests to follow

Change-Id: I702322e3af92bd84a333edd028fcf8611e942bed

* Added a new class to force the pointer cursor.
* Added this class to the Add entry anchors.
* Added a data flag to assist spotting the drag n drop activity when Add
entry is the element clicked for dragging the block.
* Added js to test this data flag before submitting on click.
* Renamed `AddNewPostShortcut()` in recent/tagged posts JS to better
identify them.

Change-Id: I3e367cd9323e9eb5ef18495d33ce6fa9c3c7c48d

A partial export (just selected pages) does not include the persondata
tags. When these are not present the first/last names are taken from the
author tag.  I've added a 'source' parameter to the firstname/lastname
fields that can be checked later in the process when the Import form is
being presented.  If the source is the author tags we force the Ignore
option on the decision field values.

The Bug referenced 'personal information' so I have included the email
field.

Change-Id: Ifa173a88f497be994c5ab93e26376463442ab24b

Config gear icon removed from the Annotation blocks.
In order to still initially create these when added we needed to check
if the Block was a new instance or not. To achieve that we are now
passing the block instance into the has_instance_config() method.

BlockInstance has been extended and will set a 'new' parameter if the ID
in the constructor is 0.

AuthPlugin* classes also have the has_instance_config(). These do not
need the BlockInstance passed in.

Change-Id: Ifac69fc1d48b45c079b6f66e610776cead3dee63

Change-Id: Ie5237ffe7f3e80d71b5dd72c1f8ab38f91edb56c

Evonne authored Jan 26, 2021 and Kristina Hoeppner committed Feb 12, 2021

- Make comment public /portfolio/feedback.html: sits in the middle and
  doesn't have the correct class.
- Comment with attachment: size is still displayed and download icon
  doesn't have tooltip that includes file name and size.
- Objectionable content: When page seen in 'Shared by me' page, it's
  missing the 'Portfolio under review' markup.
- Plans: The word 'Template' is too small on the plans overview page.
- Plans: View page and also Edit: Remove red background for overdue plan
  item as well as the red from its heading.
- Plans: Edit on a page: The chevron on the task sits awkwardly.
- Mark a forum post as objectionable: The alert icon to the left of the
  profile icon of the post that you are reporting is missing.
- Once forum post has been reported, change the red text for 'Reported
  details' to black.
- Legal: Expanded item has the chevron in the wrong direction.
- Legal: The 'Last update' date moved to the bottom from the top right
  hand corner.
- Elasticsearch result page, journal entry is pushed to the left.
- Account settings in admin area: Calendar icon below last login sits
  outside of box.
- Skin: - heading within a text block uses the block heading font when
  it should not do that.
- Group's about page - under Group Portfolios heading, when a page/
  collection is a template, it has a button on the right to allow
  copying, tpl needs to be updated so it aligns to top of the
  list-group-item.
- Look into the btn-group-top responsiveness, too many overrides for
  specific pages, like comments remove button, it seems to require an
  extra pixel around md breakpoint, would like to clean this up.

behatnotneeded

Change-Id: Icfffed9376e89339a8fad5a207d3b974b431e451

 - wrap text in a div

Change-Id: I05e73dc7733fcf7a1d9b54049994d214a7f17a13
Signed-off-by: Lisa Seeto <lisaseeto@catalyst.net.nz>

Draft peer assessment needs additional indicator besides colour

Added a 'draft' string to "view" and used that in the template.
Updated the 'draft' string in "blocktype.peerassessment/peerassessment"
to 'savedraft' to prevent confusion.
Added 'pubstatus' to the item if it is private and set this to Draft.
Added pubstatus to the template if set to private. Style for this
replicates the private status on Bug 1912414.

Change-Id: I9cb0b20f9e00536e3162c3f83583b4877a6913a9

Evonne authored Dec 16, 2020 and Kristina Hoeppner committed Dec 23, 2020

1. Profile picture in sidebar is now always within the background colour
   even when there is a short name.
2. 'Tags' is not displayed in bold any more so as not to draw too much
   attention to it.
3. Removed all pull-right and pull-left classes and put in float-right
   or float-left instead (bootstrap legacy).
4. Fixed field outline colour in the configurable theme so that the same
   colour is now used everywhere.
5. Reviewed the use of outer-link and inner-link as they were not
   accessible. Rule: If it is a single link it can an outer-link so that
   the entire item is outlined on click (nicer visually), but if the item
   has other links within it then outer-link should not be used.
6. Removed outer-link hover background as some list items had it and
   some didn't. Rule: No hover background colour for items.

behatnotneeded

Change-Id: I737841f9bfe825c0a004951bb4b7c7c589ab019d

Kevin Dibble authored Mar 22, 2019 and Robert Lyon committed Dec 19, 2020

Need to define owner and block when creating a
peer assessment artefact while importing

Create a temp block to assign on artefact creation
that later needs to be replaced by the actual block
when it's available

Draft assessments should not be exported or imported.
For exported portfolios created on older version of
Mahara, there is no way of knowing if they are drafts
at the moment of importing because this information
was not included in the leap2A export xml file.
Not importing draft peer assessments should work
from this patch.

It also adds a fix to support
Postgres and MySQL when a table
column name is a reserved word.

Removing not null restriction for "usr" field in "artefact_peer_assessment"
table:
- The author in peer assessment table should be working as comments table.
- For each comment, there is an entry in 'artefact' table that contains
author and authorname, and another entry in 'artefact_comment_comment'
that doesn't have an author field
because we already have one in 'artefact' table.
- We should have something similar on 'artefact_peer_assessment'.
There is already an author field in 'artefact' table,
then the 'usr' field in 'artefact_peer_assessment' should not to have a
'not null' restriction. If the peer assessment artefact has been imported
and the author is not present in this site, then the 'usr'
should be allowed to be null.

behatnotneeded

Change-Id: I182520159d1fcbc072081c2d976cdc68cde5e19d

Added another query parameter in the url 'shortcutnewentryviewid' to know which view
the request for new entry came from and  to know where to return to once new entry is made.

Change-Id: I5c6a7e2fd214f6fb8dc61acead56f746992976eb

 - change the way that the js script for slideshow is called
   eliminating the need for bootstrap to be included a second time
   (error was because bootstrap was included without popper.js first,
    but it turns out bootstrap didn't have to be included at all)

Change-Id: I3cb530d892105027c9ace08dded0a3717a571834
Signed-off-by: Lisa Seeto <lisaseeto@catalyst.net.nz>

 NB: We are ignoring the multiple records found warnings
 that are produced as a result of asynch json calls until we can
 refactor that part of the code

 - add IGNORE_MULTIPLE flag to ensure_record_exists
 - remove old param comment

Change-Id: I39548cd157c9c2bfe82450bfddbe33696233a974
Signed-off-by: Lisa Seeto <lisaseeto@catalyst.net.nz>

Change-Id: Icf68054b6cb89645fa2e1fde26d682879437b441
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

When importing comments, the author name or id should not be imported
When exporting comments, the author name or id should not be imported

Change-Id: Ia05fdb8cf6004b9be145e3740c9dc89a58f45bbb

Kristina Hoeppner authored Sep 20, 2020 and Robert Lyon committed Sep 21, 2020

General review of language strings, incl.
- 'blacklist' changed to 'deny list'
- Reference to 'secure.gravatar.com' removed as the normal
  Gravatar URL is now secure

behatnotneeded

Change-Id: I12e8a21ab9f0b6885cf8d0da93dcc3b06ead670e

Evonne authored Jul 21, 2020 and Robert Lyon committed Sep 17, 2020

Base font has been increased to 16px, and as a result, variables
have had to be recalculated.

Max browser width has been increased to 1440px to allow the
larger font to have more characters in a line.

As a part of accessibility, headings H1-H6 have had to be rejigged.
Note that for elements such as popup/modals, the heading restarts
at H1 again as advised by Julius.

Page heading is H1, block heading is H2, everything else should be
H3. Trying to attempt to reserve H4-H6 for user content, but it is
still existing in some places as some things can't be changed.

Attachment markups have been unified and added to styleguide.

Removed H3/H4 from fieldset legends.

behatnotneeded

Change-Id: I69273c9775d658f03738c29be8d230b59c189790

Lisa Seeto authored Sep 02, 2020 and Robert Lyon committed Sep 10, 2020

Added an additional check to see if a portfolio has been submitted
to conditionally restrict peer assessments

Change-Id: Ifef7116805bd8bbe6e9de5d9ee85fca2a4c49a45
Signed-off-by: Lisa Seeto <lisaseeto@catalyst.net.nz>

Currently all profile fields title/label named via the artefacttype
But if we want different titles in differnet contexts we can now do
this by adding to our ArtefactTypeWhatever class something like

    public static function static_display_title() {
        if (... some condition ...) {
            return get_string('altoption', 'artefact.internal');
        }
        return get_string('option', 'artefact.internal');
    }

Change-Id: I32cfdc821442a7ba8729d76a18e6ddc1f7a62c95
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

If a user has access with  peer role to a portfolio
and the owner of the portfolio belongs to institutions
that allow the peer role to see content of blocks
then the logged in user will be able to see the content of pages
even if they don't have a peer assessment block in it

If the owner of the portfolio belongs to at least one institution
that doesn't allow the peer role to see content of blocks
then the fuctionality remains the same:
a peer doesn't see any content if there is no peer assessment block in the page
a peer only sees block headers if there is a peer assessment block in the page

behatnotneeded

Change-Id: I6bf84d919cc897cb912be463817b64dfb11c0c1a

If a collection and its copy have the same owner,
then use the same artefact id (same image file)
as the cover image.

If the owners are different then use the copied
file artefact id for the cover image

behatnotneeded

Change-Id: Iab1e3168925ce567934b34b73627832035b809a8

Robert Lyon authored Jul 09, 2020 and Cecilia Vela Gurovic committed Aug 31, 2020

And display a button once completed

Change-Id: Ife98ed3de2e10d8861e75911ecdd7f7cc659b2a9
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

and add a function to make it possible for other blocks
that have different contents in edit/view modes
to ignore the height and let the gridstack library resize

behatnotneeded

Change-Id: I471e35d3881d7f3654cd508f7de31ebfdedfbc5c

 - updated old references using set_nav func when appropriate
 - delete peerassessment/edit.php as it's no longer used

Change-Id: Iabba2d703a89cce5655d4d6220caf352bf53ab1e
Signed-off-by: Lisa Seeto <lisaseeto@catalyst.net.nz>

This block allows one to import information from an external source
It requires the connection via webservices to
1) find out the external user id value based on the page owner's email address
2) fetch the course completion data for that external user id

Change-Id: I6c67feb470bbcb35b0c549a8467c9204a00c9389
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Lisa Seeto authored Jul 03, 2020 and Robert Lyon committed Jul 24, 2020

- add another regex pattern
- also get rid of files that the logged in user did not create
- added in func to replace special chars

Change-Id: I7490146bb76ed5dea82a168ac7893b8d7424e00f
Signed-off-by: Lisa Seeto <lisaseeto@catalyst.net.nz>

Some places in the javascript it is letting names to be not escaped

See bug for more information / testing instructions

Change-Id: I69df17bc8b6c55bf1ea7c098ee334d4b153aff32
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

- A new page setting “Template” is added to the
“Advanced” panel on all portfolio page areas of
Mahara (personal, group, institution, site)
with a Yes/No switch
- added 2 columns to view table:
'templatetocopy': indicates if the view is a
  template that can be copied
'originaltemplate': if it has a value then the view
  is a copy of a template and should have
  the instructions locked.
  The value it contains is the viewid of
  the original template.
- if a view is a copy of a template: display
instructions in view settings and text blocks
but don't allow to edit them. If empty, don't show them.
- When adding a new text block to a page,
don't allow to add instructions
- Allow to remove the lock on a copy for roles:
    site admins in institution and site pages
    institution admins in institution pages
    group admins in group pages
- If a template view is deleted from the site,
then all the locked copies it has will remain locked.

behatnotneeded

Change-Id: I47e98cf8413da5ba6d5dea0e29dddbd80c481317

Before checking if its count greater than 0

Change-Id: Idfc7e8272698a71abd616c0c6d79cbede65ec4d5
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Philippe Adrian authored Jun 09, 2020 and Robert Lyon committed Jun 22, 2020

-added root directory to redirect

Change-Id: I7037c2b01a84a146bc6ffc6961e4435115dd2c25

As the submitcancel element actually consists of two elements so we
will have a 'subclass' option that can target adding different classes
to each element.

Change-Id: I3efeeb937d4fecf38c3cb997fb8faea7a115b48e
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

As they have a foreign key to a sequence field on another table

Change-Id: I3851cda3b951ef7bbe9165a2f968d6b8fc863537
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Cecilia Vela Gurovic authored Feb 05, 2020 and Robert Lyon committed May 25, 2020

- show a table with a row per view in the collection
- show 2 columns for each role that can change the
signoff block: owner and manager
- allow the owner to sign off a block by clicking the
cell defined by the view of the block and the owners
column
- allow a manager accessing the collection to verify
a block defined by the view row and the manager column
- show captions over the icons to indicate the status
of the block
- help file for the progress completion header in file
htdocs/lang/en.utf8/help/pages/collection/progress.html
- progress completion bar will show the percentage of
possible actions to do on the views of
the collection: sign-off + verification

behatnotneeded

Change-Id: I5592f780203037b79c0b6410998ca291096b1964

behatnotneeded

Change-Id: I8d4a483f424911d7ef6efd897b631dd52ff5c3a6

Lisa Seeto authored May 04, 2020 and Robert Lyon committed May 08, 2020

- alter files to use attachments_from_id_list()
- alter attachments_from_id_list func params

Change-Id: I32b26586deb2f2a1b6a624f2c7afc4520a1a57ff
Signed-off-by: Lisa Seeto <lisaseeto@catalyst.net.nz>