Skip to content

GitLab

Switch branch/tag
  1. 29 Apr, 2021 1 commit
  3. 22 Apr, 2021 1 commit
  5. 01 Mar, 2021 1 commit
    • Gold's avatar
      Bug 1916833 - Annotation can be updated on a page · 690edccd
      Gold authored 
      Config gear icon removed from the Annotation blocks.
In order to still initially create these when added we needed to check
if the Block was a new instance or not. To achieve that we are now
passing the block instance into the has_instance_config() method.

BlockInstance has been extended and will set a 'new' parameter if the ID
in the constructor is 0.

AuthPlugin* classes also have the has_instance_config(). These do not
need the BlockInstance passed in.

Change-Id: Ifac69fc1d48b45c079b6f66e610776cead3dee63
      690edccd
  7. 21 Sep, 2020 1 commit
  9. 17 Sep, 2020 1 commit
    • Evonne's avatar
      Bug 1845053 Font size and size variable · 1d324796
      Evonne authored and Robert Lyon's avatar Robert Lyon committed 
      Base font has been increased to 16px, and as a result, variables
have had to be recalculated.

Max browser width has been increased to 1440px to allow the
larger font to have more characters in a line.

As a part of accessibility, headings H1-H6 have had to be rejigged.
Note that for elements such as popup/modals, the heading restarts
at H1 again as advised by Julius.

Page heading is H1, block heading is H2, everything else should be
H3. Trying to attempt to reserve H4-H6 for user content, but it is
still existing in some places as some things can't be changed.

Attachment markups have been unified and added to styleguide.

Removed H3/H4 from fieldset legends.

behatnotneeded

Change-Id: I69273c9775d658f03738c29be8d230b59c189790
      1d324796
  11. 07 May, 2020 1 commit
  13. 02 Mar, 2020 1 commit
  15. 17 Oct, 2019 1 commit
  17. 04 Oct, 2019 1 commit
    • Cecilia Vela Gurovic's avatar
      Bug 1813987: block resizing to fit content · 565776fb
      Cecilia Vela Gurovic authored and Robert Lyon's avatar Robert Lyon committed 
      should not resize blocks in view mode

in view mode, if the content of the block is static,
then the block dimensions should not change but the
content of the block should be made smaller

expand the height of a block only if the content is dynamic,
like the 'Journal' block

behatnotneeded

Change-Id: Ie8183736580e7e592b24e36f4a16618b96a5bf4e
      565776fb
  19. 25 Sep, 2019 3 commits
    • Lisa Seeto's avatar
      Bug 1827811: Resume Icons · 953a5eab
      Lisa Seeto authored 
      

- get attachment comment counts for bh icons
- display plain text for titles in editing mode
- change the way the commentlink is targetted via js
- add blockid's to resume attachments
- for folder block: add comment count, change titles from
	links to plain text when editing
- change notes attachment file titles from links to plain
	text when editing
- get rid of the single artefact block title links for html exports
---------------------------------------------------------
Add fixes:
- blocks that have set types but no artefacts attached don't have modal links
- pdf block is now using block header and comment count is loaded
- block headers are above titles
- tagged journals have icons when in full and matches recent posts styling
- deleting all comments produces correct icon on block header
- html exports should not hang on opening modal
- get rid of warning error re: dock.show() when redirecting from &modal=1 style url
- code review fixes for all previous patches + fix issue with folders block
- added in viewdetailsfilter.json.php file to save details mode to user account prefs table
- make the details btn mode "sticky" so it stays the save value over multiple pages etc...
- Image Gallery blocks: if displaying a folder of images will get the bar block header and
will have a the fancy box image preview displaying on image click

Change-Id: I425cc5a634e176d580aacdb60a20f869f7cb7496
Signed-off-by: default avatarLisa Seeto <lisaseeto@catalyst.net.nz>
      953a5eab
    • Lisa Seeto's avatar
      Bug 1827811: Notes block · 1885a18d
      Lisa Seeto authored 
      

do not show note contents when displayed in a modal.
if comments not allowed but license metadata is on, display details link and open model with license data.
make small change to setting of licensemetadata smarty variable
get rid of comments/details links and use the new block header instead.

Change-Id: I9183292278d06a3766ae08b0376237fda8d7206c
Signed-off-by: default avatarLisa Seeto <lisaseeto@catalyst.net.nz>
      1885a18d
    • Lisa Seeto's avatar
      Bug 1827811: Move "Add comment" and "Details" into modal with "Comments" · be7af61f
      Lisa Seeto authored 
      

create modal using configureblock id, update various templates to use the modal for blocks:
Image
Note
File(s) to download
Journal/blogs
add JS to open/close modal, add comments, delete comments, reply to comments, paginate comments.
add JS to handle url that redirects to view/view.php with modal open and populated.
Further changes to each block will be completed in child patches.
Add segment headings to the modal. Fix display of comments to cover width of modal.
Show comment removed msg in modal/page appropriately.
Fix behat test to close modal before continuing.
do not show existing comments if comments not allowed on artefact.
add validation to modal for comments/attachments
disable image as link when editing for image block
trigger focus on modal for accessibility
close modal on escape keydown event
fix merge conflict in view/view.php
fix merge conflict with master
make configureblock modal play nicely when comment block is on the page
update display of error messages to always show at top of modal so user doesn't have to scroll
add accesibility to close modal on escape key down
handle dock show/hide events for paginated pages in modal during validation
create block-comments-details-header template file
create details button and custom scss file with js to show and hide header
update comment links to save add comment and details when commentcount == 0
add active-block class to colour the block-header when active
toggle the details-btn active css
add _block-comments-details-header.scss to patch
change class invisble to class d-none
add block-comments-details-header.tpl to blocktypecontainerviewing.tpl
code review changes
add .no-modal class to links on group home page, dashboard and profile page.
add block header to appear above the title
change assessbtn from anchor tag to button to prevent scrolling.
make all clickable links clickable on page load (ignore assess mode)
fix js issues surrounding assessbtn move and show/hide blocks
change cursor on dashboard, my profile page, group homepage to default when over disabled modal links
update assessbtn to details btn
create tooltip for hover over file download block titles
fix containerElm console log error by not reattaching tinymce unneccessarily.
fix null named attributes issues on e.target when span (icons) instead of anchor is clicked.

Change-Id: I2e5218c040f8a9e252f785165ce9c566ecc2f56e
Signed-off-by: default avatarLisa Seeto <lisaseeto@catalyst.net.nz>
      be7af61f
  21. 31 Jul, 2019 1 commit
    • Kristina Hoeppner's avatar
      Bug 1811904: Font Awesome icon adjustments · 0a9c9356
      Kristina Hoeppner authored and Robert Lyon's avatar Robert Lyon committed 
      A few icons required adjusting to use only
free icons. Additionally, icons in the
card header in the "Primary School" theme
were changed or added in the first place.

Needed to update the card icons to use the correct font awesome family

behatnotneeded

Change-Id: Ief8f4b4393b1becfb18a8c39d3ef6b8966bbe9eb
      0a9c9356
  23. 26 May, 2019 1 commit
    • Kevin Dibble's avatar
      Bug 1044878: Editing duplicated content · 62d8203a
      Kevin Dibble authored and Robert Lyon's avatar Robert Lyon committed 
      Added a new feature that the user has to choose yes to
start editing copy. This will force users to interact with the
form before editing with the choice that they are editing
all copies of this content.

When selecting to use content from another note, the
form will update based on their choice. The editor will
remain open if yes has been selected. The editor will
be hidden and only the content will show if 'Yes' has
not be selected.

This is a UI element only - no decision is saved to the
DB as this is an editor based decision.

behatnotneeded

Change-Id: If44522c00672b296242893f0c876e7ff37561dd2
      62d8203a
  25. 01 May, 2019 1 commit
    • Kevin Dibble's avatar
      Bug 1044878: Editing duplicated content · 0df38c69
      Kevin Dibble authored and Robert Lyon's avatar Robert Lyon committed 
      Added a new feature that the user has to choose yes to
start editing copy. This will force users to interact with the
form before editing with the choice that they are editing
all copies of this content.

When selecting to use content from another note, the
form will update based on their choice. The editor will
remain open if yes has been selected. The editor will
be hidden and only the content will show if 'Yes' has
not be selected.

This is a UI element only - no decision is saved to the
DB as this is an editor based decision.

behatnotneeded

Change-Id: Idb8d6736796a2350359bd59395393f6c7d742f96
      0df38c69
  27. 19 Mar, 2019 1 commit
  29. 26 Feb, 2019 2 commits
  31. 27 Dec, 2018 1 commit
  33. 30 Sep, 2018 3 commits
  35. 31 Aug, 2018 1 commit
  37. 16 Aug, 2018 1 commit
  39. 07 Aug, 2018 1 commit
    • Cecilia Vela Gurovic's avatar
      Bug 1741987: Update jquery - Events · 3d1abcc2
      Cecilia Vela Gurovic authored and Robert Lyon's avatar Robert Lyon committed 
      Event
   Breaking change: .load(), .unload(), and .error() removed
   Breaking change: .on("ready", fn) removed
   Breaking change: event.pageX and event.pageY normalization removed
   Breaking change: jQuery.event.props and jQuery.event.fixHooks removed
   Breaking change: Delegated events with bad selectors throw immediately
   Deprecated: .bind() and .delegate()
     no calls to .bind() for events in core.
     Only calls to bind() refer to the js bind of arguments to functions.
     no calls to unbind() for event in core.
     Only calls to unbind refer to the unbind method defined in
     formChangeManager not related to the jQuery method.

    Warnings fix
    JQMIGRATE: jQuery.fn.click() event shorthand is deprecated
    - also applies to the other event shorthands, including:
     blur, focus, focusin, focusout, resize, scroll, dblclick, mousedown,
     mouseup, mousemove, mouseover, mouseout, mouseenter, mouseleave,
     change, select, submit, keydown, keypress, keyup, and contextmenu.

    JQMIGRATE: jQuery.fn.hover() is deprecated
    JQMIGRATE: jQuery(window).on('load'...) called after load event occurred
	(for FileBrowser we can see this error when editing a block in a page)

behatnotneeded

Change-Id: I1a50050f882b864ad63d273de160e0b441a77705
      3d1abcc2
  41. 28 Jun, 2018 1 commit
  43. 27 Jun, 2018 1 commit
  45. 11 May, 2017 1 commit
  47. 09 Feb, 2017 1 commit
  49. 11 Jan, 2017 1 commit
  51. 07 Sep, 2016 1 commit
  53. 15 Jul, 2016 1 commit
  55. 14 Jul, 2016 1 commit
    • Robert Lyon's avatar
      Bug 1438894: Moving the profile introduction text to description column · e305c12a
      Robert Lyon authored 
      

Currently all the artefacts that save html/tinymce data do so in the
description field - except the internal profile introduction field.

Seen as we are already doing special handling of this plugin we might
as well save the html/tinymce data into the 'description' column of
the db for consistency sake.

behatnotneeded - existing tests should suffice

Change-Id: I68da79f1c9423e19218162d8315008134251c31f
Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
      e305c12a
  57. 11 Jul, 2016 1 commit
  59. 27 Apr, 2016 1 commit
  61. 29 Mar, 2016 1 commit
  63. 23 Mar, 2016 2 commits
  65. 16 Dec, 2015 1 commit
  67. 09 Dec, 2015 1 commit