GitLab

Fixes in this patch:

- Moved artefact.php to artefacts directory to separate it from pages.
- Fixed reference to a wrong 'artefactonlyviewableinview' string.
- Removed add_to_render_path() and its calls which have no purpose at all.
- Removed 'artefact_parent_cache' table.
- Removed cron jobs related to 'artefact_parent_cache' from DB.
- Added 'path' column in 'artefact' table to easier calculate hierarchy.
- Added ArtefactTest.php for artefacts unit tests

Change-Id: Ia14cd85b94c32a950354446ee3565bd2964c625c
Signed-off-by: Yuliya Bozhko <yuliya.bozhko@totaralms.com>

Bug 1308294: The code doesn't *really* need profileicon or email,
because it can always fall back to showing the anonymous user icon.
However, the lack of profileicon and email fields can indicating
a coding problem, so we should show a warning if they're missing.

Change-Id: I9926b7a4457049ef097e16d7999f109a623f2644

Change-Id: I64162df4bcf3d3eb415f6693b26e3c41ac856e0c
Signed-off-by: Kristina D.C. Hoeppner <kristina@catalyst.net.nz>

1. Remove all institution collections
2. Remove all institution custom layouts
3. Remove all institution registrations

Change-Id: I87a36e601571054305e2948d460c2bb670825ee6
Signed-off-by: Son Nguyen <son.nguyen@catalyst.net.nz>

Bug 1314460: No need to remove $locked from $progressbaritems, because the
list of progressbaritems is limited by the $onlytheseplugins array, and that
has already had $locked removed from it.

Change-Id: Ie8418703d0333eaf2ef2ba8301ec235e4dcddd03

Only global variables are meant to be in ALL CAPS.

Change-Id: Ifa1b5e5d873c3f479dbafbd2f72cb2f4e8b9f919

Change-Id: I4f461e72074fb937baeb8a5abd35667d2e3cb407
Signed-off-by: Gregor Anzelj <gregor.anzelj@gmail.com>

- Adds template views to top of Pages list under Configure site menu
- Profile, dashboard and group homepage templates can be edited.
- Only layout and content can be edited.
- Templates are only applied to users and groups created after changes are made.

Change-Id: I35967950a37887b31595a4afbc19300dd070949f
Signed-off-by: Nathan Lewis <nathan.lewis@totaralms.com>

Bug 1314012

Change-Id: Ief2083df4e6781892c82d7f48cdbb23dc67ba4c0

Bug 1314012

Change-Id: I5e19266e8379fa1244cafafa147e20b7a23a0895

This lib provides the function group_homepage_url()

Change-Id: I70c1c3b411180758a9bcc363aa3377513c915a19
Signed-off-by: Son Nguyen <son.nguyen@catalyst.net.nz>

Bug 1311963. The call to get_records_assoc() assumes that institution.name
will be the first column returned. But we've added an institution.id column
that comes before that, so now we need to specifically tell it to use the
name column instead.

Change-Id: I51ef6e805b80894fa6af7bc732fb241adac0fdec

Bug 1311940: Also, a pieform button-level submit function is meant to redirect
at the end every time. And this one was not.

Change-Id: I7b71311df9aa29db9b5d7c892a0ee8b13442f7b3

Bug 1311940: There's an obscure pieforms feature where a form can have multiple submit
buttons, and each submit button can have its own submit callback function named
{formname}_submit_{buttonname}. These functions are supposed to redirect at the end.
If they don't, due to a bug in the implementation of the global form message we currently show
an error message at the top of the form saying there was something wrong with the user's
submission. Instead, we should just let the form go through, and log a debug message for
the devs.

Change-Id: Ib0e9b7e2f58737c9c736bdd1c033bc020985a60b

Bug 1311454

Change-Id: Ie9e280e72cfccf12d9e9d6e15b66b422b5ca0e3d

Since the owner of a page who shares it with the
group does not receive notifications anymore as
per Bug #1267861, the lang string for the help
text needed updating.

Change-Id: Ie5abcdae9b839fb4919f14f1fa5c6b33dfd271c7
Signed-off-by: Kristina D.C. Hoeppner <kristina@catalyst.net.nz>

and allow site pages to use site skins

Change-Id: Idf8a8a761c850ed609f78ed65175ee82c3370e2f
Signed-off-by: Son Nguyen <son.nguyen@catalyst.net.nz>

Bug 1310861

Currently if someone marks a page, that has comments set to off,
objectionable then eveyone that can access the page can now leave
comments.

Have adjusted it so that only admins can leave comments.

Change-Id: I82bd01814e73c39b056082965a6b483e6346a82f
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Bug #1308479

Allow the same license, licensor, licensorurl help files to be accessible
in block instance config form for both the 'license' section and the
attachments 'license' section

Change-Id: I20dc64c6d4c3cf25138c46348c2d8e5bf7a8fc94
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Also changed image popup plugin (used in Journal) to be an actual plugin
which should be easy to integrate into other pages

Change-Id: If57572f34afb1ac4abf012bab32a3966dcfd41ce
Signed-off-by: Jono Mingard <jonom@catalyst.net.nz>

- Replaces require_user and require_test_user with create_test_user
- Added create_test_group and create_test_institution

Change-Id: I8f2acbeef986943cbb4712f47226456fdf3d9570
Signed-off-by: Nathan Lewis <nathan.lewis@totaralms.com>
Signed-off-by: Yuliya Bozhko <yuliya.bozhko@totaralms.com>

This is due to the dummy 'root' user having the same id, which is 0, as
an anonymous user.

Needed to not include the dummy 'root' profile page in the get views
and collections db call.

Change-Id: Id349bdb193e510df5ecbc6f76a6324dbc15a2a57
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

So that we can later use them separately for artefact level access,
and report artefacts separately from pages.

When testing, everything should work as it worked before with
reporting objectionable material.

Also fixed "Creating default object from empty value" error
when ActivityTypeObjectionable object is constructed.

Change-Id: I6d95a5546b2425d9b522435da26902e420139d84
Signed-off-by: Yuliya Bozhko <yuliya.bozhko@totaralms.com>

- Each activity type can specify a default notification method. They default
  to 'email' to remain backwards compatible.
- Each activity type can specify if it is allowed to be set to 'none'. Defaults
  to 'allowed' for backwards compatibility.
- Removed 'required' from notification settings - it didn't make sense, and the
  change above deals with this in a better way.
- The site wide defaults for each activity type can be edited in
  Site options -> Notification settings. These are applied to new users or
  whenever a user does not have the appropriate usr_activity_preference records.
- Removed 'Default notification method' as it's functionality is now covered by
  the change above.
- There is a separate help next to each activity type to explain what messages
  will be affected by the setting.

Change-Id: I131cdeefbeaa8e43688aefd9d770fc8cb9bceea8
Signed-off-by: Nathan Lewis <nathan.lewis@totaralms.com>

And making sure that it exists in the db before using it.
This allows the fetching of the id of the default column widths to be
used in view layout page.

Also tidied up the js for the view layout page so it uses the value
from php rather than hardcoded string.

Also removed duplicate 'if (empty(self::$layoutcolumns)) { }'
statement from lib.view.php

Change-Id: Icf1b4292a256c5ff6d748c9e6046d6c71ea298b2
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>