GitLab

Includes fixes for:
mysql/mysqli: Fix ability for MetaTables to filter by table name,
broken since 5.15.
See http://phplens.com/lens/lensforum/msgs.php?id=19359

postgres8: New class/type with correct behavior for _insertid().

postgres9: Fixed assoc problem.
See http://phplens.com/lens/lensforum/msgs.php?id=19296

Change-Id: If54f95815015ab9b7f58e102fb6c65cd086b8ac2
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

1. Data generator
2. Config manager
3. Form fixtures
4. Some sample test features

Add shell script for running Behat

Moving core feature files to 'test' folder outside the docroot

Fix Mysql bugs

Change-Id: I00f3558c178541ae7f81ce9fb1ce6226e7a9654e
Signed-off-by: Aaron Barnes <aaronb@catalyst.net.nz>
Signed-off-by: Son Nguyen <son.nguyen@catalyst.net.nz>

Requires https now - used to work with http but no longer

Change-Id: I4aae1d36c532dcdfc96b5a4a673910b654ea9a2c
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Change-Id: I7a1f7d42d9739a9ab1507d56aaf3a51ee0e7ef1a

... in order to silence all the E_ALL notices

Change-Id: I0fdc9fc68ae7ffd2fa2dffe68dfbd79ee9599c06

Change-Id: Ie6c593d72dd869db59b7aba26c428ea74f14cb7b
Signed-off-by: Yuliya Bozhko <yuliya.bozhko@totaralms.com>

Bug 1394820

Change-Id: I710098cb96ac7d0868926a95c4b4488df4753e4c

* changes:
  Quota percent 'divide by zero' error (Bug 1393584)
  Fixing type checking on min/max values (Bug #1394732)

Scenario/testing:

- Create an account, say User A and logout as admin.
- In one browser login (this will be the hacker user)
- In another browser reset pass via forgotten pass link

What should happen:
User in browser two should be able to reset pass then navigate about
as when normally logged in. User in browser one should be forced to
login again as their user sessionid is not valid anymore.

Before patch:
malicious user still has access until $USER->logout_time time expires

After patch:
malicious user foreced to re-login straight away on next page load

Change-Id: I42ad907e5ffa7c128742a159116cf20dc6cd9b8a
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Change-Id: Ic29fccfa3f523a984af60871afe89f7c157b33fa
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Change-Id: I4f75dfc9f34c3f9e3f01d8d459b6ec7a43f13689
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Change-Id: I252c5f763ccc83d846f5dcc7fd086d723b31e2e6
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Change-Id: I042c1127f7601483e8723b2e31bf07683accf2c0
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Bug 1394330

In most places in mahara we specify that we want base 10 number
returned (or base 16 in case of a hexidecimal css colour)

But there are a few places where we don't specify the radix at all

It's best practice to always include the radix because for older
browsers it interprets leading 0 as octal by default.

Also makes it clearer to developers what type of number is expected to
be retrieved from the string.

Change-Id: Iaecc85cbed875f85b313188c4e96cc1b77c77b31
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>