GitLab

Signed-off-by: Aaron Wells <aaronw@catalyst.net.nz>

behatnotneeded

Change-Id: Ie1b754da7d1cd1beaeadc0579890639e7d2623b7
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit d846632a)

Bug 1558361

behatnotneeded

Change-Id: Ic7186f35eb38cf79e76dcd8347df18178ccc5a32

behatnotneeded - should be covered by existing tests

Change-Id: Ia4592c9bd261c978dc911999e81f906fa0b13450

Also setting the note block's form change checker state to
"dirty" by default, so that users will get a warning before
navigating away to the other page.

Change-Id: I20f586781df63e942a7a1c82e5e74fd5214c233f

Bug 1558361

behatnotneed

Change-Id: Idc3f0a010fef76a0908f65ce88bf52ae870170d3

Bug 1558361: Deleting this because it has some target="_blank"
links in it, and we're not using it anyway.

Change-Id: I270e9b4928488715c6c3fff1728e8060a575379b

Bug 1558361

Change-Id: Ifb0dba0d91a0ea2ba2b2dfc2daeda39b679c0397

Bug 1558361

behatnotneeded

Change-Id: I4bebbcca92bd9cbd594ca7d8d83030f6f3e0388b

Bug 1558361

behatnotneeded

Change-Id: Idc139a671137cbde6958fdc8406bc56f8c395f08

Bug 1558361: TinyMCE will filter them out on the editing
side, and HTMLPurifier will filter them out on the display
side.

behatnotneeded: Would require non-trivial new Behat step to
check whether links have "target" attribute.

Change-Id: If27462b2ca1a382ceeaadb374aade1f795f261bd

Aaron Wells authored Mar 23, 2016 and Robert Lyon committed Mar 23, 2016

Bug 1560730: In 15.10, where there are combined text
field & filter-dropdown fields, we use Bootstrap
magic to combine them into one succinct little thing

Change-Id: I8c9756194a60d4505ebb2840718e6b114dd8aaa5
behatnotneeded: Covered by existing tests
(cherry picked from commit b6c6044b)

Bug 1560739: As a temporary workaround to our apparent
incompatibility with gulp-bless 3.1.0 and/or bless
4.0, pinning gulp-bless to 3.0.1 fixes the problem.

Liam Sharpe authored Jan 11, 2016 and Robert Lyon committed Mar 23, 2016

Comprises two fixes:
1. Icon in profile sidebar next to the Moodle instance's
name
2. Mentioning of the Moodle instance in the "Online users"
sidebar

behatnotneeded

Change-Id: I3c1c09df9156834dc79313b8c30e5264dda2e6ad

Aaron Wells authored Mar 15, 2016 and Robert Lyon committed Mar 22, 2016

Change-Id: I71c3afc2b3a4e07f4bbba1bb356d86911ab4b332

Sometimes the object holding the user data is a StdClass rather than a
User object

behatnotneeded

Change-Id: I39f1333eac08876653a427488280859db1022a90
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 8177e874)

Aaron Wells authored Feb 09, 2016 and Robert Lyon committed Mar 22, 2016

behatnotneeded: Visual change only

Change-Id: I19bf094ed0ec134d75af7a548920b34ceb1020ee
(cherry picked from commit 892c33e3)

Gary Leydon authored Sep 30, 2015 and Robert Lyon committed Mar 22, 2016

behatnotneeded: error appears in error log

Change-Id: Ic816248ee56bcae7daa1f13c768afdab92c95b23
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

This was working if you drag/dropped files but not if you clicked the
'Add' button

behatnotneeded

Change-Id: Iae131208699ad0fc2bb0c54f221a7ae122b090ff
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit d070adbe)

Includes fixing up how we access select2 both via ajax and for
existing list.

Have added a simple behat test for sending a message as that uses the
select2 in an ajax way

Change-Id: I3aa6722169c61e4fc2ad196a02fa5bb696761210
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Aaron Wells authored Feb 04, 2016 and Robert Lyon committed Mar 22, 2016

X-XSS-Protection: Tells the browser not to disable XSS protection

X-Content-Type-Options: Tells the browser not to try to guess at
mimetypes of downloads

X-Permitted-Cross-Domain-Policies: Tells Flash & PDF not to trust
alternate crossdomain.xml files (which set the permissions on whether
this site allows itself to be accessed by scripts in Flash & PDF).
Prevents an attacker from uploading a more permissive crossdomain.xml

X-Powered-By: PHP by default sends this header with the current full
PHP version.

behatnotneeded: Selenium can't examine HTTP response headers

Change-Id: Ia2a6de971fc62b7d8806ad010aa0fbe37c1a7357
(cherry picked from commit 29656f03)

Now that 'mahara' can have blog/blogpost artefacts we want to ignore
them from site menus options for logged in links

Change-Id: I8d1be32678ae97d93187181eb4aedcb331e543eb
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 130890b2)

Pat Kira authored Mar 18, 2016 and Robert Lyon committed Mar 21, 2016

behatnotneeded

Change-Id: I6c59b9bb13384f0a4cdf71d1ab82fb219a9137ee
(cherry picked from commit df4492a0)

There was a setting to stop the login link (top right) from showing if
there were sidebars on logged out homepage. This became a problem if
the login box was turned off (not counted as a sidebar block for some
reason) via $cfg->showloginsideblock = false;

But the top right login link should always show when logged out
whether a sidebar is in play or not.

behatnotneeded

Change-Id: I8d6c1916f165285afb1f0210a0ae9b364f3a7a4f
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 51910ec5)

* changes:
  Bug 1530613: Getting excluded tags to work with Select2 4.0.1
  Bug 1484781: Added aria-hidden=true to all icons
  Bug 1512528: The edit access 'Shared with' users fails to paginate
  Improve accessibility of select2 (Bug #1492081)
  Bug 1423410: eliminate bulk permission syncing on view/access.php page
  Bug 1533971: Adding v4.0.1

Aaron Wells authored Mar 16, 2016 and Robert Lyon committed Mar 19, 2016

Bug 1557896: When you first click in Select2, it fires off an
aqax request with no "q" value (because there's no query string
yet). We return a "required parameter missing" error message in
a JSON object, which causes a Javascript warning in the browser.

Better to just treat it like an empty q, instead of a missing q.

behatnotneeded - unable to test for issues in console

Change-Id: I81c4cfe77c51fce735cfd2628aaed1e40cc35940
(cherry picked from commit 28fcc277)

behatnotneeded existing tests should be enough

Change-Id: I6316c6301c703353928c9e6210e02cdfc25151a8
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
Signed-off-by: Aaron Wells <aaronw@catalyst.net.nz>
(cherry picked from commit 1f9bbefe)

Liam Sharpe authored Dec 07, 2015 and Robert Lyon committed Mar 18, 2016

behatnotneeded

Change-Id: I01dc196e0c9931d5cb4be926e7d3c8ce17e06546

Normally it should load more options if they exist when one scrolls to
the bottom of the list, but was not working as the 'more' bits of code
were left out.

behatnotneeded: can't test a select2 that loads data via ajax yet

Change-Id: Ibc5682392d0006c66005a6da27904ed59b97417a
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Jono Mingard authored Sep 10, 2015 and Robert Lyon committed Mar 18, 2016

- Modify the AJAX data adapter and search box so that items are
  read out when moving up and down through them with the keyboard
- Link select2 instances to the label(s) of the original <select>
- Allow removing tags with the keyboard
- Hide original <select> completely instead of leaving it
  accessible to screen readers
- Keep focus position when loading more elements with infinite
  scrolling
- Add behat step to set select2 value(s)

behatnotneeded

Change-Id: I6b380f74525c2ca3c38070744d71d1812cec05b0