GitLab

Masquerading (aka Loginas) is a useful and sometimes indispensable function.
However, previously it was rather too powerful, because admins can do anything
as the target user, with no indication that it is not the user themselves doing
so.

This feature adds some auditability to masquerading, by logging and reporting
who, when, why and (partially) what, as well as notifying the affected user.

See also bugs: #900983 and #1027574

This commit changes the masquerading feature itself to request a reason from
the admin masquerading, notify the user, and emit an event (for logging by the
next commit).

Change-Id: I066e9fdeb4d2e00679b2aa9b0b839cb4b78629a8
Signed-off-by: Jiri Baum <jiri@catalyst-au.net>

The forum post notification subject showed the "topic" subject.
This has been changed to the "post" subject.
Also the get_ancestorpostsubject section has been moved from topic.php
to fix this bug.

Change-Id: I740a0f416bc60401d2a4a5d5be59b7bd9feb85b9
Signed-off-by: Janice <starboltangel@gmail.com>

Completed the fractured description sentences
on the 'Portfolio' >> 'Export'  page.

Change-Id: I530e2ec7ad64bc041f47b6e5e185eff5103c631b
Signed-off-by: Ali Kaye <alexandrakaye.student@wegc.school.nz>

Capitalised the 'I' in 'Institutions' on the title.

Change-Id: I5337e311d73adf38e99c5392693c6c6784d2b230
Signed-off-by: bonnie <kurousagiwasugoi@gmail.com>

Added 'Default registration expiry lifetime' and
relevant dropdown box to 'Account settings', plus
adding how long the administrator has to approve
registration to the email alert.

Change-Id: Ic2df962730b10e6df4ccccaa539e415640f024b8
Signed-off-by: Ali Kaye <alexandrakaye.student@wegc.school.nz>

I added the year that the post was posted onto the forum
so that people won't be confused with just the month
and day.

Change-Id: I8d15fa522770c842268fb66788b5b1fdc969ffab
Signed-off-by: bonnie <kurousagiwasugoi@gmail.com>

I increased the limit of the list of collections on the
'Collections' page under the 'Porfolio' tab, from a limit
of 5 to a limit of 10.

Change-Id: I59310968200137b20c73bf1074fca232fa5415ca
Signed-off-by: bonnie <kurousagiwasugoi@gmail.com>

I have capitalised the word 'Institutions' under
'Manage Institutions' on the /admin/ page.

Change-Id: I63bef8ee9da2e43fb960c2599d2f7ca890b01888
Signed-off-by: bonnie <kurousagiwasugoi@gmail.com>

On /admin/users/institutions.php I changed "Institution expiry date"
from italics to normal text.

Change-Id: Ic1e557aa44fe25568693f56948e4cc6a8e1f3aba
Signed-off-by: Janice <starboltangel@gmail.com>

I created a new string to replace "Share" in "Portfolio" to
"Shared by me"
I also moved "Shared pages" from "Groups" to "Portfolio" and
renamed it "Shared with me". This is located between "Shared by me"
and "Export"

Change-Id: I5bb0a002ff1f41305334a7cf1f27940837d4d03b
Signed-off-by: Janice <starboltangel@gmail.com>

I added a line in the file 'customcss.tpl' so that when
the 'Text on Background' colour is changed, the top right
navigation changes colour as well.

Change-Id: Ib778c57fa363f8c20efb6e3d336196d2c8fbf358
Signed-off-by: bonnie <kurousagiwasugoi@gmail.com>

I deleted the description and header before the "Suspend user" box
and added a short description below "Suspend user".
This is done so the instituition admins are not mislead.
Signed-off-by: Janice <starboltangel@gmail.com>

Change-Id: I7ee4ca20555bd247993240fbd1182d66a28f0332
Signed-off-by: Janice <starboltangel@gmail.com>

Modified mahara.php and lib.php so that when
a user with a deleted account tries to log in
they are told 'Sorry, your account has been
deleted. You can contact the site adminstrator,'
with a link to the 'Contact Us' page.

Change-Id: I89b31cb458afa87a75acbb09293050c5c64e7da0
Signed-off-by: Ali Kaye <alexandrakaye.student@wegc.school.nz>

Modified mahara.php and lib.php so that when
 a user with an expired account tries to log in
they are told 'Sorry, your account has expired.
You can contact the site administrator to have
the account reactivated,' with a link to the
'Contact Us' page.

Change-Id: I6b461d40e37a88ac513649a1d4a6d83c5d3711a4
Signed-off-by: Ali Kaye <alexandrakaye.student@wegc.school.nz>

Changed 'entry' and 'entries' to the proper plural mechanism instead of
 the original hard coded logic.
This also fixed the space between (number of entries)entry
for example '0entries' and '1entry'

Change-Id: I8906e6760d01e4e53bc07635de0d2852f677c4f7
Signed-off-by: Janice <starboltangel@gmail.com>

This patch allows the dwoo function str to allow falsey arguments,
such as 0, false, etc etc

Change-Id: Ic7a6733288bc662b84e9535cd3c7d0b52d090681
Signed-off-by: Hugh Davenport <hugh@davenport.net.nz>

I've removed the 'word-break: break-all's from the
file 'style.css' so that long titles won't overlap
the 'edit' and 'delete' buttons and shouldn't break
randomly.

Change-Id: Ie60174aafd5ff817b4b99b70f75e084e2adba930
Signed-off-by: bonnie <kurousagiwasugoi@gmail.com>

Changed the limit of the amount of members shown
so that a maximum 100 can be shown at once on the
group home page instead of a maximum of 40

Change-Id: If0b8a8ddd3a8e1d23bc4cf55ba1d9b527c7ad076
Signed-off-by: bonnie <kurousagiwasugoi@gmail.com>

Changed width of name, email, and subject input fields
in the 'Contact Us' page in the css.

Change-Id: I77956507694079c342cb7431fb9679839f882653
Signed-off-by: Ali Kaye <alexandrakaye.student@wegc.school.nz>

Checking for the datatypes returned, and catching exception caused
by a previous exception object getting passed to the database,
which adodb doesn't know what to do with, surprisingly enough.
Making use of try to better handle failing record updates.

Change-Id: I884021aca8d3cb416acab575151ed97d7d64d3ed
Signed-off-by: Melissa Draper <melissa@catalyst.net.nz>