Nelson Moller authored Jul 17, 2017 and Robert Lyon committed Sep 26, 2017

Choosing the correct language for the confirmation message sent when
a user is added to an institution that has a different language than
the site default.

behatnotneeded

Change-Id: I832a18777654dc82d506e3d3a1238a74c6a6bdd7

behatnotneeded

Change-Id: Iddb57a880675ec6097f19a597cd2e8f1083534ba

If it doesn't already exist in Mahara and we pass in the
'forcecategory' parameter with value '1' for true

behatnotneeded

Change-Id: Ic5c7023262b9683153463940139ae8c22645eba8
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

behatnotneeded

Change-Id: I589cc42dd543ea4edfa418de8b85b711d3f0dd3e
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Now that it has been obsolete for 1 year

behatnotneeded

Change-Id: Ifa784d9e815b950e4d8725a99acfc57e098ade65
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

This value would be present in < 1.10 versions

behatnotneeded

Change-Id: Ic92beea1a209580f798716227a7c53fb600a8869
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

As we don't need to record user interation at this point and it breaks
things on upgrade from old systems as some of the
tables/columns/sequences do not exist

behatnotneeded

Change-Id: I7d6f8969f9b94ba93761c0c25303e2e4916fa778
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Cecilia Vela Gurovic authored Aug 28, 2017 and Robert Lyon committed Sep 22, 2017

behatnotneeded

Change-Id: If1e267fb551faff3be2537b14a6b8917b263dddd

To test: This breaks install in mysql

behatnotneeded

Change-Id: I5fd4310fab0a3de3a49c2f9eff2bb27ff8ba5311
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Robert Lyon authored Sep 15, 2017 and Cecilia Vela Gurovic committed Sep 20, 2017

behatnotneeded
Change-Id: Icae9cab6f9050982a061f3b31680a5bbd9c5b89a
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Due to missing column 'logoxs' as this column has not been added yet

behatnotneeded

Change-Id: Ie744485923c1566f10081ab98f16a1e2b08baf5a
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

We want to record things like so:

resourceid = view_access.id
resourcetype = what type the view_access row is for, eg 'token',
'user', 'loggedin' etc
parentresourceid = the id if the view the access is for
parentresourcetype = 'view';
ownerid = the id of the owning resource, eg usr.id / group.id / institution.name
ownertype = what owns the resource, eg user / group / institution

Also this patch adjusts how we index things into elasticsearch

behatnotneeded

Change-Id: I079a42ded2fefaab64a6e49fc26e8aad303c9e8a
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

By supplying $primarykey and $returnpk parameters to the update_record
function

behatnotneeded

Change-Id: Ib2078384cf2d48e4cea1b08f804ea01dc8e9b1d4
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

This patch will contain the fixes for:

- Navigation placement
- Collaboration report
- CSV's of reports
- Overview page for the graphs
- Making Institution selector a select2 field
- Moving all configs for reports into the modal and combine 3rd level
menu with submenu choices in select2 field
- Ignore non logged in users from user activity report
- Move more variables for reports into sticky (session) vars
- Allow results to be fetched from elasticsearch

Change-Id: I725b7615ac3cd6b1d9b6352bae9f6be0d5161e1b
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Introduce a new navigation bar to allow going through the different
types of reports:

- Change the page title according to the selected report section and
  report
- Decide which columns to display in a report
- Configure reports via the "Configure reports" button

Add existing reports into the new interface.

Create new and expand existing reports:

- User activity
- Page activity
- Collaboration

Sponsored by the AAIM project with funding from University of
Sussex and Dublin City University.

Change-Id: I1eb6920890af27c34c902fe22ff5ce3591b73cb0
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Add 5 new new columns to event_log table make searching over the
data easier and also record the id of any parent/related info as well

Eg, if one deletes an image block from a page we now record:
id - the event id
resourceid - the block id
resourcetype - the blocktype, eg image
parentresourceid - the id of the parent, eg view id
parentresourcetype - the type of parent, eg 'view'

Because we would not be able to find related view info from just the
block id anymore.

Also added the ability to index and search over event information in
elasticsearch search type event_log

Change-Id: I280c1c75c35a6c58f42d8acb36cf5c24c70b902d
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

When we have $cfg->publicsearchallowed = true;
and are viewing the site when logged out and have langpacks installed
we get an overlap of the language selector and searc box.

When we don't have langpacks installed the search box doesn't align to
the right.

This patch tries to align things up correctly

behatnotneeded

Change-Id: I6f2175af0aa9e164f4c4302f4c1e7012423d1235
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

When the shortname is uppercase and we upload groups via csv

Also forcing shortname to be lowercase if editing group shortname

behatnotneeded

Change-Id: I85307b974be129dd2f22528cc0ce0802fe3d6080
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Gerald Quimpo authored Jul 28, 2017 and Robert Lyon committed Sep 08, 2017

   "Bug 1694171: Elasticsearch rewrite" Totara commit.

   Minimal merge only since the Totara patch does much that we don't
   need or want (e.g., ES becomes the only search engine).

   Remove elastica

   TODO: remove this TODO when faceted search is fixed, either in
   this commit or a follow-on.

Change-Id: I1a6b589900eb689e488c21d36f40729b541f1d19
Signed-off-by: Gerald Quimpo <gerald@catalyst.net.nz>

Fergus Whyte authored Jun 02, 2017 and Robert Lyon committed Sep 08, 2017

from https://github.com/elastic/elasticsearch-php

and removed the docs / phpunit tests

behatnotneeded

Change-Id: I483f7625677e2bde74847877fcae89c5c752fddb

also fixed behat tests
and comments

behatnotneeded

Change-Id: Ic56c1ccf652f00312c40e4093ec73666096ed80a

under 'Group pages' section
WR#278529

behatnotneeded
Sponsored by SWITCH

Change-Id: I5a722527fca5e5f388113e69bcdcaf35b176b31e

If we are trying to fetch only 1 field then we can't use the
$rs->GetAssoc() function as that expects 2 fields minimum.

We can get around this in lib/dml.php by creating our own assoc return
object.

behatnotneeded

Change-Id: I6a4a9beadc4abeebc5d73bac6128d56f46ce4676
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

behatnotneeded - to come later

Change-Id: I42f40d997559c4fda132e9c36dc8e2c9d016c61e
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

behatnotneeded

Change-Id: I488cc4cfffdc9c30f67f001c6d7ce72ae71cc20d

behatnotneeded

Change-Id: I035644f81d46ade96bc9bcf7b37d176cb235405d

Fix for broken function calls when selecting a
radio button in a list of notes, deleting and
marking as read messages in the inbox/outbox

Change-Id: Ia5f4b2a1f977d319ccd813a2499b29c98b15f6a0
behatnotneeded: adding a behat test later

The way it worked before, to add a mapping file we
have to edit the saml config.php code

With this patch, to add a mapping file we can set the variable
saml_custommappingfile with the path to the file
in the mahara config.php file

behatnotneeded
Change-Id: I6396930da8dfdbe1904e469f309cdb4e38d46757

sortby field was being forced to be 'lastname'
sortdir to be 'asc'
in the search url for each header.

behatnotneeded

Change-Id: I6c78eab1c8570bb0408c08a34d2f62890313085c

Fix for error when searching for a note in Note block

behatnotneeded

Change-Id: I95d420a596fd1b118dbc90bb43d645a63e8cf0c6

Fix for tag search when they have a character changed by urlencoding()
Fix for tag display in Tagged posts block when tag has a character
  changed by htmlspecialchar()
Fix for not executing javascript inside the text of a tag
Fix to delete blocktype_taggedposts_tags entries when deleting a
  tagged posts block

behatnotneeded

Change-Id: Ic4a56ea90457e605c99203f0b355def93a04baa1

We need to avoid the sprintf() error if lang string expects extra args.

We can do this by supplying function check_string rather than
format_string

behatnotneeded

Change-Id: Ibfc2d9a552f2d87b2f5f762bab2ff2ec76a73dca
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

behatnotneeded

Change-Id: I469f8136e287bb86eb17a32dbed48dec05b87969

Raoul Dorissen authored Aug 02, 2017 and Cecilia Vela Gurovic committed Aug 03, 2017

Added new keywords to be quoted when creating db queries

Change-Id: I699bbbf949ab6014da515bfa9d45bd4f2310f309
behatnotneeded

As part of the install process

behatnotneeded

Change-Id: I0d74698a61f74508d2ab8ed5dcb4695e39a0c3fd
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

In the screen that displays groups we can join
the functions associated with the 'join me' button
are given the correct group number (not the ones from
the first page of the pagination)

behatnotneeded

Change-Id: I1737947acd67258dd49f8c24bb69aacb5402aafc

Pramith Dayananda authored Jun 29, 2017 and Robert Lyon committed Jul 10, 2017

Changes applied to display_icon
New lang string added
behatnotneeded

Change-Id: Iad33ebc98c9402d9b38ad1fa4fabb3a11268d0ad

Pat Kira authored May 29, 2017 and Cecilia Vela Gurovic committed Jul 10, 2017

selected custom theme

Fixed the site logo falls the back to mahara logo (svg version) instead of
displaying the png version. This happens after adding svg in as an
allowed file extension.

behatnotneeded

Change-Id: I6cf22bed466b8b7ec86aa1386b8edd54112d37ac

Ilya Tregubov authored Jun 01, 2017 and Robert Lyon committed Jul 08, 2017

behatnotneeded

Change-Id: I26a13d2ef060078abd14bb21a61db147112a4100

Bring title, layout and skins into the same
"Settings" screen and display them in panels.

Still to do:
- Fix existing Behat tests where needed
- Remove code that is not needed anymore

behatnotneeded

Change-Id: I0da607187f1e2b7b03fc1ebbbbe205ca1d3e87c2