GitLab

* changes:
  Pagination changes
  lib/web.php: Changes to build_pagination()

* changes:
  Redevelop auth/saml - self-linking accounts, dual login
  Enable multiple auth_remote_user connections
  Add SAML based SSO Login link

Change-Id: I4e9ba99028f5fed2702c71f7327624ba72e30399
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

Bug #810302

Redevelop auth/saml:
 * remove cludged session handling
 * add sanity checking of ssphp config - must not be phpsession now (use memcache)
 * improve handling of original target URL on login
 * add config option to enable user-login-linking
 * add screen for user to login to local account for linking
 * add linking screen
 * improve error messages

(note: fixed code formatting error found by Jenkins)

Moved login string out to earlier commit

Change-Id: Ib93680e225c325b30b3dc200152590e5e81eaa95
Signed-off-by: Piers Harding <piers@catalyst.net.nz>

Bug #810302

Enable links to multiple auth instances to be maintained so that
users can have dual login eg: internal + auth/saml etc.

Improve validation around switching auth_instance and
changing the remoteuser at the same time.

Add checks to ensure remoteuser does not get clobbered by update
for another user.  Allow override for the CVS upload case (file == unit
of update).

Change-Id: I5321c0270aeaa93bd193e8e759b08ab7f8b50ded
Signed-off-by: Piers Harding <piers@catalyst.net.nz>

Bug #812113

Added 'jumplinks' and 'numbersincludeprevnext' options to some views.

Change-Id: I7bf296a11c16191369d11983c75e1252df315709
Signed-off-by: Eugene Venter <eugene@catalyst.net.nz>

Bug #812113

Implement new parameter options:
* Number of page jump links
* Number of adjacent page links to current page (per side)

Change-Id: I0e6975969bf15f3df5c2206093e2fc3ab0dbb3df
Signed-off-by: Eugene Venter <eugene@catalyst.net.nz>

Bug #810302

Add a link to auth/saml if the SAML auth plugin is enabled
This appears on all login panels
(whitespace given back)
Switched to checking auth_instance
Moved login string to this commit
This appears on login diversion page

Change-Id: Ia8a799396a9f33bc0cc6e0c59549e2464253ca31
Signed-off-by: Piers Harding <piers@catalyst.net.nz>

When rendering pages, only ArtefactNotFound exceptions are caught, but
navigation blocks can throw CollectionNotFound instead.  This change
catches all NotFound exceptions thrown when rendering block content and
block titles.

Change-Id: Ia52f2a8184e607dcb9868893a4acd6094d0dc35b
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

This commit does the following:
- Hides the lastinstitution tags on the user edit page
- Removes the lastinstitution displayname tag
- Adds a dropdown box on institution members page to filter users

Change-Id: I4b30ee9b8cab2cd902cde08397759fdc9743a2e1
Signed-off-by: Hugh Davenport <hugh@catalyst.net.nz>

Change-Id: Iae75d49ded45cf9a38dfbfcc0322b09d0e07b257
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

This patch also set the default configdata for blocktype of
groupviews so that the database matches the configuration
screen for new views. Where the configdata is null for
already existing groupviews, the configdata will be set
to the new defaults during rendering.

Change-Id: I22effce47b050892f881074659b60e0ca3c262e0
Signed-off-by: Edward Murrell <edwardm@catalyst.net.nz>

Bug #812113

Always display first and last page.

Change-Id: I65607bed4525dab65dc50d7abd23f33f8a550cd6
Signed-off-by: Eugene Venter <eugene@catalyst.net.nz>

Change-Id: Ib1fc29c29d41f51b4e30fa175c8465b4a25ba3f3
Signed-off-by: Kristina D.C. Hoeppner <kristina@catalyst.net.nz>

Bug #812066

IE 6/7/8 doesn't like trailing commas in JS arrays.

Change-Id: Ibd2c7f62112702403ec6ac55b8f8af16fc2795fb
Signed-off-by: Eugene Venter <eugene@catalyst.net.nz>

Bug #803179

Remove 'pagelinks' Dwoo plugin. Admin user search now utilises
build_pagination() in lib/web.php.

Change-Id: I3632fd0e722b81f485b40fc4f76b217dc029383c
Signed-off-by: Eugene Venter <eugene@catalyst.net.nz>

bug #605747 and bug #806501

When a user uploads a new profile icon, it now gets added to the
"images" folder in their files area. Profile icons are emphasised and
descriptions aren't editable. Warning notifications, when deleting a
default profile icon or when deleting a folder containing profile
icons, are implemented.
Signed-off-by: Eugene Venter <eugene@catalyst.net.nz>
Change-Id: I3f8c93c4b65814aa183f0eaa8e1739e750c87905

Commit 0c9774b9

 added a foreign key constraint on the profile icon
field of the user table.  But when a profile icon is deleted, this
field isn't updated in the global $USER object, unless the icon is
deleted from the profile icons page, so the bad profileicon can hang
around in the session, and then cause an sql error the next time the
usr table is updated from $USER.

This change will fix that problem when a user deletes their own
profile icon, however it may still be possible for the error to occur
if for example the user is logged in twice.

Change-Id: I2f8792fcd392be351b8ee9ac77337fd41b046a3d
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

If user has admin access on a group, reorder the list of pages so that the Group Homepage link
appears at the top, in both the page and the block

Change-Id: I6918a80b87de2b8004259dae8e5b5055c7db826e
Signed-off-by: Mikael Mrozik <mikael@catalyst.net.nz>

Bug #697843

Add additional page jump links between first- and current-,
and current- and last page links. These links will appear as
necessary/applicable and is scalable.

Change-Id: Ib5ece5d78832ccaab0fa5b4433a7eafbff103772
Signed-off-by: Eugene Venter <eugene@catalyst.net.nz>

This change was added to limit deleting of comments in standard groups
views to admins only, and admins and tutors in course groups. This commit
adds the functions
    User::can_moderate_view()
and
    GroupType::get_view_moderating_roles()
to implement this functionality.

Change-Id: Ifb8f4fc55d31fd7c5928c73c3d81710934bfdad8
Signed-off-by: Edward Murrell <edwardm@catalyst.net.nz>