GitLab

This patch only deals with:
1) removing passwords from existing event_log table data
2) stopping the recording of passwords into the event_log table
3) sets the reset password on next login for those users

It doesn't deal with removing the unnecessary cruft information
that will be handled by the bug 1692385

behatnotneeded

Change-Id: Id29148f78fa6918f5f5afcb89d211ccb3b60c95b
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

When copying a page with an annotation artefact on it

behatnotneeded

Change-Id: Ib40e6c4fdf2c31830c3855dcd5b5eedbcebce875
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Change-Id: Ib68c1b57bf8910702678b43b4499456ed88b53dc

Allow to set the theme in view table on the DB only when
  we have userscanchooseviewthemes = true and
  the theme is set when we are editing page

behatnotneeded

Change-Id: I16ef25e8efa6060aa7e5a30a44ed2f4698f6d625

To avoid potential upgrade problems

Change-Id: If2c70c092aa5e71e02e7180a9dc7062640f3ac9a
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

behatnotneeded
Change-Id: If45120ccbd387b7198a3e15b666d43f14386a9a2

Problem when upgrading from version where smartevidence does not exist

behatnotneeded

Change-Id: If2797efafa84fc3e6a90e9aef95ed4f4a3097796
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Fixing a spelling mistake in English.
No string ID change required.

behatnotneeded

Change-Id: Ie00c6ceb061cf0a09e65a4766f6f06ff6ec13075

behatnotneeded

Change-Id: I3a59c08e5bed2a43759cb30e44b246f4f1ea934c
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

This patch allows the dataroot/metadata/*.xml file to be named after
the idp rather than the Mahara institution.

Also added
- A select dropdown so that institution can pick existing auth to be
paired to
- Upgrade to rename the dataroot/metadata/*.xml file
- Check to stop being able to add blank metadata field
- An alert for user when updating metadata if other institutions are also being effected
- Delete the metadata if deleted institution is only one using it

behatnotneeded

Change-Id: Ie3f5cdc523404b1081352ede67aab591e79b6dbb
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Collection shared to a group was not displaying
in group page and shared with me page
after first page of collection was deleted.
Fixed by resetting the order when deleting a view.

behatnotneeded

Change-Id: I096114ecf50b7a3af6d1393b387073676a984006

To allow us to easily turn of a 'bad' auth when it is trying to
connect to a third party server but that server is not reachable.

Currently it makes logging in slow as it needs to timeout on that auth
instance before trying the next one.

behatnotneeded

Change-Id: Ieeaeeaeb1bc0aa61ed3faad8f3bf751edd9c1023
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

behatnotneeded

Change-Id: I68b0b86fe46945dc539193df789fa9f27cc70077

Currently set the group shortname/institution to NULL but now we
should leave shortname alone and change institution = 'mahara'

behatnotneeded

Change-Id: I390d5e8e17c3edca40a59438e5160db00fcc60fb
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

When a collection is submitted to a group and then
the group is deleted, then the collections are
released.

behatnotneeded

Change-Id: I7e242e5992d8abdafd5aa7b989fba65aa3928b37

Rather than shortname/institution pair

Need to fix up how mysqli checks for index when table name
is reserved word

behatnotneeded - existing test should be ok

Change-Id: I62e776a5497671f9455929a21d279f76cf3f4345
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

When an anonymous comment was left it would set up a watchlist for the
view to sent to root user (user id = 0)

This patch stps that happening and removes any existing rows in
usr_watchlist_view for usr = 0

behatnotneeded

Change-Id: I8a560ac778359d2f4c398a318c7abac3573bb348
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Oversight on initial patch - should have been picked up in testing

behatnotneeded

Change-Id: I940e1792a2843cda3569a771758a7e98a802a2bf
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

For the admin user on a site installed before version 15.04.1

behatnotneeded

Change-Id: I026efdf7e427fabcd75ba725c20f36b07ae50f94
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

The old ones based on lang strings

behatnotneeded - can't test dataroot

Change-Id: I08963fd73f2d2102c9c34535593e8afb50b6104b
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Large Maharas with thousands of users run into max execution
time errors.

behatnotneeded

Change-Id: Ie9d5e9d1edb6cd3682afb93e435ebb2d01be355e

Administrators may have removed the Glogster iframe.
Do not force an insert of the iframe and update it only if the admin still allow it.

behatnotneeded

Change-Id: I46f23cd01f86e72c435d5a456e3e56cd53f18bd0

In case we have any missing studentid/preferredname artefacts if a
user was created with webservices before it was fixed

behatnotneeded

Change-Id: I520d580b5af496260d524ea9434aace41a22bcc1
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

behatnotneeded

Change-Id: I8f36fb267bfbd1a910e0c7f092c0e4cfe490ecdb

To hold the id of the smartevidence framework the collection is using

Defaults to null

behatnotneeded: to come later

Change-Id: Idb33e0d71adca8cc089f97aa48826e69e6f16fa8
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

And avoiding storing full path to dataroot temp dir in db for imported
entries

behatnotneeded

Change-Id: I18fb3a76accd57517e340ce98a19f7b10bd4814c
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

If there are negative block_instance.order values in the database,
then we'll just drop and re-create the unique key on the column.

Change-Id: I3ef1507f82ae3dc24244e6236e173b6649a95d3b
behatnotneeded: Covered by existing tests

Two patches got merged with the same version update number so might as
well have the upgrade steps in the same 'if' statement

behatnotneeded

Change-Id: I2d9e24fc967a491d5a1d3d76e1f45bc8545ff4ab
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

It turns out a lot of existing code checks the boolean
value of usr.suspendedcusr to determine if a user should
be treated as suspended or not. The LDAP sync cron (and,
indeed, any code suspending users via a cron task) was
setting usr.suspendedcusr to 0, which is boolean false,
so these users would be treated as not suspended.

We are going to update all usr.suspendedcusr = 0
to a valid site admin ID.

Change-Id: Iecfbfd8a4cdd98d5d07149bb40c64308262ea234
behatnotneeded: Test to come later

This got added in 2010 via
commit 87a2c5f2

but we don't need it now, and will end up complicating the ability to
do views in multiple collections, so will remove

behatnotneeded  - existing tests should cover

Change-Id: Ie39a72442cae10727bf9f26ed86050e66e7df4bd
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
Signed-off-by: Aaron Wells <aaronw@catalyst.net.nz>

Part of the change is to remove duplicate view access rows as there is
no need to have duplicates of the exact same access for a view.

Adding the id to view_access will allow us to have different view
access for a view in multiple collections in the future

behatnotneeded - should be covered by existing tests

Change-Id: I8d3d6f0a011d0ed01a5ff2931e8e16d3000f4f16
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
Signed-off-by: Aaron Wells <aaronw@catalyst.net.nz>

Currently all the artefacts that save html/tinymce data do so in the
description field - except the internal profile introduction field.

Seen as we are already doing special handling of this plugin we might
as well save the html/tinymce data into the 'description' column of
the db for consistency sake.

behatnotneeded - existing tests should suffice

Change-Id: I68da79f1c9423e19218162d8315008134251c31f
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

* added new client connection manager screens
* added client connection manager backend

behatnotneeded

Change-Id: Iac103616c7a9cd68cc94ea301a4cb808fe090669

Not in use since Mahara 1.2.

Change-Id: I8aa24c11eb82a748465fc58eeadb4819061b8bcd
behatnotneeded: Covered by existing tests

Change-Id: I8ec8c26eb7bc8458e125aa0cc7ab0790657708a8
behatnotneeded: Can't test mnet in behat

And adding an institution selection to the Admin -> Group search

Also making sure that we can retain supplied shortname or throw error
if there is a clash

behatnotneeded

Change-Id: Ibbd6c05c1428e522c048b10c64389ebe3360473a
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

behatnotneeded

Change-Id: Ic5d4fbb3faa16afb893e45c5303449122c7cd368

behatnotneeded

Change-Id: Ib373e765d30a265f78944ef0066bc9895b3d68b9

1. Add some documentation to session.php explaining what
the session.gc_maxlifetime ini setting does.

2. If we can't access $CFG->session_timeout, use a timeout of
an hour instead of the PHP default of 24 minutes.

3. Limit $CFG->session_timeout to 30 days, because we're already
enforcing that limit in session.php

4. Add "usr_session.mtime" column so that we can delete old sessions
based on inactivity instead of creation date.

5. Make the cron delete old session files as soon as they've expired,
rather than padding that an additional two days.

Change-Id: I9da2b26217774566b1131e997724359715edb2fe
behatnotneeded: Covered by existing tests

This patch does 2 things:
1) Changes all groupviews blocks on groups that allow group
submissions but don't have showsubmitted set to set it as true
2) When creating a new group that allows submissions to set the
showsubmitted = true at that time.

Change-Id: I8dbc7f9f4919fbb21aded3ff0f2637152b4d3480
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>