1. 11 Dec, 2019 1 commit
  2. 17 Oct, 2019 1 commit
  3. 04 Oct, 2019 1 commit
    • Cecilia Vela Gurovic's avatar
      Bug 1813987: block resizing to fit content · 565776fb
      Cecilia Vela Gurovic authored
      should not resize blocks in view mode
      
      in view mode, if the content of the block is static,
      then the block dimensions should not change but the
      content of the block should be made smaller
      
      expand the height of a block only if the content is dynamic,
      like the 'Journal' block
      
      behatnotneeded
      
      Change-Id: Ie8183736580e7e592b24e36f4a16618b96a5bf4e
      565776fb
  4. 25 Sep, 2019 2 commits
    • Lisa Seeto's avatar
      Bug 1827811: Resume Icons · 953a5eab
      Lisa Seeto authored
      
      
      - get attachment comment counts for bh icons
      - display plain text for titles in editing mode
      - change the way the commentlink is targetted via js
      - add blockid's to resume attachments
      - for folder block: add comment count, change titles from
      	links to plain text when editing
      - change notes attachment file titles from links to plain
      	text when editing
      - get rid of the single artefact block title links for html exports
      ---------------------------------------------------------
      Add fixes:
      - blocks that have set types but no artefacts attached don't have modal links
      - pdf block is now using block header and comment count is loaded
      - block headers are above titles
      - tagged journals have icons when in full and matches recent posts styling
      - deleting all comments produces correct icon on block header
      - html exports should not hang on opening modal
      - get rid of warning error re: dock.show() when redirecting from &modal=1 style url
      - code review fixes for all previous patches + fix issue with folders block
      - added in viewdetailsfilter.json.php file to save details mode to user account prefs table
      - make the details btn mode "sticky" so it stays the save value over multiple pages etc...
      - Image Gallery blocks: if displaying a folder of images will get the bar block header and
      will have a the fancy box image preview displaying on image click
      
      Change-Id: I425cc5a634e176d580aacdb60a20f869f7cb7496
      Signed-off-by: default avatarLisa Seeto <lisaseeto@catalyst.net.nz>
      953a5eab
    • Lisa Seeto's avatar
      Bug 1827811: Move "Add comment" and "Details" into modal with "Comments" · be7af61f
      Lisa Seeto authored
      
      
      create modal using configureblock id, update various templates to use the modal for blocks:
      Image
      Note
      File(s) to download
      Journal/blogs
      add JS to open/close modal, add comments, delete comments, reply to comments, paginate comments.
      add JS to handle url that redirects to view/view.php with modal open and populated.
      Further changes to each block will be completed in child patches.
      Add segment headings to the modal. Fix display of comments to cover width of modal.
      Show comment removed msg in modal/page appropriately.
      Fix behat test to close modal before continuing.
      do not show existing comments if comments not allowed on artefact.
      add validation to modal for comments/attachments
      disable image as link when editing for image block
      trigger focus on modal for accessibility
      close modal on escape keydown event
      fix merge conflict in view/view.php
      fix merge conflict with master
      make configureblock modal play nicely when comment block is on the page
      update display of error messages to always show at top of modal so user doesn't have to scroll
      add accesibility to close modal on escape key down
      handle dock show/hide events for paginated pages in modal during validation
      create block-comments-details-header template file
      create details button and custom scss file with js to show and hide header
      update comment links to save add comment and details when commentcount == 0
      add active-block class to colour the block-header when active
      toggle the details-btn active css
      add _block-comments-details-header.scss to patch
      change class invisble to class d-none
      add block-comments-details-header.tpl to blocktypecontainerviewing.tpl
      code review changes
      add .no-modal class to links on group home page, dashboard and profile page.
      add block header to appear above the title
      change assessbtn from anchor tag to button to prevent scrolling.
      make all clickable links clickable on page load (ignore assess mode)
      fix js issues surrounding assessbtn move and show/hide blocks
      change cursor on dashboard, my profile page, group homepage to default when over disabled modal links
      update assessbtn to details btn
      create tooltip for hover over file download block titles
      fix containerElm console log error by not reattaching tinymce unneccessarily.
      fix null named attributes issues on e.target when span (icons) instead of anchor is clicked.
      
      Change-Id: I2e5218c040f8a9e252f785165ce9c566ecc2f56e
      Signed-off-by: default avatarLisa Seeto <lisaseeto@catalyst.net.nz>
      be7af61f
  5. 30 Sep, 2018 1 commit
  6. 06 Nov, 2017 1 commit
  7. 26 May, 2016 1 commit
  8. 24 Nov, 2015 1 commit
    • Aaron Wells's avatar
      Display icons for 3rd-party blocktypes plugins · 4f849ed2
      Aaron Wells authored
      Bug 1510421
      
      Defines a new static PluginBlocktype method, get_css_icon(), which
      fetches the name of the CSS icon to use for this blocktype. It returns
      false by default, which tells the theme to "fall back" to the old
      thumbnail.png instead. 3rd-party plugins can override this to
      specify a particular icon to use.
      
      All the core blocktypes have been refactored to extend
      MaharaCoreBlocktype, which uses the blocktype name as the name
      of the CSS icon to use. I also deprecated the "SystemBlocktype"
      class while I was at it.
      
      PluginBlocktype::get_blocktypes_for_category() now returns both
      the results of get_css_icon() and the thumbnail.png path, so that
      themes can decide which they want to use. (And of course
      thumbnail.png is served via thumbnail.php, so 3rd party themes
      can provide their own custom image files if they wish.)
      
      behatnotneeded: Requires installing third-party plugins to test
      
      Change-Id: Idb1ecfc7b21175913708e695788906c11133b0c0
      4f849ed2
  9. 16 Sep, 2015 1 commit
    • Robert Lyon's avatar
      Bug 1486763: Now deleting correct comment · 6da147c1
      Robert Lyon authored
      
      
      Was a problem with the old delete button being an image and so passed
      the _x value, which was then checked for.
      
      Changed it so it checks that the submit param exists, which is more
      robust
      
      behatnotneeded : problem of finding the row that you just deleted as
      all deleted rows have the same 'Comment removed by the author' text
      
      Change-Id: Iea379badd2d364112d107977b8f53a62ac272428
      Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
      6da147c1
  10. 24 Jun, 2015 1 commit
  11. 23 Jun, 2015 1 commit
  12. 15 Jun, 2015 1 commit
  13. 08 Feb, 2015 1 commit
  14. 04 Feb, 2015 1 commit
  15. 16 Nov, 2014 1 commit
    • Robert Lyon's avatar
      Altering how get_comments() works (Bug #1037531) · 535c66d4
      Robert Lyon authored
      
      
      As I'm adding in some new options and I notice that Bug #1326425 will
      also be adding options to get_comments so I thought it would be useful
      to make a default opbject of variables that one can call and alter
      with specific variables where needed rather than having to work out
      where in the function call list things need to go as that list would
      grow up to 10 options.
      
      Change-Id: I7111559c4d12a8de128b9526930729728a36555e
      Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
      535c66d4
  16. 27 Mar, 2014 1 commit
  17. 06 Nov, 2013 1 commit
    • Robert Lyon's avatar
      Creation of new blocktype 'comment' (bug #1245679) · 441aa7f2
      Robert Lyon authored
      - allow the feedback to display in a block.
      
      Things to note:
      1) The feedback block is only to display view's comments on the
      view/view.php page and NOT on view/artefact.php page.
      
      2) When in edit mode (view/blocks.php) the feedback block just
      displays a 'holder' message
      
      3) When feedback block is on page the feedback does not display at
      base of page anymore and when one clicks the 'Place feedback' link the
      feedback form pops up over everything similar to how editing a block
      works.
      
      4) As the feedback block only works/displays on the view page I have
      not fully integrated all the stuff that feedback creates ie js/form
      into the blocktype. I have left the view/view.php to do the js and
      render form - and simply position the form on the page with js.
      
      This means that if js is off the edit form will still be in it's
      old place. I felt this was ok because if js is off and the form was
      in the block it could mean things been too squashy if there was lots
      of columns.
      
      Change-Id: I1edaa886c5a0df1f6feb24bcdd6d8878a833d673
      441aa7f2