1. 16 May, 2021 1 commit
  2. 12 May, 2021 1 commit
    • Doris Tam's avatar
      Bug 1911824: Change the copy setting for artefact annotation to 'nocopy' · cba39269
      Doris Tam authored
      Check that $evidences exist in case there exist evidenviews but no evidence blocks to copy
      
      if the only block on a view is an annotation block, then make a check to not get the sql to run copies
      which will result in error as there are no artefacts to copy.
      
      Change-Id: Ie914704046c2396a2fedce958cef3a44dd28ae33
      cba39269
  3. 01 Mar, 2021 1 commit
    • Gold's avatar
      Bug 1916833 - Annotation can be updated on a page · 690edccd
      Gold authored
      Config gear icon removed from the Annotation blocks.
      In order to still initially create these when added we needed to check
      if the Block was a new instance or not. To achieve that we are now
      passing the block instance into the has_instance_config() method.
      
      BlockInstance has been extended and will set a 'new' parameter if the ID
      in the constructor is 0.
      
      AuthPlugin* classes also have the has_instance_config(). These do not
      need the BlockInstance passed in.
      
      Change-Id: Ifac69fc1d48b45c079b6f66e610776cead3dee63
      690edccd
  4. 01 Dec, 2019 1 commit
  5. 17 Oct, 2019 1 commit
  6. 04 Oct, 2019 1 commit
    • Cecilia Vela Gurovic's avatar
      Bug 1813987: Blocks display fixes · ccc2446d
      Cecilia Vela Gurovic authored
      - assessment block: tinymce and the asseesment js
      need to be initialized after the block is loaded
      - signoff block: sing-off modal is showing now
      - embedded media init functions need to be loaded after
      the blocks are added to the grid
      - wall post block initializes the tinyMCE after it's loaded
      and refreshes the content of the block after a new post is made
      - comment block: update block size when adding a comment
      - scrolling to the block when a new one is added
      - modified the text for button to add a new block to the page
        'Drag to add a new block' for normal mode
        'Click to add a new block' for accessibility mode
      - add a block to the bottom of the page by default so it won't
      break the layout
      - add SE annotation to the bottom of the page
      - added 'Add block' button event handlers after trnaslating a view
      - annotation feedback loads the tinyMCE
      
      behatnotneeded
      
      Change-Id: I7642cacde729a2a85b497e077452de792ec72eb7
      ccc2446d
  7. 25 Sep, 2019 2 commits
    • Lisa Seeto's avatar
      Bug 1827811: Resume Icons · 953a5eab
      Lisa Seeto authored
      
      
      - get attachment comment counts for bh icons
      - display plain text for titles in editing mode
      - change the way the commentlink is targetted via js
      - add blockid's to resume attachments
      - for folder block: add comment count, change titles from
      	links to plain text when editing
      - change notes attachment file titles from links to plain
      	text when editing
      - get rid of the single artefact block title links for html exports
      ---------------------------------------------------------
      Add fixes:
      - blocks that have set types but no artefacts attached don't have modal links
      - pdf block is now using block header and comment count is loaded
      - block headers are above titles
      - tagged journals have icons when in full and matches recent posts styling
      - deleting all comments produces correct icon on block header
      - html exports should not hang on opening modal
      - get rid of warning error re: dock.show() when redirecting from &modal=1 style url
      - code review fixes for all previous patches + fix issue with folders block
      - added in viewdetailsfilter.json.php file to save details mode to user account prefs table
      - make the details btn mode "sticky" so it stays the save value over multiple pages etc...
      - Image Gallery blocks: if displaying a folder of images will get the bar block header and
      will have a the fancy box image preview displaying on image click
      
      Change-Id: I425cc5a634e176d580aacdb60a20f869f7cb7496
      Signed-off-by: default avatarLisa Seeto <lisaseeto@catalyst.net.nz>
      953a5eab
    • Lisa Seeto's avatar
      Bug 1827811: Move "Add comment" and "Details" into modal with "Comments" · be7af61f
      Lisa Seeto authored
      
      
      create modal using configureblock id, update various templates to use the modal for blocks:
      Image
      Note
      File(s) to download
      Journal/blogs
      add JS to open/close modal, add comments, delete comments, reply to comments, paginate comments.
      add JS to handle url that redirects to view/view.php with modal open and populated.
      Further changes to each block will be completed in child patches.
      Add segment headings to the modal. Fix display of comments to cover width of modal.
      Show comment removed msg in modal/page appropriately.
      Fix behat test to close modal before continuing.
      do not show existing comments if comments not allowed on artefact.
      add validation to modal for comments/attachments
      disable image as link when editing for image block
      trigger focus on modal for accessibility
      close modal on escape keydown event
      fix merge conflict in view/view.php
      fix merge conflict with master
      make configureblock modal play nicely when comment block is on the page
      update display of error messages to always show at top of modal so user doesn't have to scroll
      add accesibility to close modal on escape key down
      handle dock show/hide events for paginated pages in modal during validation
      create block-comments-details-header template file
      create details button and custom scss file with js to show and hide header
      update comment links to save add comment and details when commentcount == 0
      add active-block class to colour the block-header when active
      toggle the details-btn active css
      add _block-comments-details-header.scss to patch
      change class invisble to class d-none
      add block-comments-details-header.tpl to blocktypecontainerviewing.tpl
      code review changes
      add .no-modal class to links on group home page, dashboard and profile page.
      add block header to appear above the title
      change assessbtn from anchor tag to button to prevent scrolling.
      make all clickable links clickable on page load (ignore assess mode)
      fix js issues surrounding assessbtn move and show/hide blocks
      change cursor on dashboard, my profile page, group homepage to default when over disabled modal links
      update assessbtn to details btn
      create tooltip for hover over file download block titles
      fix containerElm console log error by not reattaching tinymce unneccessarily.
      fix null named attributes issues on e.target when span (icons) instead of anchor is clicked.
      
      Change-Id: I2e5218c040f8a9e252f785165ce9c566ecc2f56e
      Signed-off-by: default avatarLisa Seeto <lisaseeto@catalyst.net.nz>
      be7af61f
  8. 19 Mar, 2019 1 commit
  9. 26 Feb, 2019 1 commit
    • Liam's avatar
      Bug #1765276: Various changes including: · bdbb5cfd
      Liam authored
      -Changing .hidden to d-none
      -Changing button styles
      -Fixing dashboard styles
      -Misc
      
      behatnotneeded
      
      Change-Id: I320882f682ef4b33ff7a9836f4eb4438f4a93b93
      bdbb5cfd
  10. 30 Sep, 2018 2 commits
  11. 02 Mar, 2018 1 commit
  12. 04 Sep, 2017 1 commit
  13. 27 Oct, 2016 1 commit
  14. 02 Oct, 2016 1 commit
    • Robert Lyon's avatar
      Bug 1629144: Allow self copying of an annotation to duplicate artefact · a9360f18
      Robert Lyon authored
      
      
      Because unlike image/note blocks where we want the blocks to reference
      the same underlying artefact here we want to create a new artefact
      otherwise updating the block on one page will update the artefact for
      all the related blocks.
      
      To do this we need to add a new copytype called 'fullinclself' that
      means make a full copy of blockinstance including when doing a self copy
      
      Also we need to allow for the self copying to ignore the
      annotationfeedback artefact type as we dont' want to copt the feedback.
      
      behatnotneeded
      
      Change-Id: Icc9e375e3180ff3f25d84ba9695926d5b24bb17d
      Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
      a9360f18
  15. 26 Sep, 2016 1 commit
  16. 01 Sep, 2016 4 commits
  17. 15 May, 2016 1 commit
  18. 27 Apr, 2016 1 commit
  19. 24 Nov, 2015 1 commit
    • Aaron Wells's avatar
      Display icons for 3rd-party blocktypes plugins · 4f849ed2
      Aaron Wells authored
      Bug 1510421
      
      Defines a new static PluginBlocktype method, get_css_icon(), which
      fetches the name of the CSS icon to use for this blocktype. It returns
      false by default, which tells the theme to "fall back" to the old
      thumbnail.png instead. 3rd-party plugins can override this to
      specify a particular icon to use.
      
      All the core blocktypes have been refactored to extend
      MaharaCoreBlocktype, which uses the blocktype name as the name
      of the CSS icon to use. I also deprecated the "SystemBlocktype"
      class while I was at it.
      
      PluginBlocktype::get_blocktypes_for_category() now returns both
      the results of get_css_icon() and the thumbnail.png path, so that
      themes can decide which they want to use. (And of course
      thumbnail.png is served via thumbnail.php, so 3rd party themes
      can provide their own custom image files if they wish.)
      
      behatnotneeded: Requires installing third-party plugins to test
      
      Change-Id: Idb1ecfc7b21175913708e695788906c11133b0c0
      4f849ed2
  20. 07 Aug, 2015 1 commit
  21. 14 Apr, 2015 1 commit
  22. 21 Mar, 2015 1 commit
  23. 18 Mar, 2015 1 commit
  24. 13 Mar, 2015 1 commit
    • Ghada El-Zoghbi's avatar
      Annotation artefact: Bug 1397759 · 389df353
      Ghada El-Zoghbi authored
      A new artefact similar to the comment artefact but with less
      functionality (i.e. no attached files, etc).
      It's an explenation of why a particular evidence meets a
      particular standard.
      
      If an annotation is created and added to a page, when the user
      deletes it from the page, the instance is deleted along with the
      annotation and its feedback.
      
      TODO:
      
      1. Imports seem to be working.
      Can get all comments to import and display.
      Needs some serious testing.
      
      2. Made changes for broken images but another bug was reported and is
      currently being worked on. So, may not need the fixes in here. Changes in:
      - htdocs/artefact/file/download.php
      
      To completely fix the broken images for all artefacts, changes are also required
      in htdocs/lib/embeddedimage.php to delete based on resourceid instead of fileid.
      
      Change-Id: Ibdb2e1c6500862645bac741bf61cff37e5a5b35c
      389df353