And centralising the checks for collection can_have_framework() and
has_framework()

And making sure that one cant change framework if competencies exist
for the current framework

Change-Id: I5918c4e3f463388a0b03511eb9ef7adc24babcec
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

And adding the master switch to be set via the config.php file

Change-Id: I92c5a689af75b42b1774c54cc8b97f2938099740
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

After the plugin is installed

Change-Id: Id936e7a45ec4766220d34456d4c63a5b9ad1d57d
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Installs the framework plugin and add in a basic .maxtrix file

Change-Id: I059ceb523d88894b0b68e3d54dde91f7c441adcc
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

To hold the id of the smartevidence framework the collection is using

Defaults to null

behatnotneeded: to come later

Change-Id: Idb33e0d71adca8cc089f97aa48826e69e6f16fa8
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

This reverts commit 6736c637.

This reverts commit 60631719.

Because all of our emails need to pass PHPMailer's
validation method before they get sent (due to the way
PHPMailer is written) it makes the most sense to use
that for validation.

Change-Id: I232ab9496ce8fc295a49625c999b48215305216c
behatnotneeded: Covered by phpunit

Son Nguyen authored Jul 15, 2016 and Robert Lyon committed Sep 01, 2016

This will support zipped, tar and gzip files

Fix errors when extract an archive which has more than
10 entries

behatnotneeded

Change-Id: I60c53a59ad28bbc1ae9ebfcd0d638b6d09f7ecb7

Use the original code from ADODB 5.20.5

behatnotneeded

Change-Id: Id6d1d365ed2db783884172ca430488d5fcdcc1d9

Son Nguyen authored Aug 29, 2016 and Robert Lyon committed Aug 31, 2016

behatnotneeded

Change-Id: If8c5535d85e78eb53ab855bcc400477c9d795a8c

This patch does a few things:

1. Renames "webservice_enabled" config to "webservice_provider_enabled",
to indicate that this config only controls Mahara's actions as
a webservice provider, *not* a webservice client.

2. Renames all the "webservice_<protocol>_enabled" configs to
"webservice_provider_<protocol>_enabled" to indicate that they only
control whether Mahara will provide webservices via that protocol,
and not whether Mahara will use that protocol as a client.

3. Renames "webservice_connections_enabled" config to
"webservice_requester_enabled", to clarify that this config
controls whether Mahara is allowed to request webservices
from external sources.

4. Updates language strings to make these changes clearer.

5. Rearranges and renames the form methods in
webservice/admin/index.php to make the flow of control more
obvious. Now the main form method is first, followed in order
by the methods that generate its subforms and each of their
submit handlers.

behatnotneeded: Covered by existing tests

Change-Id: I58dadb352d1f1542ca67a104ebfd702b4ca90fc9

behatnotneeded

Change-Id: Iacf30fcf803f73b39dc96635b4f165d5c8da1382

behatnotneeded

Change-Id: Id89d92e2ac6735dbc9d2be126cd535eb832a2572

behatnotneeded

Change-Id: Id66dbde93b1be3c4814a69674258f65be6223b6e

Check the format of the record in the import_queue table when processing
the queue. Ensure it always defaults to a valid format that is installed
and enabled. If it is not valid, throw an error.

Clean up the call PluginImport::create_new_queue() by removing the
non-existant 'plugin' field.

Also, wrap the importer in a try/catch so the core_import_process_queue
cron process can contiue if there is an error.

And, validate that the keypair_PEM exists when checking openssl_open().

behatnotneeded

Change-Id: Icde78f862ca0e120b67393f4a5abf464695f5104

Also adding aria-required="true" to required fields

behatnotneeded - existing test are ok

Change-Id: Iaba02ea6653d28da298a0e410ab3d79773f810db
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Aaron Wells authored Aug 01, 2016 and Robert Lyon committed Aug 25, 2016

behatnotneeded: Can't test in Behat

Change-Id: I3dac42a4e5a08155e131bc45494b78a13c1417cd

And avoiding storing full path to dataroot temp dir in db for imported
entries

behatnotneeded

Change-Id: I18fb3a76accd57517e340ce98a19f7b10bd4814c
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Liam authored Aug 24, 2016 and Robert Lyon committed Aug 24, 2016

Also swapped round the 'copy page' and 'copy collection' buttons

behatnotneeded

Change-Id: Ic0c32364e51b56ffbcf7108877c6ea2820ebf45c

Bug 1525736: Also doing a general cleanup of this very old
and very messy function.

behatnotneeded: Covered by existing tests

Change-Id: I4b2feba22764fd290a69dc4b6ab1d734abd08a1c

If there are negative block_instance.order values in the database,
then we'll just drop and re-create the unique key on the column.

Change-Id: I3ef1507f82ae3dc24244e6236e173b6649a95d3b
behatnotneeded: Covered by existing tests

behatnotneeded: IOU a behat test for clamav

Change-Id: I43a65b7be7490bbcb13fa8885ca119c130856a98