Change-Id: I349d2dde48e14cc59a51729cfefe4f360a70a858
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

These were using undefined strings and gave messages like "The end
date for '[[group/view]]' access cannot be in the past".

Change-Id: If087014fc608747eee8c9533e36df1fd90856456
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

When the view access page is submitted with an error, php warnings
are emitted when the rendering the access rows.

First because the pieform element assumes that an 'accesstype' index
exists in the accesslist value, but this is only true when the
accesslist still contains database records rather than the list
submitted by the form.

Second,  disabled public access record causes a warning because
'public' isn't in the list of 'presets' allowed to be added to the
view, so we need to keep track of the allowed presets and the full
list of presets that may have been allowed in the past.

Change-Id: Ic4db20738d53a52caeb3ebef0b44660dcb7c9ee6
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

When you get an 'end date in the past' error from the view access page,
the offending record is not displayed because the form removes stale
records as it pulls them out of the database.  However, when we're just
validating a bad stop date entered by the user, we need to make sure
it's still displayed to avoid confusion over the error.

Change-Id: I22c8876a599a2f00280058f32b4757d8eb523ea0
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

When you submit the view access page and there's an error in the form
submission (due to bad start/stopdates, etc.), sometimes an item is
removed from the array of access records by unsetting the array key.
Messing with the ordering of the array keys causes a javascript error
which stops the access list from being displayed.

Change-Id: Iaa686c8adecc322a6b779ee3247b28c945031854
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

We removed info from the email subject and added it to headers. However
people generally don't see the headers, so this patch adds the info back
as pseudoheaders, while removing duplicate info such as poster name,
topic and time.

Change-Id: I1063c70693e3b6345d41225b8fed53e0c20e7d95
Signed-off-by: Melissa Draper <melissa@catalyst.net.nz>

Urls stored in the url field of notification_internal_activity contain
the site's wwwroot.  This leads to broken links when the wwwroot is
changed.  It also dangerously turns what should be local links into
remote ones when for example a production database is copied into a
test Mahara instance.

This patch does three things:
- Removes the wwwroot from urls passed to ActivityType constructors
- Adds the wwwroot back on the url when sending email and emaildigest
  notifications, and when displaying them on the site.
- Removes the wwwroot from the url in all existing rows of
  notification_internal_activity.

Change-Id: I00ae1abc65be79030ed4c572ce951edc43f7a034
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

These are mostly just missing semicolons. No code changes.

If you use emacs already: apt-get install js2-mode
If you don't use emacs: apt-get install emacs js2-mode ;-)

Change-Id: Ie81c438c673084ee9e29a950bafe628a7c3ca7d9
Signed-off-by: Francois Marier <francois@catalyst.net.nz>

Change-Id: Id45194b3fa0c27e20cccd46b0acc29aeb4c0ec48
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

When a user has many views shared with them, the view_search query
may exceed mysql's max_join_size and cause an unrecoverable error on
a user's dashboard, among other places.  Replacing a bunch of these
outer joins with subselects fixes the issue, and in a few tests on a
large postgres db, also improved performance.

Change-Id: Ic3b82518e4571807ceae4747ab086eb4a9baa5db
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

* changes:
  Add a class on each right_nav menu item
  Use string keys in right_nav menu array
  Remove unread message count from profile sideblock (bug #854403)

In IE, when dragging a blocktype image into the content area of the
view editor, the image appears to slip underneath the white box saying
"This area shows a preview of what your page will look like..." and
then out the other side again.  Setting the z-index property on the
element containing blocktype list fixes the issue.

Change-Id: I6bc28bcf790b89d7513144012e210527b8ae1710
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

When dragging a blocktype in the view editor in IE, dragging it very
slowly usually causes the block to suddenly disappear, and the cursor
to turn into a crossed circle.  If you let go of the mouse, the
blocktype image appears at the cursor, and clicking the mouse again
will drop the blocktype.  This can be fixed by disabling IE's default
startdrag function.

Change-Id: I03b3150dbdef7f59f6f638d0cc71a773df5de576
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

Forum email subjects are unwieldy so move forum name and group name to
custom headers so users can filter as well as have a more concise
subject line. Values in headers trimmed to 100 char based on information
at http://stackoverflow.com/questions/2721605/maximum-size-of-email-x-headers



Change-Id: Iad9c7c3101ff81f19f3beafbe1811f28f3d3faa5
Signed-off-by: Melissa Draper <melissa@catalyst.net.nz>

This will delete the current mnet key and regenerate a new one

Bug #890583

Change-Id: Ic07fc3f2e772fc26c959cd00a74bd88da9277a92
Signed-off-by: Hugh Davenport <hugh@catalyst.net.nz>

This has already been done for the main menu

Change-Id: I3141f2c1c43967e7ff88a5b71dce62b122182840
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

This has been already been done for the main and admin menus.

Change-Id: Iaf11a273e0e3b9c64b9a81ea2413053be389c079
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

This has been unnecessary for some time now, because the same count
appears next to the envelope in the top right of the header.

Change-Id: I14581f8edff19ee5111eba4ff4ec8f564ad2443a
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

The html filter will now parse links with underscores in them.

Bug #884438

Change-Id: I117b3162b44ecb372d42454c0d64224d01f363b7
Signed-off-by: Christopher Tombleson <christopher@catalyst.net.nz>

Updating a site menu item and swapping it from an external url to
a site file or vice versa was failing to create the correct type of
link on account of incorrect parameters. Unfortunately this can't
fix existing muddled links, as it has no way of knowing whether the
url value or the file value in the database is the one to use.

Change-Id: Ib8ac2da42125b020a1214b268c079f93166d2da8
Signed-off-by: Melissa Draper <melissa@catalyst.net.nz>

Change-Id: I4f15ed916e51debc2f7a3ce75858c39b6bc09e14
Signed-off-by: Hugh Davenport <hugh@catalyst.net.nz>

  get_notifications_for_user(): a user's notifications
  get_groups_for_user(): the groups that a user is in
  get_watchlist_for_user(): the list of the pages that are on a user's watchlist

To make use of this in Moodle, you need the matching local plugin:

  http://gitorious.org/mahara-contrib/local-mahara



Change-Id: Ie81f49cc10c256bc9013ac4c87da9031c1cd1f38
Signed-off-by: Francois Marier <francois@catalyst.net.nz>

Bug #890528

Change-Id: Ie2197d6d77e3125247f40a16809b1f6e1dc61d6d
Signed-off-by: Hugh Davenport <hugh@catalyst.net.nz>

This is based on an OWASP recommendation and corresponds to 128
bits of entropy.

https://www.owasp.org/index.php/Session_Management_Cheat_Sheet#Session_ID_Properties



Change-Id: Ie47779d586c39bc339728e4772467407fac90ee4
Signed-off-by: Francois Marier <francois@catalyst.net.nz>