1. 04 Aug, 2016 3 commits
  2. 03 Aug, 2016 2 commits
  3. 02 Aug, 2016 1 commit
  4. 01 Aug, 2016 20 commits
  5. 29 Jul, 2016 1 commit
    • Ghada El-Zoghbi's avatar
      bug#1607669: Validate the results of ldap_search() and ldap_list() when syncing users. · 1daee33a
      Ghada El-Zoghbi authored
      When retrieving data from the LDAP server, check the results retrieved from
      ldap_search() and ldap_list(). If there is an error, do not continue.
      Otherwise, the sync_users() will assume that zero users were retrieved
      from LDAP. It will then deleted or suspended users when
      'If a user is no longer present in LDAP' is set to either suspend
      users or delete them.
      Change-Id: Ib57901c61f769d96720cf932d2e0d7f643853a56
  6. 28 Jul, 2016 2 commits
  7. 27 Jul, 2016 1 commit
  8. 26 Jul, 2016 3 commits
  9. 25 Jul, 2016 5 commits
    • Ghada El-Zoghbi's avatar
      Bug 1606101: usr.suspendedcusr must be non-zero · ead553ee
      Ghada El-Zoghbi authored
      It turns out a lot of existing code checks the boolean
      value of usr.suspendedcusr to determine if a user should
      be treated as suspended or not. The LDAP sync cron (and,
      indeed, any code suspending users via a cron task) was
      setting usr.suspendedcusr to 0, which is boolean false,
      so these users would be treated as not suspended.
      We are going to update all usr.suspendedcusr = 0
      to a valid site admin ID.
      Change-Id: Iecfbfd8a4cdd98d5d07149bb40c64308262ea234
      behatnotneeded: Test to come later
    • Dmitrii Metelkin's avatar
      Bug 1605072: add a friendly error message when dropzone fails upload a folder · 34f4ceeb
      Dmitrii Metelkin authored
      Change-Id: Icaafe3e7f3ee77aaece9f891fda1db40d5a235fe
    • Dmitrii Metelkin's avatar
      Bug 1606086: upgrade dropzone.js to v.4.3.0 · 18579931
      Dmitrii Metelkin authored
      behatnotneeded: Can't test drag-drop files in Behat
      Change-Id: I7951c70ab932f17ad30e088e526ad4fbd1930176
    • Aaron Wells's avatar
      Bug 1606094: Stop sending quota notifications to everyone · 2c262cdf
      Aaron Wells authored
      This patch changes that bad left (outer) join to an inner
      join, so that we only check for notifications for users
      who are in the affected institution.
      As a further safeguard, it also removes the line that
      compared each user's file usage to the institution's
      new quota. Now, we'll instead compare each user's
      file usage to that user's current quota (which, for
      members of the institution, will be the institution's
      new quota.)
      Change-Id: I4db6068221d1238c8a755434e78e6cc006a84aa8
      behatnotneeded: Test to come later
    • Pat Kira's avatar
      Bug 1594081 - Fixed custom theme tag link colour · d341c299
      Pat Kira authored
      Change-Id: I797f07c7989d9d55b18f52933d9de4e2c67fcd79
      behatnotneeded: styling only
  10. 24 Jul, 2016 2 commits
    • Aaron Wells's avatar
      Bug 1605127: Method signature mismatch in Activity::update_url() · b469030b
      Aaron Wells authored
      The abstract Activity class defines the function update_url()
      with no parameters, but the two subclasses that override it
      define it with one parameter. This will cause problems in PHP 7.
      It's always called with one parameter, (even in the Activity
      class itself) so the best option is to add one parameter to the
      implementation in Activity.
      Change-Id: I810061ed6f8c55101327e2e907bb68ebf9870380
      behatnotneeded: Covered by existing tests
    • Robert Lyon's avatar
      Bug 1605170: $view->get_artefact_instances() not working · 739d6f90
      Robert Lyon authored
      It is meant to return artefact instances but was missing the plugin name
      behatnotneeded: Testing with phpunit instead
      Change-Id: Id12df696b932d3644e85fe6836a3d97910bf36ff
      Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>