Skip to content
GitLab
Switch branch/tag
  1. 02 Jul, 2012 1 commit
  3. 18 Jun, 2012 4 commits
  5. 08 Jun, 2012 1 commit
    • Richard Mansfield's avatar
      Use profile_url when data is easy or inexpensive to fetch · 0d28fabc
      Richard Mansfield authored 
      

Bug #1006634, part 3

In many places user urlids are not currently available when the
profile url is generated, but it is trivial to get it, and then change
the user/view.php url to a profile_url call:

- Admin page access report
- Profile links in feedback lists
- My friends block
- Wall posts
- Group members block
- Group members tab
- Recent forum posts block
- Group admin lists on forums page
- Group admin lists on my groups, find groups
- Group admin lists in group info block
- Profile sideblock
- My friends & find friends pages
- Institution landing page
- Online users page

Change-Id: I33e122896982037a887aad8e3362db450e123e3f
Signed-off-by: default avatarRichard Mansfield <richard.mansfield@catalyst.net.nz>
      0d28fabc
  7. 07 Jun, 2012 1 commit
  9. 01 Jun, 2012 2 commits
  11. 31 May, 2012 1 commit
    • Richard Mansfield's avatar
      Gather themename, logo & stylesheets together in User object · a9e7ef47
      Richard Mansfield authored 
      

The Theme constructor expects a triple (basename, logo, stylesheet),
which is passed by the User::get_themedata function.  But the three
properties are stored separately in the User object.  If they are
grouped together, then it will be easier to switch themes in and out
at a later date.

The three properties are combined under the 'institutiontheme' name,
to make it clear that they are defined by the user's institutions, and
to distinguish them from the user's own theme preference.

This requires a slight change to code for setting a view theme on view
creation, where only the basename property is allowed, because custom
themes with logos & stylesheets are not yet available as view themes.

Change-Id: Ie400a0f1c4a2172382dfaba14139f1b0b27f2120
Signed-off-by: default avatarRichard Mansfield <richard.mansfield@catalyst.net.nz>
      a9e7ef47
  13. 30 May, 2012 1 commit
  15. 24 May, 2012 1 commit
  17. 18 May, 2012 1 commit
    • Son Nguyen's avatar
      Be flexible in the number to results shown on a page Bug#781989 · f3162f80
      Son Nguyen authored 
      

1. Added a new feature to build_pagination:
 - setlimit: enable=true/disable=false choosing limit values
 from the array limitoptions
 - the array limitoptions (page sizes) has been hardcoded
inside build_pagination function.

2. Enable this feature to group member search and porfolio pages search
Note: The default number of pages in Porfolio/Pages has been changed to
20

To enable this feature
1. pass 'setlimit' => true to build_pagination function
2. $js = "addLoadEvent(function() {p = {$pagination['javascript']}});";
3. $smarty->assign('INLINEJAVASCRIPT', $js);

Change-Id: Ib44b28d50895c6ea604bb1aedaebae3a3f1bfc1a
Signed-off-by: default avatarSon Nguyen <son.nguyen@catalyst.net.nz>
      f3162f80
  19. 14 May, 2012 2 commits
  21. 09 May, 2012 1 commit
  23. 12 Apr, 2012 2 commits
    • Richard Mansfield's avatar
      Admin page to manage SafeIframe sites (bug #971282) · f3182dd6
      Richard Mansfield authored 
      

Adds a new page for Site admins to manage the list of sites for which
iframes are allowed by htmlpurifier.  Whenever an item is added,
edited, or deleted, the regex used by HTMLPurifier is updated.  Sites
are identified by favicon, and by a string entered by the Admin to be
used as the alt/title text for the favicon image.  The source of the
favicon image can be modified in config.php, but the google service is
used by default.

Change-Id: I4117de82691a002bf250ea71622eccfad4d5f8df
Signed-off-by: default avatarRichard Mansfield <richard.mansfield@catalyst.net.nz>
      f3182dd6
    • Richard Mansfield's avatar
      Move the list of safe iframe sources to the database (bug #971282) · 4b8c5170
      Richard Mansfield authored 
      

Builds the htmlpurifier safe iframe regexp from a list of sites stored
in the database, instead of a hardcoded array.

Each site in the safe iframe list is associated with a name.  This
will allow several regexp items to be grouped together under the same
name when they're matching urls from the same site.

Additionally, the domain part of each site is stored in a second list
along with the names, so that it will be easy to fetch the favicon for
display in places such as the external media block configuration form.

Change-Id: I7fd2bfefbff0881e70b94beb9e8d3efb43f0f9e7
Signed-off-by: default avatarRichard Mansfield <richard.mansfield@catalyst.net.nz>
      4b8c5170
  25. 28 Mar, 2012 1 commit
  27. 21 Feb, 2012 2 commits
  29. 13 Feb, 2012 1 commit
    • Richard Mansfield's avatar
      Get unread message count from user table (bug #854403) · 60167828
      Richard Mansfield authored 
      

Also keeps the count in the $USER object up to date whenever the
user deletes or reads a notification.

When new notifications are generated for a live user by another user,
or on cron, the logged-in user's unread count is reloaded from the
database into the session either on hitting the inbox, or whenever
$USER is committed for some other reason.

The code to reload the background fields on commit of the LiveUser
object has been changed to ensure that it still works at upgrade time,
where the 'reload' column doesn't exist in the user table yet, but
*does* exist in the User object.

Change-Id: I9c9a81bf77d0927352902dee0d989d6122757b47
Signed-off-by: default avatarRichard Mansfield <richard.mansfield@catalyst.net.nz>
      60167828
  31. 10 Feb, 2012 1 commit
  33. 07 Feb, 2012 1 commit
  35. 01 Feb, 2012 1 commit
  37. 30 Jan, 2012 2 commits
  39. 16 Jan, 2012 1 commit
  41. 05 Jan, 2012 1 commit
  43. 20 Dec, 2011 1 commit
  45. 14 Dec, 2011 1 commit
  47. 12 Dec, 2011 1 commit
  49. 01 Dec, 2011 1 commit
    • Richard Mansfield's avatar
      Allow custom templates to be added to all themes (bug #898437) · 2ab3ed09
      Richard Mansfield authored 
      

Sometimes it is useful for a site which has multiple themes in use to
be able to add a custom template (for example, a custom sideblock)
that appears in all themes, including the core themes and the raw
theme.

This patch adds local/theme/templates/ to the template search path, as
a fallback for when a template is not found in any of the theme
directories.

It is usually possible to achieve the same thing by putting the custom
template in the raw theme, but it is cleaner to keep them outside the
raw theme, and custom themes should not be required to inherit from
raw anyway.

Change-Id: I4f188ae3985741183d1c04f71c6c42e3ca4675cf
Signed-off-by: default avatarRichard Mansfield <richard.mansfield@catalyst.net.nz>
      2ab3ed09
  51. 21 Nov, 2011 1 commit
  53. 17 Nov, 2011 2 commits
  55. 07 Nov, 2011 1 commit
  57. 01 Nov, 2011 1 commit
  59. 12 Oct, 2011 1 commit
    • Hugh Davenport's avatar
      Fix issue when param_... functions have default of null · 0043cc83
      Hugh Davenport authored 
      Bug #872619

Regression from 79810c3d



Basically, a default parameter of null was given, then trim
was called, which made it into the string '' which then failed
the test is_null in the files it was used.

This reorders the functions so that the trim is called after
the test to see whether the default should be used. This means
that the default value is never trimmed, and can be null.

One exception to this, is the param_boolean which doesn't test
to see whether it is the default that is returned, so a check
is made first to see whether it is null.

Change-Id: I66d7253a8414dec7eb3ea67ebd363ea068a32012
Signed-off-by: default avatarHugh Davenport <hugh@catalyst.net.nz>
      0043cc83
  61. 07 Oct, 2011 1 commit