GitLab

Make sure the default notification type for admin notifications is 'none', by correcting what the User class thinks the default is. Fixes #2062.

No need to clean up the text of a textbox on form submission - the WYSIWYG pieform element already does this for us. Fixes #2060.

* Make the loading box for AJAX stuff not take up the entire top of the page when it is visible
* Show the radio buttons on the view editor to allow people to edit views in ie6
* Remove the border from around radio buttons that isn't necessary

* The fieldsets are not collapsible in IE7 any more. I've narrowed down the problem to an IE7 issue with running javascript that has been inserted via innerHTML. It's going to be too much work to make pieforms work around it for now, so sorry IE - you lose.
* IE doesn't seem to understand the meaning of 'float', so make a table have auto width instead of 95% so that a float doesn't affect the position of the table.

Prevent more than one tag control appearing for the 'create folder' form - basically the same fix as for 144adb0a.

Don't do it by IDs however, because on the My Files page both tag inputs have the same ID. That will only end in pain. So for now, back to .parentNode hacks.

Allow the maximum time difference between servers doing XMLRPC communication to be configured. Fixes #1963.

The setting is called xmlrpcmaxservertimedifference. I can't be arsed putting a default in config-dist.php because people shouldn't use it anyway.

When a file is selected to attach to view feedback, disable and uncheck the 'make public' checkbox. Fixes #1938.

Ensure that when an error occurs on the profile form, the fieldset it occurs in doesn't get shown below the actual tabbed interface.

This problem happens because pieforms refuses to collapse fieldsets with errors in them (rightly, so people can see their mistakes).

The fix _might_ break some stuff, like specifying which tab to show on page load.

Don't always show the 'lose your changes' prompt when clicking 'view profile' from the profile page.

It's now only shown if you actually change a field, however:

* The change logic is simple - it's an 'onchange' on the fields themselves, so do not take into account if you make a change and revert it
* It doesn't work for the WYSIWYG boxes, they don't seem to fire onchanges. Would need another way to deal with this

Prevent multipe 'show my tags' lines appearing when uploading more than one file in My Files. Fixes #2029

fixing bug in upgrade where version wasn't bumped and plugins were trying to be installed unnecessarily

The old theme used to do this, somehow it has stopped since the new theme landed.

Split MP4 files up into the audio and video versions, so that the video version is allowed to be uploaded.

Also, added a language string that is shown to users if they upload something that exceeds their quota.

This is a partial fix for bug #1976. MP4 files cannot be embedded in views just yet. See the note on that bug for the reason why.

Put all of the delete confirmation messages into message divs, so that a) they wrap and b) the buttons are centred under the messages.

This lets admins, etc. upload feedback too.

Otherwise, $db->BindTimestamp() will return the string 'null' for 0 and '0', which no code in Mahara is expecting.

Noticed as part of the previous commit, where $user->lastlogin defaulted to 0 (which was incorrect), and which db_format_timestamp was converting to 'null'.

When creating the user object, set the default lastlogin time to null, not 0. They mean two different things.

'null' means 'user never logged in'. 0 means 'user last logged in Jan 1 1970'.

We WANT to do that, but the system doesn't yet. So let's not lie.

More help wordsmithing. Add/remove columns help now makes it clearer that you can always change the number of columns on the view layout page.

Set an explicit width on the viewinfo column when showing friends. This way, it's all the same width regardless of whether the user has views or not. Fixes #1946.

Moved the smarty core files into htdocs/lib/smarty/libs. Moved the mahara custom plugins into htdocs/lib/smarty/mahara.

This is so the debian packaging can depend on the smarty package.

Look for smarty in htdocs/lib/smarty/libs, which is consistent with upstream (and therefore debian). Look for mahara plugins in a separate directory.

This is so the debian packaging can depend on the smarty package in debian rather than bundling our own.