Skip to content

GitLab

Switch branch/tag
  1. 16 Mar, 2012 1 commit
  3. 15 Jan, 2012 2 commits
    • Richard Mansfield's avatar
      Use file_mime_type when creating audio/video artefacts · efeb94fb
      Richard Mansfield authored 
      

Audio and video artefacts are created according to the mimetype
claimed by the browser: no checking is currently performed on the
file's content.  This doesn't really matter because these artefact
types are only used to display special audio/video icons in the files
area, but we may want to use them for other purposes later.  Until we
can ensure these files are valid, and that Mahara can play them, we
should at least use the slightly more accurate detection provided by
file_mime_type.

This patch also renames the new_<artefacttype> artefact type detection
functions so that they are consistent for audio, video, and archive
artefacts.  It also removes the unnecessary archive_from_file()
function in the archive class, combining it into the detection
function.

Change-Id: I6ec5ae0c18a3fae4c6cdb609097173432ca0c57f
Signed-off-by: default avatarRichard Mansfield <richard.mansfield@catalyst.net.nz>
      efeb94fb
    • Richard Mansfield's avatar
      Ensure filetype is set when creating new file artefacts (bug #914574) · c7e99a9f
      Richard Mansfield authored 
      

When a new file artefact is created from a file that wasn't uploaded
by a browser, the filetype property is not always set.  This causes
warnings when extracting files from archives.  Moving the call to
file_mime_type right before construction of the new artefact type
fixes the problem and allows us to remove some other calls to
file_mime_type during import and upload.

Change-Id: I8e644bfc1e6bc0fbaa90f1e6637288997b0d028c
Signed-off-by: default avatarRichard Mansfield <richard.mansfield@catalyst.net.nz>
      c7e99a9f
  5. 10 Jan, 2012 1 commit
  7. 12 Dec, 2011 1 commit
  9. 21 Sep, 2011 1 commit
  11. 12 Sep, 2011 1 commit
  13. 30 Aug, 2011 1 commit
  15. 22 Aug, 2011 1 commit
  17. 19 Aug, 2011 1 commit
    • Hugh Davenport's avatar
      Allow group members to view their own files · 7d9b3749
      Hugh Davenport authored 
      

If a file is in the groups area that doesn't have member access
then the group member that initially uploaded it can't view it

This patch allows the author (uploader) of a file to still have access
no matter what the access is set to for the group role they belong to

Bug #812673

Change-Id: I1d5bbccb41d34af15617ac5abc673b1265ac9f3e
Signed-off-by: default avatarHugh Davenport <hugh@catalyst.net.nz>
      7d9b3749
  19. 16 Aug, 2011 1 commit
  21. 03 Aug, 2011 1 commit
    • Richard Mansfield's avatar
      Generate new parent folder for each new view copied (bug #820180) · 3f4ee9b1
      Richard Mansfield authored 
      

Files copied during view copying were not dealt with correctly
when more than one view was being copied in a single request.
The copying process automatically creates a folder in which to
put any files it needs to copy, but the id of this folder was
declared as static, so it didn't work once copying of multiple
views is allowed.

There is a similar problem for blogs created during view copies
(to hold copied blogposts).  I'm not sure if there's a way to
copy multiple views containing blogposts that need copying (it
can't happen in institution views).  But the default blog creation
function is updated in this patch anyway.

Change-Id: Id8ea2504772f49ce8f301cfc19d41ba20b587e9d
Signed-off-by: default avatarRichard Mansfield <richard.mansfield@catalyst.net.nz>
      3f4ee9b1
  23. 02 Aug, 2011 2 commits
  25. 29 Jul, 2011 2 commits
  27. 15 Jul, 2011 1 commit
    • Eugene Venter's avatar
      Make profile pics available in files area · 4a7b4ac4
      Eugene Venter authored 
      

bug #605747 and bug #806501

When a user uploads a new profile icon, it now gets added to the
"images" folder in their files area. Profile icons are emphasised and
descriptions aren't editable. Warning notifications, when deleting a
default profile icon or when deleting a folder containing profile
icons, are implemented.
Signed-off-by: default avatarEugene Venter <eugene@catalyst.net.nz>
Change-Id: I3f8c93c4b65814aa183f0eaa8e1739e750c87905
      4a7b4ac4
  29. 14 Jul, 2011 1 commit
    • Richard Mansfield's avatar
      Remove profile icon from session on delete (see bug #805742) · e8d02087
      Richard Mansfield authored 
      Commit 0c9774b9

 added a foreign key constraint on the profile icon
field of the user table.  But when a profile icon is deleted, this
field isn't updated in the global $USER object, unless the icon is
deleted from the profile icons page, so the bad profileicon can hang
around in the session, and then cause an sql error the next time the
usr table is updated from $USER.

This change will fix that problem when a user deletes their own
profile icon, however it may still be possible for the error to occur
if for example the user is logged in twice.

Change-Id: I2f8792fcd392be351b8ee9ac77337fd41b046a3d
Signed-off-by: default avatarRichard Mansfield <richard.mansfield@catalyst.net.nz>
      e8d02087
  31. 01 Jun, 2011 2 commits
  33. 26 May, 2011 1 commit
  35. 25 May, 2011 1 commit
  37. 24 May, 2011 1 commit
  39. 16 May, 2011 1 commit
  41. 13 May, 2011 1 commit
  43. 20 Apr, 2011 2 commits
  45. 12 Apr, 2011 1 commit
  47. 27 Jan, 2011 1 commit
  49. 12 Jan, 2011 1 commit
  51. 23 Dec, 2010 2 commits
  53. 22 Dec, 2010 4 commits
  55. 21 Dec, 2010 1 commit
  57. 18 Oct, 2010 1 commit
  59. 13 Sep, 2010 2 commits