GitLab

Bug 1464052: Giving it a default of 50000 instead of unlimited.

Change-Id: I30210d3416d70d96bec40ebb578c5302e07ff63f
(cherry picked from commit 0b1d3d68)

When updating the artefact table with new 'path' option

Change-Id: I6f236f53e907cb4f686c8973c9a98502fc0186ed
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Postgres works slightly differently to mysql with the
update .. limit command

behatnotneeded: as this is an upgrde problem

Change-Id: I6ae18e545d9e3ba56ca3a258b02038b3759ea178
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Mostly for Mysql's benefit but won't hurt postgres to do it this way
as well

Change-Id: Icada6c3945db15279d93c30973eaad7bc2507b13
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

behatnotneeded

Change-Id: Id5b2a01d1ac240cdb271bfc952c41691a4bc4287
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Also, displaying the pages in name order during import.

behatnotneeded: Can't test export & re-import of Leap2a files in Behat yet.

Change-Id: Ib387e574356d9d894b9a6f284b09921a5b26d5fc
(cherry picked from commit c10418a1)

Need to have $SESSION available to be able to send error to it

behatnotneeded

Change-Id: Ie298c95a8ef9a4fdc5589a6934110fc86c1e771d
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 7b212c53)

Bug 1480038 - When the registerallowed is turned off - this is wrong

Change-Id: Ib511a1c372a15cddd9fd7329cfa93cc72dac412f
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

The group tab in admin section when dropdown navigation was off had a
split in the button when selected due to the 2nd span in markup for that
tab.

The css fix ignores the 2nd span.

Change-Id: I28fd63d929dbfc9f4d7c27bfb8c2d0b46ff00efc
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

There was a problem with group update where the group quota data was not
getting updated when uploading a file due to caching.

Change-Id: I96ee13b39d815c126f3ff1689f413eb20b0f1c76
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Change-Id: I24d34159e337d7ece6d003b1c42cda01a0fe4e80
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Bug 1333424

Change-Id: I6ab58a154513fbe3185be91f251c5c1aa213a7a1
(cherry picked from commit 3658fa88)

Bug 1464477

Change-Id: I016d35f35406f4b1c7bcb298ae2966f1d37fed05
(cherry picked from commit e7779d20)

While the IDs for the radio buttons are of the form "decision_X_X", we're
looking at their names here, not IDs. And the names are just "decision_X".

Change-Id: Id7e0ec1df62cca6cae261b9b7eda9fbe3dbf9431
Signed-off-by: Son Nguyen <son.nguyen@catalyst.net.nz>
(cherry picked from commit a61c66ed)

Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Change-Id: I3d7b926c1889412ff7f750101ae7e8c955178371
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit a766be91)

Bug 1470281

See
  https://msdn.microsoft.com/en-us/library/gg622941(v=vs.85).aspx
  https://www.owasp.org/index.php/List_of_useful_HTTP_headers

Solution is to add it to file serving code in places where we do forced
download of files.

Change-Id: Ic46d02f65d9ed1cb57fb50e8fab2cbc9f62428a1
Signed-off-by: Yuliya Bozhko <yuliya.bozhko@totaralms.com>
Signed-off-by: Aaron Wells <aaronw@catalyst.net.nz>
(cherry picked from commit 96b117e5)

If there are more than one institution to choose from as the div
container 'termscontainer' is not present on page.

Change-Id: I5a7e03ff4bd0f8a5bcd933d37bbf81ca441cbf92
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Change-Id: I445c763b09928ce03ae8561605e593bc23bba122
(cherry picked from commit 539d323f)

Bug 1463629

Change-Id: I99f4df8b5ce51a58db5f122f44717ae6d12a6d72

When anonymous comments is turned off

Change-Id: Id2ed84cb3b532da6ec8e117ef13c283bd64af302
(cherry picked from commit 3046c5c7)

To allow us to show a more detailed error message if site admin (not
belonging to the group) goes to review an objectionable group page
or group forum topic that has already been sorted out.

Change-Id: If4785528bfe29736542972adce7609cdb0522248
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit a4f1dfe8)

Change-Id: I45985d83317b675f68805bc011a9c240192ab352

The previous 1.10.4 version bump commit accidentally
set the release string to "1.10.5testing"

Change-Id: Ic20266dd36923cc79cb0e07b50dcbe968789a8a5

Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Institution names were not being escaped properly in the
accesslist.

This patch escapes them properly as well as clearing the
compiled cache for the templates where this problem occurs.

Change-Id: I2e675af0b84a3a7106e0245a5faa6ee2095a7e06
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Bug 1417120

The language location check now goes in this order:

1. /local string in selected language
2. theme/plugin directory, in selected language
3. langpack, in selected language
4. /local string in parent language (if any)
5. theme/plugin directory, in parent language
6. langpack, in parent language
7. /local string in English
8. theme/plugin directory, in English

Change-Id: I24f61e24fadbca3a62fefa3855f4f444165d750a
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 1d7a1fa4)

Change-Id: I3ba68797512dd0d30087c62b17386b8417575ceb

Change-Id: Ida23b4b8d58cad2455e0fcb32efe6cad59fa5ce5
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit e5b5ee67)

Change-Id: Iaa1ef43f30615c253df28c70d20db415779146b8
Signed-off-by: Son Nguyen <son.nguyen@catalyst.net.nz>

Bug 1450705: The normal Wysiwyg Pieform element's "onload()" can't
handle the TinyMCE in the feedback area, because of the additional
Feedback logic for hiding & showing the Feedback form.

Change-Id: Ic2c7ad8c2ce8720ba1fcaf19c3ec71b6529b4ff0

Ensures that pieform() is defined so that a "copy page" button can
be created for copyable pages

Change-Id: I2228ddfde04747a53b173a168d92286fc33af048
(cherry picked from commit b9839b52)

It was wanting to check if the user was in the correct institution to
edit the group - but was wailing if the user was in group 'mahara' or
no institution.

Change-Id: Ia77cb601774bdde6a2a176a0ed26760e4ccd8ea8
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

On previewing a collection the greyed out overlay gets added each time
you click a collection page tab - it should only be added once.

Change-Id: Iebbd4a333438d629d252366a542981fbf2cf2fd6
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

It was incorrectly rendering it with current user's data.

Also fixed a problem with facebook social profile - if one didn't add
full url it will now append facebook domain to string

Change-Id: Ia8b82b054d26afa7b3d0d074b5d9d97ab3f8c762
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>