GitLab

along with all the other settings

These happen sometimes, and cause the rather confusing "could not log you in" message, which is because that's how XmlrpcClientExceptions render themselves. I should fix that later.

The problem is on the Moodle side, but I haven't been able to duplicate it.

contents

Conflicts:

	htdocs/lib/db/upgrade.php
	htdocs/lib/version.php

this is meant to simplify both the creation of config.php (still from
config-dist.php) and the addition of new config variables that don't
have UI.  they now get added to config-defaults.php which is loaded
after config.php and database.

- put back debug code I had inadvertently removed that didn't belong to
  me
- throw an exception i think is missing (someone please review this)
- better oo & namespacing
- better validation of incoming 'data' per format
- paths to zip and zip args (relies on a patch that i am about to put on
  master)

still to do:

- cron processing is completely untested
- i would like to split out the import table based on the transport:
  import_queue.host and token should go into a import_queue_mnet table
- it's possibly worth thinking about making import a proper plugin type.
  not sure about the effect this has on the import transport
  framework...  it might be possible to have both import and
  import transport plugintypes but that might be too heavy
- at the very least if we split out import_queue.host and token into an
  mnet table it will pave the way for a better refactor laterz.
- i would still really like to improve the mnet namespacing but that
  might be plausible at this point.
- need to write docs about arguments and return types
- i want to change the content_ready arguments to not include
  $filesmanifest as that is dependent on format being file - it may
  be actually better to dispatch somewhere else based on $format and
  then just have a generic $data which would be $filesmanifest for files
  and then something else for something like LEAP or maharanative or
  whatever, as this is checked in the importer, not not the
  importertransport.

Improve the robustness of authinstance-in-session handling, to handle an unduplicatable bug (at least by me).

All users who log in to the system should have a valid authinstance in their session. Apparently however, some don't. I can't narrow down how this happens, but this patch will make sure things don't blow up in this case.