Commits · 582e9a3e23e50ab76c8f3d6c550344f9eda5a3e4 · mahara / mahara

18 Feb, 2019 1 commit

Bug 1816311: Showing correct journal entry poster's name · 582e9a3e

Robert Lyon authored Feb 18, 2019 and

Cecilia Vela Gurovic committed Feb 19, 2019



When adding comment to the entry and the journal is owned by
group/institution

behatnotneeded

Change-Id: Id492c04e3facdbf00a5dfdc4d714c3c5103ff3a2
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 5988b7de)

582e9a3e

11 Feb, 2019 1 commit

Bug 1814078: Including the PHPMailer SMTP file as well · 98a64156

Robert Lyon authored Feb 05, 2019 and

Cecilia Vela Gurovic committed Feb 11, 2019



This is needed if the user has configured the SMTP settings in
Administration -> Configure site -> Email settings

behatnotneeded

Change-Id: I8931b7acb879ae8eec34d253c95825b51af0ab49
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit a3ae7446)

98a64156

07 Feb, 2019 1 commit

Bug 1811284: Allow mathslate to work in https sites · 71125b0d

Robert Lyon authored Jan 30, 2019 and

Cecilia Vela Gurovic committed Feb 07, 2019



Currently the template file for this has hardcoded http urls
We need to use a different template if the mahara site is https://

behatnotneeded

Change-Id: I6fbdf769efcbbafdf68af8b075573ba14ea16f43
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit b8b97d1e)

71125b0d

30 Jan, 2019 2 commits

Bug 1812939: remove jquery-ui-timepicker lib · 81d3e03d
Cecilia Vela Gurovic authored Jan 23, 2019 and Robert Lyon committed Jan 31, 2019
```
behatnotneeded

Change-Id: Ieb19aae05762677e2ce8b27e564d658b0d9f1c24
```
81d3e03d

Bug 1813200: Wallpost activity passing in confusing 'id' value · fd409baa

Robert Lyon authored Jan 24, 2019 and

Cecilia Vela Gurovic committed Jan 30, 2019



When we allowed the wallpost to have embedded images we accidentally
adjusted what was being sent in the wall post activiy object by
including the 'id' value when we didn't need to and this caused
unexpected consequences.

behatnotneeded

Change-Id: Ic1b19320cb1cf0c90131dca9bfe262a95fffdd2f
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

fd409baa

29 Jan, 2019 2 commits

Bug 1765264: Group id not needed to be array for group_get_admin_ids() · f7676dbd

Robert Lyon authored Apr 19, 2018



A mistake made in the patch for Bug 1367539

behatnotneeded

Change-Id: If0b27c356887483532693153f0b8936b7d12eb14
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 9eefc1c8)

f7676dbd

Bug 1811141: upgrade cookie consent library to v3.1.0 · 3b1c83e1

Robert Lyon authored Jan 10, 2019



behatnotneeded

Change-Id: Id5553a18d47d3b2d94e2b0ba7c06d5ea9715ebe0
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 9a827627)

3b1c83e1

27 Jan, 2019 1 commit

Bug 1812910: Importer needs to use is_array() before count() in PHP 7.2 · 6689eadf

Robert Lyon authored Jan 23, 2019 and

Cecilia Vela Gurovic committed Jan 28, 2019



When we are wanting to check if there is an array to foreach loop over
and that array has at least one entry.

Currently we try to loop over entries by checking with just count() and we get error
- count(): Parameter must be an array or an object that implements Countable

behatnotneeded

Change-Id: I9accca2e97f415d5f9a2203b6fd984a41e95a4d0
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 9b3e36e2)

6689eadf

24 Jan, 2019 2 commits

Bug 1809494: Change Page submitted to portfolio submitted · 31c55503

Lisa Seeto authored Jan 24, 2019 and

Cecilia Vela Gurovic committed Jan 24, 2019



When submitting a collection to an external site e.g. Moodle
When viewing Mahara as a site admin

behatnotneeded

Change-Id: I9bcdbedb235c838e87e208b17eee6a71bf1674d8
Signed-off-by: Lisa Seeto <lisaseeto@catalyst.net.nz>
(cherry picked from commit 30fdf368)

31c55503

Bug 1811163: Upgrade phpmailer to 6.0.6 · d6b12bd8
Cecilia Vela Gurovic authored Jan 11, 2019 and Robert Lyon committed Jan 24, 2019
```
behatnotneeded

Change-Id: I459263cc0468639fd41b669efb750d6ac618cb5a
(cherry picked from commit 8400b75d)
```
d6b12bd8

22 Jan, 2019 1 commit

Bug 1811034: Upgrade ADODB to 5.20.14 · f7b3c5d8

Robert Lyon authored Jan 10, 2019 and

Cecilia Vela Gurovic committed Jan 22, 2019



behatnotneeded

Change-Id: I17a2c50f0d6be15a4d00a1917895c3908a60b02c
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 20f76ffc)

f7b3c5d8

14 Jan, 2019 1 commit

Bug 1811282: upgrade simplesaml to 1.16.3 · 9d93d57f

Robert Lyon authored Jan 15, 2019



Forgot to bump the version number for install

behatnotneeded

Change-Id: Ia767da37abc26991ab2dba51f23d9520564b35a8
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 15e6726a)

9d93d57f

11 Jan, 2019 1 commit
- Bug 1811282: upgrade simplesaml to 1.16.3 · 19fd0bc1
  Cecilia Vela Gurovic authored Jan 11, 2019 and Robert Lyon committed Jan 11, 2019
```
behatnotneeded

Change-Id: I9925a6a5265cc768140c41015c63feed163e88ce
(cherry picked from commit 0080525a)
```
  19fd0bc1
28 Nov, 2018 1 commit

Bug 1805517: Allow special profile/dashboard blocks in edit for templates · 125c21b7

Robert Lyon authored Nov 28, 2018 and

Cecilia Vela Gurovic committed Nov 29, 2018



Currently when setting up a dashboard/profile template we can't
add/re-add certain blocks if they have been deleted

behatnotneeded

Change-Id: I2bd95b1fb67357994b2ff43356387b18b0644d97
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 6c0d6a84)
(cherry picked from commit 2bddf9ba)

125c21b7

22 Nov, 2018 1 commit

Bug 1804328: Clean 'modal' and 'modal-..' classes from comments · ca51e4f7

Cecilia Vela Gurovic authored Nov 21, 2018

behatnotneeded

Change-Id: I5b59c45ef7b84b947615ed4ccd8a0651aa935fdb
(cherry picked from commit c7dc45bc)
(cherry picked from commit 65a23474)

ca51e4f7

15 Nov, 2018 1 commit

Bug 1803194: Need to include the user object · 309d31fb

Robert Lyon authored Nov 14, 2018 and

Cecilia Vela Gurovic committed Nov 16, 2018



behatnotneeded

Change-Id: Ia7cd266ab5552e14a14f0ec3412448a249a06af9
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit b77049b2)
(cherry picked from commit d6d5591b)

309d31fb

12 Nov, 2018 1 commit

Bug 1794990: prevent echo call from removing escape character · 1613c886

Cecilia Vela Gurovic authored Nov 09, 2018 and

Robert Lyon committed Nov 13, 2018

temporary patch to prevent the escape characters
from being removed in a lang string

this htmloutput.php will be fixed in this other bug: 1802406

behatnotneeded

Change-Id: I2d127c67027763f96da4d3bc6a727facdb8fb8a5
(cherry picked from commit cea4ffe0)

1613c886

09 Nov, 2018 1 commit

Bug #1802046: Clean up old lti settings from oauth_server_config · 0199aaf6

Ghada El-Zoghbi authored Nov 07, 2018 and

Robert Lyon committed Nov 09, 2018

During an upgrade, the clean up should also remove records from
the oauth_server_config table.

behatnotneeded

Change-Id: Ia0ae61ddb7cf7b05241466ec0d6900d2025d662b
(cherry picked from commit 6b06c240)

0199aaf6

06 Nov, 2018 2 commits

Bug 1801993: Remove old Mochikit function call · bc4c1e9f

Robert Lyon authored Nov 07, 2018 and

Cecilia Vela Gurovic committed Nov 07, 2018



And replace it with equivalent jQuery call

To test:
1) Set in cofig.php file:
  $cfg->blockeditormaxwidth = true;
2) Add a text block to a page

behatnotneeded

Change-Id: I26855778c53ac36591b6188c477f25648dab9057
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 07d6e505)
(cherry picked from commit e3fa699b)

bc4c1e9f

Bug 1801843: Need to pass thru the $cleanurlbase string · 302a5b23

Robert Lyon authored Nov 07, 2018



So that it appears above the field for the 'Page URL' field on page
settings screen

behatnotneeded

Change-Id: Iace84c2ffe9cb6a9635d577cfe9e32e4e3f9ecbe
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

302a5b23

31 Oct, 2018 1 commit
- Bug 1800315: cookie consent "Learn more" to redirect to legal.php · 6a11cccd
  Cecilia Vela Gurovic authored Nov 01, 2018
```
behatnotneeded

Change-Id: I0c556a00bfec585dfc6a561ff7f66d9fd7fc7410
```
  6a11cccd
25 Oct, 2018 2 commits
- Version bump for 18.04.4testing · 7d33835d
  Robert Lyon authored Oct 25, 2018
```
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
```
  7d33835d
- Version bump for 18.04.3 · 8d4b0da2
  Robert Lyon authored Oct 25, 2018
```
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
```
  8d4b0da2
24 Oct, 2018 1 commit

Bug 1794724: Make input capture default to implementation-specific state · 97db7ef8

Cecilia Vela Gurovic authored Oct 11, 2018 and

Robert Lyon committed Oct 25, 2018

The specification for this attribute has been
changing and is not using the 'camera' value anymore

1. Have the same response in both the image button
in the tinymce editor (text block) and the image block
when selecting the image to upload.
2. Dont assign a value to capture attribute since
'The missing value default is the implementation-specific state'

behatnotneeded
Change-Id: Ib0a6203d6cee1b05968558c2142b7f6d10ffaae1
(cherry picked from commit 49798838)

97db7ef8

22 Oct, 2018 1 commit

Bug 1797812: show latest privacy statement in logged out privacy page · 74c9e493

Cecilia Vela Gurovic authored Oct 15, 2018

behatnotneeded

Change-Id: I163cb13a77e03fdbdf21c27bace787e104383a2f
(cherry picked from commit 3ccc3e54)
(cherry picked from commit 69a964a5)

74c9e493

18 Oct, 2018 1 commit

Bug 1798209: ignore not portfolio pages when importing Leap2A · c3425b51

Cecilia Vela Gurovic authored Oct 17, 2018 and

Robert Lyon committed Oct 18, 2018

dashboard and profile views are ignored when
importing Leap2A file for an existing user account

behatnotneeded

Change-Id: I47868196714ada1adf45b6aa1d44ac1a473eff57
(cherry picked from commit 92d0b92e)
(cherry picked from commit ace60275)

c3425b51

16 Oct, 2018 1 commit

Bug 1797278: getting blocktype title through class · 35639889

Cecilia Vela Gurovic authored Oct 11, 2018 and

Robert Lyon committed Oct 17, 2018

at the moment we are assuming the string to get
the title of a blocktype is 'title'
but this doesnt have to be the case,
like in the blocktype myviews

behatnotneeded

Change-Id: Ifeaac2731df6f495f00f3e12a806327e65ff63a9
(cherry picked from commit 2b8287dc)
(cherry picked from commit c38a17ef)

35639889

27 Sep, 2018 1 commit

Bug 1794370: Use correct owner for watchlist message · c4d2b5fe

Robert Lyon authored Sep 26, 2018 and

Cecilia Vela Gurovic committed Sep 28, 2018



When sending watchlist notification for block changes in a view

behatnotneeded

Change-Id: Ieeb89c6662acabd8438486702e10433ea6feab70
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 0866ac93)

c4d2b5fe

26 Sep, 2018 1 commit

Bug 1792638: Problem with ldap sync temp table · f2da0c00

Robert Lyon authored Sep 15, 2018



And also with calling $USER->logout();

And also with showing missing ldap server info for a user

behatnotneeded

Change-Id: I03656d286bbf2e56416151a52b2051235f9364df
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 254103d6)

f2da0c00

14 Sep, 2018 1 commit
- Bug 1788300: copy group collections from group homepage · d4c1d00c
  Cecilia Vela Gurovic authored Sep 07, 2018 and Robert Lyon committed Sep 14, 2018
```
Also stop showing the copy page button on the collection rows

behatnotneeded
Change-Id: I2cfb78609b37fc56fdbf1f12be2f29c08e63a411
```
  d4c1d00c
30 Aug, 2018 1 commit

Bug 1774554: Throw WebserviceInvalidParameterException error · f9fe1bd2

Robert Lyon authored Jun 01, 2018 and

Cecilia Vela Gurovic committed Aug 30, 2018



Instead of the MaharaException when doing user delete via webservices

behatnotneeded

Change-Id: I71db2ab3a3552918992a66310cdc3244f8d7c3a1
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 7c8f5f5b)

f9fe1bd2

29 Aug, 2018 1 commit
- Bug1776814: Ensure search field doesn't close on mobile when field is focused · 1dc696cb
  Sarah Kirby authored Jul 16, 2018 and Cecilia Vela Gurovic committed Aug 30, 2018
```
behatnotneeded

Change-Id: I5353e13e4e41bfcf742cb013e5640288e6f03bda
(cherry picked from commit 71f16160)
```
  1dc696cb
20 Aug, 2018 1 commit

Bug 1786867: Updating PHPUnit testing system · 28b0d2fe

Robert Lyon authored Aug 14, 2018



To allow for using newer PHPUnit version that uses Namespaced clases

behatnotneeded

Change-Id: I9e33c2542dda76691b32df78335ce511b06174c7
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

28b0d2fe

13 Aug, 2018 1 commit

Bug 1785928: Upgrade min upgrade version values · 919b670c

Robert Lyon authored Aug 14, 2018



behatnotneeded

Change-Id: I8df12c5b2ec35a9c92231de8bfa90f1909af6afc
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

919b670c

12 Jul, 2018 1 commit
- Bug 1779959: removing modernizr lib not used anymore · 79e3d736
  Cecilia Vela Gurovic authored Jul 09, 2018
```
behatnotneeded

Change-Id: I1f54b6d7649c1ff60661ba65cf0e1ac0d7c26af3
(cherry picked from commit a4c63b44)
```
  79e3d736
27 Jun, 2018 1 commit

Bug 1777741 - Allow artefact chooser to also search by tag · 2d643dec

Robert Lyon authored Jun 20, 2018



So that we now can search by title/description/tag for valid artefacts

behatnotneeded

Change-Id: I9c514f98998b0a97326a8ba7c1de4566453a38aa
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

2d643dec

19 Jun, 2018 2 commits

Bug 1774524: Add behat step for scrolling element top to center of viewport · 5fe0a979

Robert Lyon authored Jun 01, 2018



This allows to get an element out of been hidden by a topbar menu

Change-Id: Ib6b8f704919ac141e7170e10ad25e247e645b16d
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit b22a6c43)

5fe0a979

Bug 1776364: Add generateifpossible flag to get_local_path · ebc59442

Kenneth Hendricks authored Jun 12, 2018 and

Robert Lyon committed Jun 19, 2018

This flag will set whether the function should
attempt to create the file if it doesn't exist.

E.g. image resizes.

This allows an external file system to call
get_local_path with this flag set to false to
skip the processing. This allows an external
file system to avoid an infinate loop when calling
get_local_path to check local file availibility.

Sponsored by Central Queensland University

behatnotneeded

Change-Id: Iaade0b06fcc2cd1755467231e0bafea6b90a99ec
(cherry picked from commit 63d04fd1)

ebc59442

11 Jun, 2018 2 commits
- Version bump for 18.04.3testing · 9a8f872e
  Cecilia Vela Gurovic authored Jun 11, 2018
```
Signed-off-by: Cecilia Vela Gurovic <ceciliavg@catalyst.net.nz>
```
  9a8f872e
- Version bump for 18.04.2 · 64d5d5a2
  Cecilia Vela Gurovic authored Jun 11, 2018
```
Signed-off-by: Cecilia Vela Gurovic <ceciliavg@catalyst.net.nz>
```
  64d5d5a2