GitLab

Ensure that two different composites of the same type can be displayed in the same view, by suffixing their variables/IDs with something random

Conflicts:

	htdocs/lib/upgrade.php

Make blocks with more than one artefact in them (as what happens with listself) be expanded to have all of them displayed individually. This fixes the last major problem with migrating view templates.

 * Up the memory limit to 64M. The 16M limit was hit when migrating a 600 view Mahara, so I don't imagine 64M will be hit in the wild
 * Move the installation of the blockinstancecommit event to before the view migration. This is so that such events can be fired safely by blockinstances that are being committed
 * Install _all_ of the blocktypes when upgrading

Only make sure about resume artefacts being in the block instance if the instance is _actually_ an entireresume blocktype.

Displays a folder and its contents. Sadly, the artefact chooser doesn't make it very easy to sort the results in a 'folder and its children' type way. Also sadly, files added to folders will not be available in the view for up to a minute, until the artefact parent cache is rebuilt. This problem is fixable later in the same way that it was for the resume field stuff, but the work isn't worth it right now.

Also gave them the icon that they should have.

One suggestion for improvement is to have several layout templates and allow the user to pick one.

For now, it makes sure that all resume fields a user has are displayed in the block at all times (excluding goals and skills)

Ensure that, when committed, resume fields tell any 'entireresume' blocktypes in views the user owns that they have been created.

This ensures that when a user adds a resume field, it's instantly visible in their entireresume blocks.

Install the 'blockinstancecommit' event. Make sure that events from blocktypes are installed correctly.

Only check blocktype stuff if it is installed. This prevents the admin section from crashing out when you upgrade to 0.9

Namely, when a block doesn't migrate properly.

Also reduced the size of resized images in views somewhat to work better on smaller screens.

Remove the title on filedownload blocks with more than one file in them. Correctly set the profile icon for profileinfo blocks. The general template now mostly migrates.

Make sure that when images are placed in views in 'listself' mode, they get put in filedownload blocks, which is more consistent for the upgrade. This makes the 'filelist' template migrate nicely.

The template itself is reasonably simple, the problems lie around the translation of certain template blocks to blocktypes - but these problems affect all templates.

It gets converted to a five column view (regardless of how many columns are actually used). The images are shown without their titles. All in all, this one migrates quite nicely, with the exception of images that are tall - the grid like effect is somewhat lost.

Anyway, it now migrates reasonably well. The labels are only output if there's artefacts associated with them.

Move installing view column widths into its own function, so it can be called by the 0.8 - 0.9 migration.

handle_exception isn't really an API method for exception classes, so make it final in MaharaException.

The only other class using it was SQLException, this has been changed to rollback any existing transaction in the constructor.

This means that we can safely call db_begin() and db_commit() anywhere, and as long as the calls balance, the transaction will only be committed when the last one is committed.

If a rollback is asked for at any time, the entire transaction is rolled back.

Make sure that transactions use db_begin() and db_commit(), so that transaction level counting can apply.

This was a very annoying bug to find, it manifested itself as transactions that appeared to commit at some random point despite me not having asked for this. I'd blame DDL but it's not its fault that we made db_begin() and friends.

Also changed a couple of columns in view_artefact to be nullable while the migration is running. Tried this with XMLDB, it ate my face.

Penny started this work but I'm taking up the rest of it, so there's some changes to how certain things work that I made while trying to understand the way the migration works.

Also commented everything.

Next work - test the PPAE migration, then on to the other templates.

Check for identicality when setting values, that way '' and 0 are not treated the same and thus not changed properly.

Given that that transaction level counting is now implemented, there's no reason to do it ourselves when committing artefacts.

Make sure the attachment list table stays below any content in the blogpost, regardless of how that content is floated.