GitLab

behatnotneeded

Change-Id: I536f7d4ab8bd96d653e0ae3bba635437f0d2c17c

Bug 1526076: I believe the initial intent was that
Mahara core, and/or each plugin, could add a value
to its version.php file indicating "disablelogin"
true or false. And in this way, an upgrade could
indicate whether it was a small enough upgrade that
users did not need to log out for it.

However, in practice this is not practical because
we don't know what version of Mahara the user is
upgrading from, and that is what determines whether
or not it's a "stable" upgrade.

Additionally, the core disablelogin has been set to true
for the past 7 years, and the plugin disablelogin
setting no longer has any effect.

Removing disablelogin should hopefully make our
maze of init.php auth_setup() login stuff a little
bit easier to follow.

behatnotneeded: Covered by existing tests

Change-Id: I5f8a2b4faa95b9225bb926de6a54a622ea1a9618

Change-Id: Ib3aab13c03cb7486072384da518b27ec0f4a2f0a

Bug 1526101: This should help make it clearer what's going
on in init.php and the related auth code, by making the
distinction between $CFG->siteclosed and $CFG->siteclosedbyadmin
clearer.

behatnotneeded: Covered by existing tests

Change-Id: I8bc728622ae965ce25b55ee4b55278771fc1eedc

behatnotneeded, this commit adds a file which is not accessible to behat

Change-Id: I3af54df7ed8e30de78faee0540e48bbaa44a3013
Signed-off-by: Aaron Wells <aaronw@catalyst.net.nz>

Phpunit tests cannot run if Mahara is not installed but doesn't give
any warning to this fact

Change-Id: Ie8aecf35fef730adbb42856da13ff712ed8505d5
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

The wrong named variable is being looked for.

This was an oversite from when we moved the plugin from artefact to
module.

behatnotneeded

Change-Id: I8da4a53162d077eac9b6f71149b9cd7a204e8c1d
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

behatnotneeded: Not a change to Mahara's front end

Change-Id: I379b2192c3518690ee1d39c0997b599d9dc91f7a

Bug 1523499: Old wiki.mahara.org links without the "/wiki",
and HTTP links that should be HTTPS.

Also updated the installer release notes link to point to
the base "Release_Notes" page in the wiki, because we no
longer maintain separate wiki pages for each release.

behatnotneeded: Covered by existing tests

Change-Id: I02e80eb4d8df5adddee88e77156e8e103ca24c51

If we have special chars like " or > in a feedback message they get
saved to db as htmlspecialchars like " or $gt;

When we go to display them we turn the & part into a specialchar again
leading to bad display.

Change-Id: Ie66dd599029f0939938f0d1d829c4156b5db6d56
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

From commit 030bd88a

for some reason the bot passed it even though it had syntax mistakes
in it, strange

Change-Id: I424e4a9d1067004c3f51de295824f4b9e1d298f2
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Includes fixing up how we access select2 both via ajax and for
existing list.

Have added a simple behat test for sending a message as that uses the
select2 in an ajax way

Change-Id: I3aa6722169c61e4fc2ad196a02fa5bb696761210
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Just like for the initial forum created when group is made

Change-Id: Iea18c76931d4edad2f9c0ea7fa096fd4823a960d
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

When we are trying to fetch a page by urlid and there are duplicates
as the pages will not be the same

behatnotneeded

Change-Id: I82068aefc99e051a4ecd3aceb5655fc96631b0f5
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Bug 1521058

behatnotneeded: Covered by existing tests

Change-Id: I7f4d2a290375074551f72ce2db731b80cab5c278

We need to have the z-index of the select2 search container
to be lower than the navigation menu z-index

behatnotneeded: design issue

Change-Id: I8daa8a67e0c7fa011728a23f3c25e68fd4a3b7f9
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

And Bug 1516429: making the warning message use the alert and
alert-info classes

behatnotneeded - style change

Change-Id: Ifb3361e788defe053c1649c929d6a5963074f695
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Stopping 'The theme "" is missing' message

behatnotneeded - only an info alert when not in production mode

Change-Id: Iacff81b2fd3d6ed264ca608ab00d3dcbf325231b
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Bug 1520067

behatnotneeded

Change-Id: Ib5943225f48fbacc96986397eb34b94c9db4047b