GitLab

changing the 'change view layout' link on view/blocks.php to 'change my view layout', and removing the confusing image

fixing bug where users are unable to give logged in users, friends, public or groups access to views
problem caused by me changing what I thought were just language strings, which messed everything up

adding confirm dialog to cancel with new view, and cancelling now deletes the partially created view

Signed-off-by: Andrew McMillan

Changed the title strings for editing a view and its access. Also added a string describing the view access screen.

Hopefully soon this will replace formattedtitle because this string allows us to link the view name to the view and the user name to their profile page.

Namely: the string saying how many results there are, and the string that says there are no artefacts to choose from.

Now the items are layed out in a grid to the right of the searcher, which saves some vertical space and has more fluidity to the layout.

Also, the calendar elements have from/to text, which is a small violation of the language text freeze but makes the purpose of the calendar items for each element much clearer.

I'd like to add more text to this page as an explanation, though that would be a larger violation.

Add a hover title to all clickable titles in a view telling the user that they can click for more information and to place feedback.

A couple of language string changes due to the graphic design work. Added a couple of new ones to, mostly to deal with informational error cases

view/view.php reworked - all the blocktype and view class changes done in order to support non editable views

Added a language string for confirming deleting a blockinstance. Also changed other language strings to refer to them as 'blocks', users probably would get confused by the 'instance' part.

sends data back to database, reads data from database.

Getting the reordering done with the unique constraint on view/column/order
was .. interesting ...

Next: ajax version

- beginnings of sourcing view block data from the database and some work on the BlockInstance class.

The javascript calendar integration appears to have some bugs, some in the calendar and some in the hook-in javascript I wrote. I did manage to get the date inserting when you clicked 'today', but other problems with the behaviour (like not being able to select certain dates from the calendar under certain conditions) have led me to remove the javascript handling of valid dates and implement it server-side (as it should have already been anyway).

Maybe later, someone can come back and do the javascript properly.