1. 17 Oct, 2016 1 commit
  2. 07 Oct, 2016 1 commit
    • Aaron Wells's avatar
      Bug 1620879: Remove extraneous "/webservice" from end of plugin components · 98ca273e
      Aaron Wells authored
      Currently, a plugin has to list its component as e.g.
      "module/mobileapi/webservice". This could just be "module/mobileapi".
      
      Since we're using the component string as part of the automated token
      request system, it's better to change this now to something more sensible.
      
      behatnotneeded: Tests to come later
      
      Change-Id: Ia7663065b79598d92c3bf8450c5539efb6aa3e2d
      98ca273e
  3. 27 Sep, 2016 1 commit
    • Aaron Wells's avatar
      Documenting that call_static_method() is deprecated · dc852194
      Aaron Wells authored
      PHP 5.0 to 5.2 apparently did not support dynamic access
      of static members, e.g. $classname::$method(). But support
      for this was added in PHP 5.3. So there's no longer any
      reason to use call_static_method().
      
      Change-Id: Ib2c48251fb3e5a8ca4af9994bd2d648bc40794d2
      behatneeded: Comment update only
      dc852194
  4. 26 Sep, 2016 2 commits
    • Aaron Wells's avatar
      Bug 1533377: Browserid end-of-life migration script · cfef0ff9
      Aaron Wells authored
      This patch removes all authentication functionality
      from the browserid auth plugin. It adds a script,
      accessible through the plugin's configuration page,
      to migrate user accounts from browserid to
      internal auth.
      
      Also includes changes to allow users to be searched
      by authtype, and to prevent non-useable plugins
      from being enabled on the plugin config page.
      
      Change-Id: I4e8bd9fc4d2fb2ccaa1845fda533c9373ec251bd
      behatnotneeded: Can't test with behat
      cfef0ff9
    • Aaron Wells's avatar
      Bug 1620879: Improve JSON error messages when JSON flag is on · d382d069
      Aaron Wells authored
      JSON-encodes more information about the error or exception,
      and adds an optional error number.
      
      behatnotneeded: Can't test in Behat
      
      Change-Id: I258e7a275d78c91a5f8cd638ab7f6a7590125a6d
      d382d069
  5. 19 Sep, 2016 1 commit
  6. 01 Sep, 2016 3 commits
  7. 31 Aug, 2016 1 commit
    • Aaron Wells's avatar
      Bug 1615280: More robust email validation · 1192c05d
      Aaron Wells authored
      Because all of our emails need to pass PHPMailer's
      validation method before they get sent (due to the way
      PHPMailer is written) it makes the most sense to use
      that for validation.
      
      Change-Id: I232ab9496ce8fc295a49625c999b48215305216c
      behatnotneeded: Covered by phpunit
      1192c05d
  8. 30 Aug, 2016 1 commit
    • Aaron Wells's avatar
      Bug 1600099: Cleanup of the webservice admin page · ce1a97ac
      Aaron Wells authored
      This patch does a few things:
      
      1. Renames "webservice_enabled" config to "webservice_provider_enabled",
      to indicate that this config only controls Mahara's actions as
      a webservice provider, *not* a webservice client.
      
      2. Renames all the "webservice_<protocol>_enabled" configs to
      "webservice_provider_<protocol>_enabled" to indicate that they only
      control whether Mahara will provide webservices via that protocol,
      and not whether Mahara will use that protocol as a client.
      
      3. Renames "webservice_connections_enabled" config to
      "webservice_requester_enabled", to clarify that this config
      controls whether Mahara is allowed to request webservices
      from external sources.
      
      4. Updates language strings to make these changes clearer.
      
      5. Rearranges and renames the form methods in
      webservice/admin/index.php to make the flow of control more
      obvious. Now the main form method is first, followed in order
      by the methods that generate its subforms and each of their
      submit handlers.
      
      behatnotneeded: Covered by existing tests
      
      Change-Id: I58dadb352d1f1542ca67a104ebfd702b4ca90fc9
      ce1a97ac
  9. 24 Aug, 2016 1 commit
  10. 23 Aug, 2016 1 commit
  11. 19 Aug, 2016 1 commit
    • Aaron Wells's avatar
      CLI upgrader, better handling of out-of-sequence plugin upgrades · 0e1704c1
      Aaron Wells authored
      Bug 1614805. When a plugin is installed "out of sequence" by a
      call to plugin_upgrade in the core lib/db/upgrade.php file, the
      AJAX-based web upgrader handles it gracefully, because it does
      check_upgrade() before upgrading each plugin, detects the change
      in status, and doesn't run the upgrade for that plugin a second
      time.
      
      The CLI upgrader, on the other hand, uses the same cached data
      from check_upgrades() all the way through, causing it to re-run
      upgrades for such plugins.
      
      This patch makes it behave the same as the AJAX plugin, running
      check_upgrade() again immediately before each component gets
      upgraded. This does cause some redundancy in code execution,
      but it shouldn't be enough to cause a noticeable performance hit.
      
      Change-Id: Id5c431fc9e636df2cab05d22e6cc424271ce9f3d
      behatnotneeded: Covered by existing tests
      0e1704c1
  12. 04 Aug, 2016 1 commit
  13. 13 Jul, 2016 1 commit
    • Aaron Wells's avatar
      Get rid of redundant DB writes in set_config() · a79dd6bb
      Aaron Wells authored
      Bug 1526073. Also in set_config_plugin() and
      set_config_plugin_instance().
      
      set_config_institution() is more complicated, and outside
      the scope of this bug.
      
      Change-Id: Ibaeb93fea83c190e6ffab7cd000eddf98f3afbb7
      behatnotneeded: Covered by existing tests
      a79dd6bb
  14. 11 Jul, 2016 1 commit
  15. 08 Jul, 2016 4 commits
    • Robert Lyon's avatar
      Bug 1393536: More tidying up · 2c79d608
      Robert Lyon authored
      Including:
      - making add connection form cancel back to connections page
      with correct institution selected
      - Adding a help icon/page (needs content) for add connections
      - Display tick/cross next to connection name to see if it is enabled
      - Have the 'enable connection manager' master switch bunched with the
      others
      - Changing some strings to make thing clearer
      
      behatnotneeded
      
      Change-Id: I875ad6ec745cd136338017e27ef49542157cac7c
      Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
      2c79d608
    • Robert Lyon's avatar
      Bug 1393536: Tidying up of the code · fdcac7ba
      Robert Lyon authored
      To keep it consistent with rest of Mahara
      
      1) Moving the template files to the plugin/auth dir
      2) Removing the old style submenu lines
      3) Removing the bad window.open() calls
      4) Fixing up menu placement / order
      5) Fixing the add connection form's errors so they appear against
      correct fields
      
      behatnotneeded
      
      Change-Id: Ic73526a2db2c6f8d7009b374a8ecc0977ba57330
      Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
      fdcac7ba
    • Piers Harding's avatar
      Bug 1393536: remove debug and parameterise remote oauth user · 442dc945
      Piers Harding authored
      behatnotneeded
      
      Change-Id: Ica193fac3c4ee0d000c503f61205b226da344466
      442dc945
    • Piers Harding's avatar
      Bug 1393536: client connection manager · aa743c03
      Piers Harding authored
      * added new client connection manager screens
      * added client connection manager backend
      
      behatnotneeded
      
      Change-Id: Iac103616c7a9cd68cc94ea301a4cb808fe090669
      aa743c03
  16. 07 Jul, 2016 1 commit
  17. 06 Jul, 2016 1 commit
  18. 24 Jun, 2016 1 commit
  19. 20 Jun, 2016 1 commit
  20. 15 Jun, 2016 1 commit
  21. 03 Jun, 2016 1 commit
  22. 25 May, 2016 1 commit
    • Aaron Wells's avatar
      Dropping support for PHP 5.3 · fd630ce8
      Aaron Wells authored
      Bug 1576448. As discussed at the 52nd Mahara developer meeting.
      
      behatnotneeded: Can't test in Behat (requires environmental
      changes.)
      
      Change-Id: I6cdfb0c154077f597128b7c3c1fd86b40b36c772
      fd630ce8
  23. 19 Apr, 2016 1 commit
  24. 30 Mar, 2016 1 commit
  25. 29 Mar, 2016 1 commit
    • Robert Lyon's avatar
      Bug 1316917: New approach to star rating using bootstrap glyphs · d1bf622a
      Robert Lyon authored
      This is a slimmer / stripped down system for doing jquery ratings.
      
      Instead of relying on styling radio buttons it relies on bootstrap
      glyphs and a hidden input field.
      
      The code is also controlled by a pieform element
      
      See lib/form/elements/ratings.php for more info about that part
      
      It also has some new settings in the Extensions -> artefact -> comment
      config form. They include settign the colour for the star icon, or
      using a different icon, eg hearts/thumbs up, and the number of ratings
      to show (3 - 12)
      
      behatnotneeded
      
      Change-Id: Ibf529efcb9a665c9f303242ed12d0c7b3dee2356
      Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
      d1bf622a
  26. 14 Mar, 2016 1 commit
  27. 24 Feb, 2016 1 commit
    • RafGDev's avatar
      Bug 1536439 Show timelapse for comments if they are less than 1 day old · 4241b640
      RafGDev authored
      Adding a format_timelapse(timestamp1, timestamp2) function to return a
      human readable time difference if the difference is less than a day,
      eg 3 hours and 1 min ago to give visual cue that the item was
      made/updated very recently.
      
      behatnotneeded
      
      Change-Id: I426d10da9ebc7ef1a5b464146fca386f19977579
      4241b640
  28. 02 Feb, 2016 1 commit
    • Liam Sharpe's avatar
      Fixed icon for Moodle instance reference - Bug #1532646 · 41a5917f
      Liam Sharpe authored
      Comprises two fixes:
      1. Icon in profile sidebar next to the Moodle instance's
      name
      2. Mentioning of the Moodle instance in the "Online users"
      sidebar
      
      behatnotneeded
      
      Change-Id: I3c1c09df9156834dc79313b8c30e5264dda2e6ad
      41a5917f
  29. 19 Jan, 2016 1 commit
  30. 09 Dec, 2015 1 commit
  31. 27 Nov, 2015 1 commit
  32. 25 Nov, 2015 1 commit
  33. 20 Nov, 2015 1 commit
    • Hugh Davenport's avatar
      Fix behaviour on submitting multiple pages to Moodle · fd9f1f82
      Hugh Davenport authored
      Bug 1516823
      
      The moodle plugin for mahara assignment submissions [1] had an issue [2]
      where is the plugin was configured in non locking mode, multiple
      submissions of the same view would result in only the latest submitted
      link working.
      
      This was due to the page getting locked then released, which resulted in
      a new mt token, which made all the old ones not work. This patch changes
      that by accepting a new parameter which checks whether you are locking
      and if not, then don't generate and send a token back.
      
      When viewing a view, check for the new parameter mnetviewid or mnetcollid
      along with the parameter assignment. If these are present, then Mahara
      sends an MNet request back to Moodle which tells Mahara whether the user
      has the permission to view the page.
      
      This requires an update to the Moodle plugin, which is sent for review
      currently [3]. Mahara detects whether this plugin is upgraded and
      publishing the new MNet function. If it isn't, it falls back to original
      behaviour gracefully. This is done by attempting to send a MNet request.
      
      [1] https://github.com/MaharaProject/moodle-assignsubmission_mahara
      [2] https://github.com/MaharaProject/moodle-assignsubmission_mahara/issues/2
      [3] https://github.com/MaharaProject/moodle-assignsubmission_mahara/pull/19
      
      behatnotneeded: Can't yet test MNet issues in Behat
      
      Change-Id: I80739181b58bf7cf9c326e7b0a588b6239f864f1
      fd9f1f82
  34. 17 Nov, 2015 1 commit
    • Robert Lyon's avatar
      Bug 1517228: perf_to_log function amd misisng data · e9584a54
      Robert Lyon authored
      Because some systems may not have all the available data we should
      check if the data exists before trying to display it.
      
      To test:
      Before patch change the line in lib/mahara.php
       if (function_exists('posix_times')) {
      to
       if (!function_exists('posix_times')) {
      
      and make sure the 'perf_to_log' config option is set to true
      
      This will cause the errors we are trying to deal with to show up
      
      behatnotneeded
      
      Change-Id: If9610fa0eaf4c8bb036b21c1c75e10d828de7934
      Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
      e9584a54