GitLab

Minor fixes; not all of them required new strings
as they didn't change meaning.

behatnotneeded

Change-Id: Ic714eeb240a945afa7844c75dd6161899734167d

Son Nguyen authored Aug 31, 2016 and Robert Lyon committed Oct 09, 2016

Also update the tinymce/README.Mahara as TinyMCE imagebrowser plugin
is a part of mahara

behatnotneeded

Change-Id: Ie6d3aa1bf80db9f9d52e3373bf407ab6bf8cafad

Aaron Wells authored Oct 03, 2016 and Robert Lyon committed Oct 08, 2016

- Respect the "optional" and "default" flags for
object and array params (not just scalar params)

- Allow REST server to handle file upload params ($_FILES)

behatnotneeded: Tests to come later

Change-Id: I3a6a6ccf7c9de1711e2fd39aa5f130c245823721

Aaron Wells authored Sep 26, 2016 and Robert Lyon committed Oct 08, 2016

These fields can be used to indicate which client app
registered and/or is using the token

behatnotneeded: Can't be tested in Behat

Change-Id: I939c844cc5474fc799ddfd002a1052bb4ca67d1b

Aaron Wells authored Sep 26, 2016 and Robert Lyon committed Oct 08, 2016

behatnotneeded: Test to come later

Change-Id: I77131ad76a5a9f1c6e0f780fdb9bff07d70a8421

Aaron Wells authored Sep 26, 2016 and Robert Lyon committed Oct 07, 2016

Two of the server classes had their own implementations of this,
with slightly different logic. Moving it up into the parent class
in order to make sure everything works the same, all the time.

behatnotneeded: Can't test in Behat

Change-Id: I91c205822a18213c475bbef7c784247cebdbd649

Currently, a plugin has to list its component as e.g.
"module/mobileapi/webservice". This could just be "module/mobileapi".

Since we're using the component string as part of the automated token
request system, it's better to change this now to something more sensible.

behatnotneeded: Tests to come later

Change-Id: Ia7663065b79598d92c3bf8450c5539efb6aa3e2d

Son Nguyen authored Sep 23, 2016 and Robert Lyon committed Oct 07, 2016

behatnotneeded

Change-Id: I9f624b8bbc0ab7c53ebc84f5f8110ae257c6949e

Aaron Wells authored Sep 26, 2016 and Robert Lyon committed Oct 07, 2016

behatnotneeded

Change-Id: Idea08ba7827d939af6f2fc8ec6be30774f2af5cb

For example the Service functions table, where the thead columns are
misaligned from the rest of the table.

This is due to the headings being rendered as pieform type 'html',
which adds an '.html' class, which in turns adds a clearfix and it is
this clearfix that is causing problems

behatnotneeded - design/layout issue

Change-Id: Icd427ab0bdb4ab70214cc9f81c5b33c5e2cddac2
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

To help clients determine which version of a webservice
they might be connecting to.

behatnotneeded: Tests to come later

Change-Id: I90abd0d9470cba4ae42ee3a22a6c0629d325f8d2

- Adding "shortname" field to service groups
- Marking plugin-created service groups, as the ones that have
a "component" field. Make the function list for plugin-created
service groups not editable by users.
- Since users may have already edited the old "sample" service
groups, removing the "component" value from those.
- And, to avoid trouble going forward, preventing the install
of the sample service groups on new installations

behatnotneeded: Tests to be written later

Change-Id: I23c781d6f2bbf689c12de30a67882bf3f1f4aff9

If a user has manually assigned a remote authorization method
from an institution and he is not a member of that institution
when we try to delete the institution there will still be
a record in auth_remote_user table.

When the institution is deleted, so is the authorization method,
and so should be the remote user record.

behatnotneeded

Change-Id: I91dcadc5fbfddc8941c60adc78f304996591b3b8

behatnotneeded

Change-Id: I9c2623c451735d2fc50d8b6240edfa0fe47391da

Added a control in view/share screen to see
if there is a conflict between the access permission dates
and the overriding dates.
There is no conflict only when overriding dates contain
any other access dates.

behatnotneeded

Change-Id: Id6082f314d1e30b3e8bf1cc7d5532afa0ff87c42

Change-Id: I8709a4218a4bc1a233db90e2f85ecc37ce932523

Aaron Wells authored Mar 22, 2016 and Robert Lyon committed Oct 04, 2016

Bug 1560329: We were neglecting to rewire the "cancel/remove"
button on a block config after a Pieforms validation failure.
A pieforms validation failure (when you're using Pieforms'
jsforms feature) actually replaces the current form with a
new one, rather than just inserting error messages into the
existing form.

Change-Id: Ie3fa440595b08cc5a49cb89cb7ca95bcfa02c2db
behatnotneeded: Not easy to test with Behat

Added conditions to javascript to stop the creation
of a new TinyMCE editor for a cover letter
everytime a Personal Information pieform was submitted

behatnotneeded

Change-Id: I3088cc13bcb9167807dfbe545f63e872b45a42b9

Cecilia Vela Gurovic authored Sep 19, 2016 and Cecilia Vela Gurovic committed Sep 28, 2016

Change group homepage so that it does not to show repeated pages/collections in different sections shared/submitted
Updated create_group() in TestingDataGenerator.php to set in the DB the correct group role of a user

Change-Id: I07504f38a35d4dda4a3c4f440d94cffed293bbf2

PHP 5.0 to 5.2 apparently did not support dynamic access
of static members, e.g. $classname::$method(). But support
for this was added in PHP 5.3. So there's no longer any
reason to use call_static_method().

Change-Id: Ib2c48251fb3e5a8ca4af9994bd2d648bc40794d2
behatneeded: Comment update only

This patch removes all authentication functionality
from the browserid auth plugin. It adds a script,
accessible through the plugin's configuration page,
to migrate user accounts from browserid to
internal auth.

Also includes changes to allow users to be searched
by authtype, and to prevent non-useable plugins
from being enabled on the plugin config page.

Change-Id: I4e8bd9fc4d2fb2ccaa1845fda533c9373ec251bd
behatnotneeded: Can't test with behat

JSON-encodes more information about the error or exception,
and adds an optional error number.

behatnotneeded: Can't test in Behat

Change-Id: I258e7a275d78c91a5f8cd638ab7f6a7590125a6d

Added shortname of institution to:
 - Table in institution screen as a column
 - individual institution form as a non editable field

behatnotneeded

Change-Id: I37ba89d5d7c801852f970ce2ff82d7193c85f8d1

In web service configuration, when service provider master switch
and service requester master switch are set to off,
then all protocol switches are set to off and disabled.

behatnotneeded

Change-Id: I2672d93abd14d80f184e08c9796e6fcbee4bfc91

So we can link to the first view if it exists.

This is useful in scenario where a user can see collection but is
unable to see matrix page, eg if plugin is disabled / institution
stops allowing matrices

behatnotneeded

Change-Id: Ie25d07c41b4eddd52e05222e413f2f4dff1de2e3
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Son Nguyen authored Sep 22, 2016 and Robert Lyon committed Sep 22, 2016

behatnotneeded

Change-Id: I36c1d8ce814406d5e933046a844e585c1f397d64

And moving it to the Admin -> Exntension -> SmartEvidence page

Change-Id: I897d45398e34b456640001392ce143d8c6865c58
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

fixing sql call table not in {}

behatnotneeded

Change-Id: I97c110bbbf68e51d8a3337ce213840869c3dbe77
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

When one of the views has a secret url as this will allow all the
pages in the collection to be accessed via the secret url once the
secreturl cookie is set

behatnotneeded

Change-Id: Ic14965bb852d235c965b82a64e53a77e6410360d
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

behatnotneeded

Change-Id: Ife78860e6ba4a88fb57c6de0517caa955eb1a52e
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

@TODO: Allow the js lang strings be picked based on on the section
supplied so that name/section make them unique rather than just name

behatnotneeded - existing test will be sufficient

Change-Id: Ie64725702527b7fd9a08749816ea1fd084e95a2d
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

behatnotneeded

Change-Id: Iae37718b837258cf3221987d994d306bd3dc6335
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Added 'remove' to jsstrings() to include it in the 'strings' variable

behatnotneeded

Change-Id: Ibf1addff4aa548df05496735ed016d81c5918135

This patch:
 - removes the need to set priority value in .matrix file
   they are worked out now based on the array generated
 - changes the way you indicate parent/child relationships by adding a
   'uniqueid' to the parent and change 'parent' value for its children
   to the value of the uniqueid
 - stopped an element showing the dot on the matrix if it has children
 - added indentation for the name (1st) column on matrix page so we
   can see how things relate to each other better

behatnotneeded

Change-Id: I434c495aa58e41f9f2e55da8d6f70b9c1da37038
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

with $smarty->assign()
behatnotneeded

Change-Id: I667463b7732bd3f1dd2619b2836cf4b8c560d264

This fix deals with a better checking of the supplied url and making
sure it is validated on both the addbook form and editcomposite form

Also fixing the help message issues when on editcomposite.php page

behatnotneeded - existing tests should be ok

Change-Id: I8d9e26dcf71f6bc2b3953a5548c3426efb2d459b
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

in open badges block
updated behat test

behatnotneeded

Change-Id: Id26fabb04f570a39fd7f193439b360d001dfa6cf

Journal entries block filtered by tags

behatnotneeded

Change-Id: Idfb823d4babff47b192a7c1b6f0588d2e2e5545b

When the old annotations have feedback on them

behatnotneeded

Change-Id: I1325ebf9d3067065730442b81c885d5b7178c777
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

in select/edit buttons for folder and files

behatnotneeded

Change-Id: Icf89b2add901828470dff50fb18cc39ef2f31056