1. 16 May, 2021 1 commit
    • Doris Tam's avatar
      Bug 1911824: Change the copy setting for artefact annotation to 'nocopy' · d31993dd
      Doris Tam authored and Robert Lyon's avatar Robert Lyon committed
      Check that $evidences exist in case there exist evidenviews but no evidence blocks to copy
      
      if the only block on a view is an annotation block, then make a check to not get the sql to run copies
      which will result in error as there are no artefacts to copy.
      
      Change-Id: Ie914704046c2396a2fedce958cef3a44dd28ae33
      (cherry picked from commit cba39269)
      d31993dd
  2. 29 Apr, 2021 3 commits
  3. 27 Apr, 2021 1 commit
  4. 26 Apr, 2021 1 commit
  5. 22 Apr, 2021 2 commits
  6. 21 Apr, 2021 1 commit
    • Alexander Del Ponte's avatar
      Bug 1862370: New submissions plugin · cf3d290b
      Alexander Del Ponte authored and Robert Lyon's avatar Robert Lyon committed
      This plugin adds a comfortable management of current and already
      released group submissions by providing a sort and filterable table in
      its own group tab including direct access to the portfolios resp. their
      archived version.
      
      Additional metadata is also provided together with the possibility to
      release the portfolio or to assign an evaluator and an evaluation result.
      
      behatnotneeded: Behat tests to follow
      
      Change-Id: I702322e3af92bd84a333edd028fcf8611e942bed
      cf3d290b
  7. 06 Apr, 2021 1 commit
    • Gold's avatar
      Bug 1907000 - fix Add entry drag n drop. · 98a38d90
      Gold authored
      * Added a new class to force the pointer cursor.
      * Added this class to the Add entry anchors.
      * Added a data flag to assist spotting the drag n drop activity when Add
      entry is the element clicked for dragging the block.
      * Added js to test this data flag before submitting on click.
      * Renamed `AddNewPostShortcut()` in recent/tagged posts JS to better
      identify them.
      
      Change-Id: I3e367cd9323e9eb5ef18495d33ce6fa9c3c7c48d
      98a38d90
  8. 31 Mar, 2021 1 commit
    • Gold's avatar
      Bug 1730263 - Multiple sources for names in persondata · 9c370270
      Gold authored
      A partial export (just selected pages) does not include the persondata
      tags. When these are not present the first/last names are taken from the
      author tag.  I've added a 'source' parameter to the firstname/lastname
      fields that can be checked later in the process when the Import form is
      being presented.  If the source is the author tags we force the Ignore
      option on the decision field values.
      
      The Bug referenced 'personal information' so I have included the email
      field.
      
      Change-Id: Ifa173a88f497be994c5ab93e26376463442ab24b
      9c370270
  9. 01 Mar, 2021 1 commit
    • Gold's avatar
      Bug 1916833 - Annotation can be updated on a page · 690edccd
      Gold authored
      Config gear icon removed from the Annotation blocks.
      In order to still initially create these when added we needed to check
      if the Block was a new instance or not. To achieve that we are now
      passing the block instance into the has_instance_config() method.
      
      BlockInstance has been extended and will set a 'new' parameter if the ID
      in the constructor is 0.
      
      AuthPlugin* classes also have the has_instance_config(). These do not
      need the BlockInstance passed in.
      
      Change-Id: Ifac69fc1d48b45c079b6f66e610776cead3dee63
      690edccd
  10. 24 Feb, 2021 1 commit
  11. 11 Feb, 2021 1 commit
    • Evonne's avatar
      Bug 1912414 Style updates · 6c312125
      Evonne authored and Kristina Hoeppner's avatar Kristina Hoeppner committed
      - Make comment public /portfolio/feedback.html: sits in the middle and
        doesn't have the correct class.
      - Comment with attachment: size is still displayed and download icon
        doesn't have tooltip that includes file name and size.
      - Objectionable content: When page seen in 'Shared by me' page, it's
        missing the 'Portfolio under review' markup.
      - Plans: The word 'Template' is too small on the plans overview page.
      - Plans: View page and also Edit: Remove red background for overdue plan
        item as well as the red from its heading.
      - Plans: Edit on a page: The chevron on the task sits awkwardly.
      - Mark a forum post as objectionable: The alert icon to the left of the
        profile icon of the post that you are reporting is missing.
      - Once forum post has been reported, change the red text for 'Reported
        details' to black.
      - Legal: Expanded item has the chevron in the wrong direction.
      - Legal: The 'Last update' date moved to the bottom from the top right
        hand corner.
      - Elasticsearch result page, journal entry is pushed to the left.
      - Account settings in admin area: Calendar icon below last login sits
        outside of box.
      - Skin: - heading within a text block uses the block heading font when
        it should not do that.
      - Group's about page - under Group Portfolios heading, when a page/
        collection is a template, it has a button on the right to allow
        copying, tpl needs to be updated so it aligns to top of the
        list-group-item.
      - Look into the btn-group-top responsiveness, too many overrides for
        specific pages, like comments remove button, it seems to require an
        extra pixel around md breakpoint, would like to clean this up.
      
      behatnotneeded
      
      Change-Id: Icfffed9376e89339a8fad5a207d3b974b431e451
      6c312125
  12. 04 Feb, 2021 1 commit
  13. 28 Jan, 2021 1 commit
    • Gold's avatar
      Bug 1895066 · e105d8aa
      Gold authored
      Draft peer assessment needs additional indicator besides colour
      
      Added a 'draft' string to "view" and used that in the template.
      Updated the 'draft' string in "blocktype.peerassessment/peerassessment"
      to 'savedraft' to prevent confusion.
      Added 'pubstatus' to the item if it is private and set this to Draft.
      Added pubstatus to the template if set to private. Style for this
      replicates the private status on Bug 1912414.
      
      Change-Id: I9cb0b20f9e00536e3162c3f83583b4877a6913a9
      e105d8aa
  14. 22 Dec, 2020 1 commit
    • Evonne's avatar
      Bug 1907719: Fix styling issues · 51c4aa83
      Evonne authored and Kristina Hoeppner's avatar Kristina Hoeppner committed
      1. Profile picture in sidebar is now always within the background colour
         even when there is a short name.
      2. 'Tags' is not displayed in bold any more so as not to draw too much
         attention to it.
      3. Removed all pull-right and pull-left classes and put in float-right
         or float-left instead (bootstrap legacy).
      4. Fixed field outline colour in the configurable theme so that the same
         colour is now used everywhere.
      5. Reviewed the use of outer-link and inner-link as they were not
         accessible. Rule: If it is a single link it can an outer-link so that
         the entire item is outlined on click (nicer visually), but if the item
         has other links within it then outer-link should not be used.
      6. Removed outer-link hover background as some list items had it and
         some didn't. Rule: No hover background colour for items.
      
      behatnotneeded
      
      Change-Id: I737841f9bfe825c0a004951bb4b7c7c589ab019d
      51c4aa83
  15. 18 Dec, 2020 1 commit
    • Kevin Dibble's avatar
      Bug 1803101: peer assessment artefact import · 6d19103a
      Kevin Dibble authored and Robert Lyon's avatar Robert Lyon committed
      Need to define owner and block when creating a
      peer assessment artefact while importing
      
      Create a temp block to assign on artefact creation
      that later needs to be replaced by the actual block
      when it's available
      
      Draft assessments should not be exported or imported.
      For exported portfolios created on older version of
      Mahara, there is no way of knowing if they are drafts
      at the moment of importing because this information
      was not included in the leap2A export xml file.
      Not importing draft peer assessments should work
      from this patch.
      
      It also adds a fix to support
      Postgres and MySQL when a table
      column name is a reserved word.
      
      Removing not null restriction for "usr" field in "artefact_peer_assessment"
      table:
      - The author in peer assessment table should be working as comments table.
      - For each comment, there is an entry in 'artefact' table that contains
      author and authorname, and another entry in 'artefact_comment_comment'
      that doesn't have an author field
      becau...
      6d19103a
  16. 07 Dec, 2020 1 commit
  17. 06 Dec, 2020 1 commit
  18. 15 Oct, 2020 1 commit
  19. 06 Oct, 2020 1 commit
  20. 30 Sep, 2020 1 commit
  21. 21 Sep, 2020 1 commit
  22. 17 Sep, 2020 1 commit
    • Evonne's avatar
      Bug 1845053 Font size and size variable · 1d324796
      Evonne authored and Robert Lyon's avatar Robert Lyon committed
      Base font has been increased to 16px, and as a result, variables
      have had to be recalculated.
      
      Max browser width has been increased to 1440px to allow the
      larger font to have more characters in a line.
      
      As a part of accessibility, headings H1-H6 have had to be rejigged.
      Note that for elements such as popup/modals, the heading restarts
      at H1 again as advised by Julius.
      
      Page heading is H1, block heading is H2, everything else should be
      H3. Trying to attempt to reserve H4-H6 for user content, but it is
      still existing in some places as some things can't be changed.
      
      Attachment markups have been unified and added to styleguide.
      
      Removed H3/H4 from fieldset legends.
      
      behatnotneeded
      
      Change-Id: I69273c9775d658f03738c29be8d230b59c189790
      1d324796
  23. 10 Sep, 2020 1 commit
  24. 01 Sep, 2020 2 commits
    • Robert Lyon's avatar
      Bug 1892794: Allowing custom profile fields have custom titles · 0ca96efc
      Robert Lyon authored
      
      
      Currently all profile fields title/label named via the artefacttype
      But if we want different titles in differnet contexts we can now do
      this by adding to our ArtefactTypeWhatever class something like
      
          public static function static_display_title() {
              if (... some condition ...) {
                  return get_string('altoption', 'artefact.internal');
              }
              return get_string('option', 'artefact.internal');
          }
      
      Change-Id: I32cfdc821442a7ba8729d76a18e6ddc1f7a62c95
      Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
      0ca96efc
    • Cecilia Vela Gurovic's avatar
      Bug 1892428: Turn peer role into configurable role so it can see content · 104517a1
      Cecilia Vela Gurovic authored
      If a user has access with  peer role to a portfolio
      and the owner of the portfolio belongs to institutions
      that allow the peer role to see content of blocks
      then the logged in user will be able to see the content of pages
      even if they don't have a peer assessment block in it
      
      If the owner of the portfolio belongs to at least one institution
      that doesn't allow the peer role to see content of blocks
      then the fuctionality remains the same:
      a peer doesn't see any content if there is no peer assessment block in the page
      a peer only sees block headers if there is a peer assessment block in the page
      
      behatnotneeded
      
      Change-Id: I6bf84d919cc897cb912be463817b64dfb11c0c1a
      104517a1
  25. 31 Aug, 2020 2 commits
  26. 20 Aug, 2020 1 commit
  27. 03 Aug, 2020 1 commit
  28. 30 Jul, 2020 1 commit
  29. 24 Jul, 2020 1 commit
  30. 19 Jul, 2020 1 commit
  31. 24 Jun, 2020 1 commit
    • Cecilia Vela Gurovic's avatar
      Bug 1857936: Lock page and artefact instructions · 479ff998
      Cecilia Vela Gurovic authored
      - A new page setting “Template” is added to the
      “Advanced” panel on all portfolio page areas of
      Mahara (personal, group, institution, site)
      with a Yes/No switch
      - added 2 columns to view table:
      'templatetocopy': indicates if the view is a
        template that can be copied
      'originaltemplate': if it has a value then the view
        is a copy of a template and should have
        the instructions locked.
        The value it contains is the viewid of
        the original template.
      - if a view is a copy of a template: display
      instructions in view settings and text blocks
      but don't allow to edit them. If empty, don't show them.
      - When adding a new text block to a page,
      don't allow to add instructions
      - Allow to remove the lock on a copy for roles:
          site admins in institution and site pages
          institution admins in institution pages
          group admins in group pages
      - If a template view is deleted from the site,
      then all the locked copies it has will remain locked.
      
      behatnotneeded
      
      Change-Id: I47e98cf8413da5ba6d5dea0e29dddbd80c481317
      479ff998
  32. 22 Jun, 2020 2 commits
  33. 15 Jun, 2020 1 commit
  34. 04 Jun, 2020 1 commit