1. 16 May, 2021 1 commit
    • Doris Tam's avatar
      Bug 1911824: Change the copy setting for artefact annotation to 'nocopy' · d31993dd
      Doris Tam authored
      Check that $evidences exist in case there exist evidenviews but no evidence blocks to copy
      
      if the only block on a view is an annotation block, then make a check to not get the sql to run copies
      which will result in error as there are no artefacts to copy.
      
      Change-Id: Ie914704046c2396a2fedce958cef3a44dd28ae33
      (cherry picked from commit cba39269)
      d31993dd
  2. 29 Apr, 2021 1 commit
  3. 06 Apr, 2021 1 commit
    • Gold's avatar
      Bug 1907000 - fix Add entry drag n drop. · 98a38d90
      Gold authored
      * Added a new class to force the pointer cursor.
      * Added this class to the Add entry anchors.
      * Added a data flag to assist spotting the drag n drop activity when Add
      entry is the element clicked for dragging the block.
      * Added js to test this data flag before submitting on click.
      * Renamed `AddNewPostShortcut()` in recent/tagged posts JS to better
      identify them.
      
      Change-Id: I3e367cd9323e9eb5ef18495d33ce6fa9c3c7c48d
      98a38d90
  4. 01 Mar, 2021 1 commit
    • Gold's avatar
      Bug 1916833 - Annotation can be updated on a page · 690edccd
      Gold authored
      Config gear icon removed from the Annotation blocks.
      In order to still initially create these when added we needed to check
      if the Block was a new instance or not. To achieve that we are now
      passing the block instance into the has_instance_config() method.
      
      BlockInstance has been extended and will set a 'new' parameter if the ID
      in the constructor is 0.
      
      AuthPlugin* classes also have the has_instance_config(). These do not
      need the BlockInstance passed in.
      
      Change-Id: Ifac69fc1d48b45c079b6f66e610776cead3dee63
      690edccd
  5. 07 Dec, 2020 1 commit
  6. 24 Apr, 2020 1 commit
    • Rebecca Blundell's avatar
      Bug 1839411: Update Mahara to work with PHP7.3/7.4 · 4263848b
      Rebecca Blundell authored
      Fixed strpos error picked up by 7.3
      I haven't found any other 7.3 issues and none have been caught by behat
      
      For 7.4:
      -Fixed implode param order (glue, parts)
       Note that Mink has a reversed implode not fixed upstream:
       external/vendor/behat/mink/src/Selector/Xpath/Escaper.php:50
       I have added a function to copy the correct code over in the interim
       I also pushed a change to an HTMLPurifier file as it is not fixed upstream
      -Changed a variable read by fread to allow for false return type
      -Calling a non-array as an array now causes an error, meaning we need to
       confirm an array value before attempting to use a variable. An obvious
       case is in multi-record db calls the return value is either an array of
       results or false. E.g.
          $array = db_call();//returns false as no results
          //do sth with result
          $var = $array[0]//error, trying to access type false as array
          //instead we need to check the value before accessing:
          $var = !empty($array[0]) ? $a...
      4263848b
  7. 29 Mar, 2020 1 commit
  8. 17 Oct, 2019 1 commit
  9. 04 Oct, 2019 1 commit
    • Cecilia Vela Gurovic's avatar
      Bug 1813987: block resizing to fit content · 565776fb
      Cecilia Vela Gurovic authored
      should not resize blocks in view mode
      
      in view mode, if the content of the block is static,
      then the block dimensions should not change but the
      content of the block should be made smaller
      
      expand the height of a block only if the content is dynamic,
      like the 'Journal' block
      
      behatnotneeded
      
      Change-Id: Ie8183736580e7e592b24e36f4a16618b96a5bf4e
      565776fb
  10. 25 Sep, 2019 1 commit
    • Lisa Seeto's avatar
      Bug 1827811: Journal changes · f7431a3a
      Lisa Seeto authored
      
      
      Journal changes:
      Change the modal contents to not show post contents or attached files.
      Recent posts and Tagged posts (if not in full display) now expandable with post contents and comment links.
      Attached files on page block now links only to download and not to display further metadata.
      Cleaned up artefact.php links.
      remove metada that will show on entry on page from also showing in modal
      stop background page scrolling when the modal is opened and "Advanced licensing" is selected.
      add the blogpost_render_in_modal.tpl file
      get rid of scrolling for data-toggle collapse
      add block-header to journal, journal entry
      add titles as modal links for recent posts and tagged journal entries
      add comments and details icons for recent posts and tagged journal entries
      fix things from code review
      
      behatnotneeded
      
      Change-Id: Ic63ebf9fe42e7848559b5e009584fdff0a40770f
      Signed-off-by: default avatarLisa Seeto <lisaseeto@catalyst.net.nz>
      f7431a3a
  11. 17 Feb, 2019 1 commit
  12. 24 Oct, 2018 1 commit
  13. 30 Sep, 2018 2 commits
  14. 04 Jul, 2018 1 commit
  15. 19 Jun, 2018 2 commits
  16. 19 Mar, 2018 1 commit
    • Robert Lyon's avatar
      Bug 1755919: Adding related tags page and adjusting tag filter · 0ad5b688
      Robert Lyon authored
      
      
      This patch contains the following:
      - created a relatedtags.php page + json file + template to handle the
      viewing of related tags for a user, the differences for this to
      tags.php page are:
      -- it can be viewed publically
      -- it requires a tag and viewid
      
      - Adjusted the filters for blog/blogpost, plan/task so they appear
      under their own filters as well as 'text' filter
      
      - adjusted the dwoo function list_tags so that we can pass an array of
      viewids/tags and/or just a view id
      
      -adjusted the portfolio_search_* functions so they would work for both
      my tags and related tags pages
      
      - fixed a filter js problem for tags.php where choosing the filter was
      not updating the displayed filter string
      
      behatnotneeded
      
      Change-Id: Ie3a2c3cb56e94ced0e021265bce88e35a9cfba5d
      Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
      0ad5b688
  17. 06 Dec, 2017 1 commit
  18. 07 Aug, 2017 1 commit
    • Cecilia Vela Gurovic's avatar
      Bug 1705126: fix for tag encoding · fabee237
      Cecilia Vela Gurovic authored
      Fix for tag search when they have a character changed by urlencoding()
      Fix for tag display in Tagged posts block when tag has a character
        changed by htmlspecialchar()
      Fix for not executing javascript inside the text of a tag
      Fix to delete blocktype_taggedposts_tags entries when deleting a
        tagged posts block
      
      behatnotneeded
      
      Change-Id: Ic4a56ea90457e605c99203f0b355def93a04baa1
      fabee237
  19. 25 May, 2017 1 commit
  20. 15 May, 2017 1 commit
    • Son Nguyen's avatar
      Bug 1575512: Better way to check if a page is ready for behat tests · f27e5ebf
      Son Nguyen authored
      Add JS event handlers for
       - pieforms
       - tinyMCE editor
       - bootstrap
      to detect when a page is ready after a behat test step
      
      Refactor behat tests .feature files
       - remove redundant steps I wait
       - replace the step I set the field ...
         by the faster step I fill in ...
         for regular text inputs
      
      Change-Id: I0ce4cc8dc32f228a648cfee608ec60ed917b7774
      f27e5ebf
  21. 12 Jan, 2017 1 commit
  22. 14 Sep, 2016 1 commit
  23. 22 Jun, 2016 2 commits
  24. 10 Jun, 2016 1 commit
  25. 15 May, 2016 1 commit
  26. 16 Mar, 2016 1 commit
  27. 07 Mar, 2016 1 commit
    • Aaron Wells's avatar
      "Tagged journal entries" block shouldn't grant access to whole journal · ada12dba
      Aaron Wells authored
      Bug 1521818. Making the "Tagged journal entries" block act more like
      a collection of "Journal entry" blocks. So, it doesn't add the parent
      blog to view_artefacts, only the specific blog entries that are
      displayed in the block.
      
      Also removing the title of the parent blog (and the link to it) from
      the list of blog entries, like the "Journal entry" block, which
      doesn't display the title of the containing journal.
      
      Note the viewer may still have access to the whole blog, if the blog
      is also shared on the same page via a "blog" or "recent journal entries"
      block.
      
      Change-Id: I33fc7e58b964c03bc8003f1de81a4bf58b6079b7
      ada12dba
  28. 24 Nov, 2015 1 commit
    • Aaron Wells's avatar
      Display icons for 3rd-party blocktypes plugins · 4f849ed2
      Aaron Wells authored
      Bug 1510421
      
      Defines a new static PluginBlocktype method, get_css_icon(), which
      fetches the name of the CSS icon to use for this blocktype. It returns
      false by default, which tells the theme to "fall back" to the old
      thumbnail.png instead. 3rd-party plugins can override this to
      specify a particular icon to use.
      
      All the core blocktypes have been refactored to extend
      MaharaCoreBlocktype, which uses the blocktype name as the name
      of the CSS icon to use. I also deprecated the "SystemBlocktype"
      class while I was at it.
      
      PluginBlocktype::get_blocktypes_for_category() now returns both
      the results of get_css_icon() and the thumbnail.png path, so that
      themes can decide which they want to use. (And of course
      thumbnail.png is served via thumbnail.php, so 3rd party themes
      can provide their own custom image files if they wish.)
      
      behatnotneeded: Requires installing third-party plugins to test
      
      Change-Id: Idb1ecfc7b21175913708e695788906c11133b0c0
      4f849ed2
  29. 21 Oct, 2015 1 commit
  30. 15 Jul, 2015 1 commit
  31. 28 Mar, 2015 1 commit
  32. 23 Mar, 2015 1 commit
  33. 19 Mar, 2015 1 commit
  34. 05 Feb, 2015 1 commit
  35. 04 Feb, 2015 1 commit
  36. 30 Jan, 2015 1 commit
    • Aaron Wells's avatar
      Make blocktype:taggedposts work with view_artefacts · 669ebe8b
      Aaron Wells authored
      Bug 1401210. The get_artefacts() method is used by the Blogpost
      artefact to find all the blocks that use a particular blogpost,
      for storing in the view_artefacts table.
      
      I needed to add a table, blocktype_taggedposts_tags, to store
      the tags in a manner that was easier to query than a serialized
      blockconfig.
      
      Change-Id: Ieef58715e404689d95848e32ccd4132ea3fbcdc5
      669ebe8b
  37. 28 Jan, 2015 1 commit