1. 16 May, 2021 1 commit
    • Doris Tam's avatar
      Bug 1911824: Change the copy setting for artefact annotation to 'nocopy' · d31993dd
      Doris Tam authored and Robert Lyon's avatar Robert Lyon committed
      Check that $evidences exist in case there exist evidenviews but no evidence blocks to copy
      
      if the only block on a view is an annotation block, then make a check to not get the sql to run copies
      which will result in error as there are no artefacts to copy.
      
      Change-Id: Ie914704046c2396a2fedce958cef3a44dd28ae33
      (cherry picked from commit cba39269)
      d31993dd
  2. 29 Apr, 2021 1 commit
  3. 27 Apr, 2021 1 commit
  4. 26 Apr, 2021 1 commit
  5. 01 Mar, 2021 1 commit
    • Gold's avatar
      Bug 1916833 - Annotation can be updated on a page · 690edccd
      Gold authored
      Config gear icon removed from the Annotation blocks.
      In order to still initially create these when added we needed to check
      if the Block was a new instance or not. To achieve that we are now
      passing the block instance into the has_instance_config() method.
      
      BlockInstance has been extended and will set a 'new' parameter if the ID
      in the constructor is 0.
      
      AuthPlugin* classes also have the has_instance_config(). These do not
      need the BlockInstance passed in.
      
      Change-Id: Ifac69fc1d48b45c079b6f66e610776cead3dee63
      690edccd
  6. 24 Feb, 2021 1 commit
  7. 04 Feb, 2021 1 commit
  8. 18 Dec, 2020 1 commit
    • Kevin Dibble's avatar
      Bug 1803101: peer assessment artefact import · 6d19103a
      Kevin Dibble authored and Robert Lyon's avatar Robert Lyon committed
      Need to define owner and block when creating a
      peer assessment artefact while importing
      
      Create a temp block to assign on artefact creation
      that later needs to be replaced by the actual block
      when it's available
      
      Draft assessments should not be exported or imported.
      For exported portfolios created on older version of
      Mahara, there is no way of knowing if they are drafts
      at the moment of importing because this information
      was not included in the leap2A export xml file.
      Not importing draft peer assessments should work
      from this patch.
      
      It also adds a fix to support
      Postgres and MySQL when a table
      column name is a reserved word.
      
      Removing not null restriction for "usr" field in "artefact_peer_assessment"
      table:
      - The author in peer assessment table should be working as comments table.
      - For each comment, there is an entry in 'artefact' table that contains
      author and authorname, and another entry in 'artefact_comment_comment'
      that doesn't have an author field
      becau...
      6d19103a
  9. 06 Dec, 2020 1 commit
  10. 06 Oct, 2020 1 commit
  11. 21 Sep, 2020 1 commit
  12. 17 Sep, 2020 1 commit
    • Evonne's avatar
      Bug 1845053 Font size and size variable · 1d324796
      Evonne authored and Robert Lyon's avatar Robert Lyon committed
      Base font has been increased to 16px, and as a result, variables
      have had to be recalculated.
      
      Max browser width has been increased to 1440px to allow the
      larger font to have more characters in a line.
      
      As a part of accessibility, headings H1-H6 have had to be rejigged.
      Note that for elements such as popup/modals, the heading restarts
      at H1 again as advised by Julius.
      
      Page heading is H1, block heading is H2, everything else should be
      H3. Trying to attempt to reserve H4-H6 for user content, but it is
      still existing in some places as some things can't be changed.
      
      Attachment markups have been unified and added to styleguide.
      
      Removed H3/H4 from fieldset legends.
      
      behatnotneeded
      
      Change-Id: I69273c9775d658f03738c29be8d230b59c189790
      1d324796
  13. 31 Aug, 2020 2 commits
  14. 24 Jul, 2020 1 commit
  15. 19 Jul, 2020 1 commit
  16. 15 Jun, 2020 1 commit
  17. 22 May, 2020 1 commit
  18. 29 Apr, 2020 2 commits
  19. 24 Apr, 2020 1 commit
    • Rebecca Blundell's avatar
      Bug 1839411: Update Mahara to work with PHP7.3/7.4 · 4263848b
      Rebecca Blundell authored and Cecilia Vela Gurovic's avatar Cecilia Vela Gurovic committed
      Fixed strpos error picked up by 7.3
      I haven't found any other 7.3 issues and none have been caught by behat
      
      For 7.4:
      -Fixed implode param order (glue, parts)
       Note that Mink has a reversed implode not fixed upstream:
       external/vendor/behat/mink/src/Selector/Xpath/Escaper.php:50
       I have added a function to copy the correct code over in the interim
       I also pushed a change to an HTMLPurifier file as it is not fixed upstream
      -Changed a variable read by fread to allow for false return type
      -Calling a non-array as an array now causes an error, meaning we need to
       confirm an array value before attempting to use a variable. An obvious
       case is in multi-record db calls the return value is either an array of
       results or false. E.g.
          $array = db_call();//returns false as no results
          //do sth with result
          $var = $array[0]//error, trying to access type false as array
          //instead we need to check the value before accessing:
          $var = !empty($array[0]) ? $a...
      4263848b
  20. 23 Apr, 2020 1 commit
  21. 21 Apr, 2020 1 commit
  22. 16 Apr, 2020 1 commit
  23. 15 Apr, 2020 3 commits
    • Evonne's avatar
      Bug 1870444: Cover images for portfolios style changes · 46924bae
      Evonne authored and Robert Lyon's avatar Robert Lyon committed
      Fixing up some css and classes.
      
      behatnotneeded
      
      Change-Id: I75946a358563a3b1a84b9f928cff4fe9ea1679bc
      46924bae
    • Cecilia Vela Gurovic's avatar
      Bug 1870444: Cover images for portfolios · a2f56dba
      Cecilia Vela Gurovic authored
      - added cove mage field to view/collection settings
      - it works for personal/group/institution/site portfolios
      - creates the "Cover Images" folder if it doesn't exist to store the cover images
      as default location. This is created when navgating to a view/collection settings section.
      - there is an upgrade to add 'coverimage' column to view and
      collection tables on the db.
      - the cover image is displayed in the view/collection card
      on pages and collections section
      - copy views/collections should copy the cover image
      - display the image in the card of pages and collections if it has one.
      If there's no image it should display the desctiption or nothing if there's
      no description. If it has cover image and a description, then it displays
      the image and when hover over it will display the description.
      On mobile it will display the description when touched
      
      TODO
      - accessibility
      - importing views/collections should import the cover image
      
      behatnotneeded
      Change-Id: I72e305ba437...
      a2f56dba
    • Cecilia Vela Gurovic's avatar
      Bug 1868916: error syntax in blocks js · 6e76cc97
      Cecilia Vela Gurovic authored and Robert Lyon's avatar Robert Lyon committed
      behatnotneeded
      
      Change-Id: Id7c3169cbe1594c863e33b065fe6ea9cbad7e3f7
      6e76cc97
  24. 01 Apr, 2020 1 commit
  25. 31 Mar, 2020 6 commits
  26. 30 Mar, 2020 1 commit
  27. 29 Mar, 2020 1 commit
  28. 25 Mar, 2020 2 commits
  29. 28 Feb, 2020 1 commit
  30. 22 Jan, 2020 1 commit