1. 16 May, 2021 1 commit
    • Doris Tam's avatar
      Bug 1911824: Change the copy setting for artefact annotation to 'nocopy' · d31993dd
      Doris Tam authored
      Check that $evidences exist in case there exist evidenviews but no evidence blocks to copy
      
      if the only block on a view is an annotation block, then make a check to not get the sql to run copies
      which will result in error as there are no artefacts to copy.
      
      Change-Id: Ie914704046c2396a2fedce958cef3a44dd28ae33
      (cherry picked from commit cba39269)
      d31993dd
  2. 29 Apr, 2021 1 commit
  3. 01 Mar, 2021 1 commit
    • Gold's avatar
      Bug 1916833 - Annotation can be updated on a page · 690edccd
      Gold authored
      Config gear icon removed from the Annotation blocks.
      In order to still initially create these when added we needed to check
      if the Block was a new instance or not. To achieve that we are now
      passing the block instance into the has_instance_config() method.
      
      BlockInstance has been extended and will set a 'new' parameter if the ID
      in the constructor is 0.
      
      AuthPlugin* classes also have the has_instance_config(). These do not
      need the BlockInstance passed in.
      
      Change-Id: Ifac69fc1d48b45c079b6f66e610776cead3dee63
      690edccd
  4. 06 Dec, 2020 1 commit
  5. 17 Sep, 2020 1 commit
    • Evonne's avatar
      Bug 1845053 Font size and size variable · 1d324796
      Evonne authored
      Base font has been increased to 16px, and as a result, variables
      have had to be recalculated.
      
      Max browser width has been increased to 1440px to allow the
      larger font to have more characters in a line.
      
      As a part of accessibility, headings H1-H6 have had to be rejigged.
      Note that for elements such as popup/modals, the heading restarts
      at H1 again as advised by Julius.
      
      Page heading is H1, block heading is H2, everything else should be
      H3. Trying to attempt to reserve H4-H6 for user content, but it is
      still existing in some places as some things can't be changed.
      
      Attachment markups have been unified and added to styleguide.
      
      Removed H3/H4 from fieldset legends.
      
      behatnotneeded
      
      Change-Id: I69273c9775d658f03738c29be8d230b59c189790
      1d324796
  6. 21 Apr, 2020 1 commit
  7. 15 Apr, 2020 1 commit
  8. 01 Apr, 2020 1 commit
  9. 31 Mar, 2020 1 commit
  10. 22 Oct, 2019 1 commit
    • Cecilia Vela Gurovic's avatar
      Bug 1813987: resizing wall/gallery block when content change · 9e81132d
      Cecilia Vela Gurovic authored
      wall
      - resize the block when adding a new post
      - resize the block when the tinymce is changed
      (menu expanded/textarea resized)
      
      image gallery
      - resize the block when the block has a slide show
      and the image is changed
      
      behatnotneeded
      
      Change-Id: I7fe0624285443b6173d9bd5f5be488539f6da03d
      9e81132d
  11. 26 Sep, 2019 1 commit
    • Evonne's avatar
      Bug 1827811: Journal and resume details buttons overlap · f5ca6b3a
      Evonne authored
      Fixes for journal titles and resume attachments for employment
      overlapped by details button.
      
      behatnotneeded
      
      - clean up unneccessary include in export/html/lib.php
      - fix html export for the creation of nested folder modals
       make sure the nested folders and find all nested modals
      - fix elseif typo in block-comments-details-header.tpl
      - add details bar to image gallery when displayed from folders
      - fix notes block empty modal issue due to .tpl typo
      - fix image gallery slideshow error where second gallery block
      always targets the first
      - keep the active block headers showing after pagination update
      
      Change-Id: Icf8d59ad558d74883e3ee2070f55768697af4254
      f5ca6b3a
  12. 25 Sep, 2019 3 commits
    • Lisa Seeto's avatar
      Bug 1827811: Resume Icons · 953a5eab
      Lisa Seeto authored
      
      
      - get attachment comment counts for bh icons
      - display plain text for titles in editing mode
      - change the way the commentlink is targetted via js
      - add blockid's to resume attachments
      - for folder block: add comment count, change titles from
      	links to plain text when editing
      - change notes attachment file titles from links to plain
      	text when editing
      - get rid of the single artefact block title links for html exports
      ---------------------------------------------------------
      Add fixes:
      - blocks that have set types but no artefacts attached don't have modal links
      - pdf block is now using block header and comment count is loaded
      - block headers are above titles
      - tagged journals have icons when in full and matches recent posts styling
      - deleting all comments produces correct icon on block header
      - html exports should not hang on opening modal
      - get rid of warning error re: dock.show() when redirecting from &modal=1 style url
      - code review fixes for all previous patches + fix issue with folders block
      - added in viewdetailsfilter.json.php file to save details mode to user account prefs table
      - make the details btn mode "sticky" so it stays the save value over multiple pages etc...
      - Image Gallery blocks: if displaying a folder of images will get the bar block header and
      will have a the fancy box image preview displaying on image click
      
      Change-Id: I425cc5a634e176d580aacdb60a20f869f7cb7496
      Signed-off-by: default avatarLisa Seeto <lisaseeto@catalyst.net.nz>
      953a5eab
    • Lisa Seeto's avatar
      Bug 1827811: Embedded Media Task · b82df03d
      Lisa Seeto authored
      
      
      add the block-header to the block.
      remove the download link from page as it now shows in the modal.
      add artefactid and blockid to image.tpl
      fix issue with data-toggle collapse targeting syntax error.
      update  active block functionality for block headers
      update block-comments-details-header.tpl for icon headers
      fix Journals, and tagged entries and recent posts to use icons for block header.
      change pdf block to use block header icons
      clean up .comments-details class that is no longer needed.
      add modal functionality for image gallery blocks for thumbnails and thumbnails square presentation.
      add modal functionality for some html block, clear up js for icons that is no longer needed.
      add title text to icons and block-header
      create activateModalLinks() func to tidy up js modal click events in view/view.php
      
      Change-Id: Ib5967d44288557ef4d380eb99241e8442da90f29
      Signed-off-by: default avatarLisa Seeto <lisaseeto@catalyst.net.nz>
      b82df03d
    • Lisa Seeto's avatar
      Bug 1827811: Move "Add comment" and "Details" into modal with "Comments" · be7af61f
      Lisa Seeto authored
      
      
      create modal using configureblock id, update various templates to use the modal for blocks:
      Image
      Note
      File(s) to download
      Journal/blogs
      add JS to open/close modal, add comments, delete comments, reply to comments, paginate comments.
      add JS to handle url that redirects to view/view.php with modal open and populated.
      Further changes to each block will be completed in child patches.
      Add segment headings to the modal. Fix display of comments to cover width of modal.
      Show comment removed msg in modal/page appropriately.
      Fix behat test to close modal before continuing.
      do not show existing comments if comments not allowed on artefact.
      add validation to modal for comments/attachments
      disable image as link when editing for image block
      trigger focus on modal for accessibility
      close modal on escape keydown event
      fix merge conflict in view/view.php
      fix merge conflict with master
      make configureblock modal play nicely when comment block is on the page
      update display of error messages to always show at top of modal so user doesn't have to scroll
      add accesibility to close modal on escape key down
      handle dock show/hide events for paginated pages in modal during validation
      create block-comments-details-header template file
      create details button and custom scss file with js to show and hide header
      update comment links to save add comment and details when commentcount == 0
      add active-block class to colour the block-header when active
      toggle the details-btn active css
      add _block-comments-details-header.scss to patch
      change class invisble to class d-none
      add block-comments-details-header.tpl to blocktypecontainerviewing.tpl
      code review changes
      add .no-modal class to links on group home page, dashboard and profile page.
      add block header to appear above the title
      change assessbtn from anchor tag to button to prevent scrolling.
      make all clickable links clickable on page load (ignore assess mode)
      fix js issues surrounding assessbtn move and show/hide blocks
      change cursor on dashboard, my profile page, group homepage to default when over disabled modal links
      update assessbtn to details btn
      create tooltip for hover over file download block titles
      fix containerElm console log error by not reattaching tinymce unneccessarily.
      fix null named attributes issues on e.target when span (icons) instead of anchor is clicked.
      
      Change-Id: I2e5218c040f8a9e252f785165ce9c566ecc2f56e
      Signed-off-by: default avatarLisa Seeto <lisaseeto@catalyst.net.nz>
      be7af61f
  13. 17 Jul, 2019 1 commit
  14. 04 Apr, 2019 1 commit
  15. 26 Feb, 2019 2 commits
  16. 30 Sep, 2018 1 commit
  17. 06 Sep, 2018 1 commit
  18. 31 Aug, 2018 1 commit
  19. 09 Aug, 2018 1 commit
    • Robert Lyon's avatar
      Bug 1785938: Fixing gallery and changing slimbox2 to fancybox3 · 66e7468a
      Robert Lyon authored
      
      
      Things done with this patch:
      
      1) Changed the 'Use photo frame' option from being a plugin variable
         to being an instance config variable
      
      2) Added back in the css for the giving the gallery images photo frame
         borders
      
      3) Get the non-square thumbs to render correctly spaced on load
      
      4) Swapped the slimbox2 to fancybox3 and allowed the block itself to
      control when to put content into head data
      
      behatnotneeded
      
      Change-Id: I397be45f2347588988b663b25b560d8ab876afe1
      Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
      66e7468a
  20. 07 Aug, 2018 1 commit
    • Cecilia Vela Gurovic's avatar
      Bug 1741987: Update jquery - Events · 3d1abcc2
      Cecilia Vela Gurovic authored
      Event
         Breaking change: .load(), .unload(), and .error() removed
         Breaking change: .on("ready", fn) removed
         Breaking change: event.pageX and event.pageY normalization removed
         Breaking change: jQuery.event.props and jQuery.event.fixHooks removed
         Breaking change: Delegated events with bad selectors throw immediately
         Deprecated: .bind() and .delegate()
           no calls to .bind() for events in core.
           Only calls to bind() refer to the js bind of arguments to functions.
           no calls to unbind() for event in core.
           Only calls to unbind refer to the unbind method defined in
           formChangeManager not related to the jQuery method.
      
          Warnings fix
          JQMIGRATE: jQuery.fn.click() event shorthand is deprecated
          - also applies to the other event shorthands, including:
           blur, focus, focusin, focusout, resize, scroll, dblclick, mousedown,
           mouseup, mousemove, mouseover, mouseout, mouseenter, mouseleave,
           change, select, submit, keydown, keypress, keyup, and contextmenu.
      
          JQMIGRATE: jQuery.fn.hover() is deprecated
          JQMIGRATE: jQuery(window).on('load'...) called after load event occurred
      	(for FileBrowser we can see this error when editing a block in a page)
      
      behatnotneeded
      
      Change-Id: I1a50050f882b864ad63d273de160e0b441a77705
      3d1abcc2
  21. 09 Jul, 2018 1 commit
    • Cecilia Vela Gurovic's avatar
      Bug 1779600: removing slideshow.js · dd7ca4d4
      Cecilia Vela Gurovic authored
      This js file was loaded when calling
       function get_instance_javascript() in
       artefact/file/blocktype/gallery/lib.php
      
      The line that included that file was removed when adding bootstrap
      There are no calls to the only function defined in slideshow.js,
      I think is safe to remove the file.
      
      behatnotneeded
      
      Change-Id: Iddcc6419a06cfccebdd3d243680ee653fd5cae2d
      dd7ca4d4
  22. 15 May, 2017 1 commit
    • Son Nguyen's avatar
      Bug 1575512: Better way to check if a page is ready for behat tests · f27e5ebf
      Son Nguyen authored
      Add JS event handlers for
       - pieforms
       - tinyMCE editor
       - bootstrap
      to detect when a page is ready after a behat test step
      
      Refactor behat tests .feature files
       - remove redundant steps I wait
       - replace the step I set the field ...
         by the faster step I fill in ...
         for regular text inputs
      
      Change-Id: I0ce4cc8dc32f228a648cfee608ec60ed917b7774
      f27e5ebf
  23. 25 Jan, 2017 1 commit
  24. 18 Oct, 2016 1 commit
    • Cecilia Vela Gurovic's avatar
      Bug 1181696: Reorder images in gallery when renaming files · 8662adc9
      Cecilia Vela Gurovic authored
      Check the filename when displaying an image gallery
      and show images in alphabetical order.
      The same ordering function is used as the Content/files
      view when displaying the files.
      This can be easily undone when bug 732462 is fixed.
      
      behatnotneeded
      
      Change-Id: I795e4f606e570f0088a21a4404fbf8a4c5249998
      8662adc9
  25. 01 Aug, 2016 1 commit
    • Jono Mingard's avatar
      Purge MochiKit from mahara.js (Bug #1323920) · 174ca581
      Jono Mingard authored
      Replace all MochiKit function calls with either jQuery or rewritten
      versions. Also remove some old functions which aren't needed or
      weren't being used
      
      behatnotneeded: should be functionally identical
      
      Change-Id: Ie48032009b14adddfecbe8c381f4ff692afafe70
      174ca581
  26. 21 Jul, 2016 1 commit
  27. 15 Jul, 2016 1 commit
  28. 11 Jul, 2016 1 commit
  29. 23 Mar, 2016 1 commit
  30. 25 Nov, 2015 1 commit
  31. 24 Nov, 2015 1 commit
    • Aaron Wells's avatar
      Display icons for 3rd-party blocktypes plugins · 4f849ed2
      Aaron Wells authored
      Bug 1510421
      
      Defines a new static PluginBlocktype method, get_css_icon(), which
      fetches the name of the CSS icon to use for this blocktype. It returns
      false by default, which tells the theme to "fall back" to the old
      thumbnail.png instead. 3rd-party plugins can override this to
      specify a particular icon to use.
      
      All the core blocktypes have been refactored to extend
      MaharaCoreBlocktype, which uses the blocktype name as the name
      of the CSS icon to use. I also deprecated the "SystemBlocktype"
      class while I was at it.
      
      PluginBlocktype::get_blocktypes_for_category() now returns both
      the results of get_css_icon() and the thumbnail.png path, so that
      themes can decide which they want to use. (And of course
      thumbnail.png is served via thumbnail.php, so 3rd party themes
      can provide their own custom image files if they wish.)
      
      behatnotneeded: Requires installing third-party plugins to test
      
      Change-Id: Idb1ecfc7b21175913708e695788906c11133b0c0
      4f849ed2
  32. 07 Oct, 2015 1 commit
  33. 08 Sep, 2015 2 commits
  34. 30 Jul, 2015 1 commit
  35. 15 Jul, 2015 1 commit
  36. 01 Jul, 2015 1 commit