1. 16 May, 2021 1 commit
    • Doris Tam's avatar
      Bug 1911824: Change the copy setting for artefact annotation to 'nocopy' · d31993dd
      Doris Tam authored
      Check that $evidences exist in case there exist evidenviews but no evidence blocks to copy
      
      if the only block on a view is an annotation block, then make a check to not get the sql to run copies
      which will result in error as there are no artefacts to copy.
      
      Change-Id: Ie914704046c2396a2fedce958cef3a44dd28ae33
      (cherry picked from commit cba39269)
      d31993dd
  2. 01 Mar, 2021 1 commit
    • Gold's avatar
      Bug 1916833 - Annotation can be updated on a page · 690edccd
      Gold authored
      Config gear icon removed from the Annotation blocks.
      In order to still initially create these when added we needed to check
      if the Block was a new instance or not. To achieve that we are now
      passing the block instance into the has_instance_config() method.
      
      BlockInstance has been extended and will set a 'new' parameter if the ID
      in the constructor is 0.
      
      AuthPlugin* classes also have the has_instance_config(). These do not
      need the BlockInstance passed in.
      
      Change-Id: Ifac69fc1d48b45c079b6f66e610776cead3dee63
      690edccd
  3. 24 Feb, 2021 1 commit
  4. 09 Oct, 2019 1 commit
  5. 25 Sep, 2019 2 commits
    • Lisa Seeto's avatar
      Bug 1827811: Resume Icons · 953a5eab
      Lisa Seeto authored
      
      
      - get attachment comment counts for bh icons
      - display plain text for titles in editing mode
      - change the way the commentlink is targetted via js
      - add blockid's to resume attachments
      - for folder block: add comment count, change titles from
      	links to plain text when editing
      - change notes attachment file titles from links to plain
      	text when editing
      - get rid of the single artefact block title links for html exports
      ---------------------------------------------------------
      Add fixes:
      - blocks that have set types but no artefacts attached don't have modal links
      - pdf block is now using block header and comment count is loaded
      - block headers are above titles
      - tagged journals have icons when in full and matches recent posts styling
      - deleting all comments produces correct icon on block header
      - html exports should not hang on opening modal
      - get rid of warning error re: dock.show() when redirecting from &modal=1 style url
      - code review fixes for all previous patches + fix issue with folders block
      - added in viewdetailsfilter.json.php file to save details mode to user account prefs table
      - make the details btn mode "sticky" so it stays the save value over multiple pages etc...
      - Image Gallery blocks: if displaying a folder of images will get the bar block header and
      will have a the fancy box image preview displaying on image click
      
      Change-Id: I425cc5a634e176d580aacdb60a20f869f7cb7496
      Signed-off-by: default avatarLisa Seeto <lisaseeto@catalyst.net.nz>
      953a5eab
    • Lisa Seeto's avatar
      Bug 1827811: Embedded Media Task · b82df03d
      Lisa Seeto authored
      
      
      add the block-header to the block.
      remove the download link from page as it now shows in the modal.
      add artefactid and blockid to image.tpl
      fix issue with data-toggle collapse targeting syntax error.
      update  active block functionality for block headers
      update block-comments-details-header.tpl for icon headers
      fix Journals, and tagged entries and recent posts to use icons for block header.
      change pdf block to use block header icons
      clean up .comments-details class that is no longer needed.
      add modal functionality for image gallery blocks for thumbnails and thumbnails square presentation.
      add modal functionality for some html block, clear up js for icons that is no longer needed.
      add title text to icons and block-header
      create activateModalLinks() func to tidy up js modal click events in view/view.php
      
      Change-Id: Ib5967d44288557ef4d380eb99241e8442da90f29
      Signed-off-by: default avatarLisa Seeto <lisaseeto@catalyst.net.nz>
      b82df03d
  6. 25 Aug, 2019 1 commit
    • Lisa Seeto's avatar
      Bug 1838483: support .wav and .m4a for embedded media · 4681451f
      Lisa Seeto authored
      
      
      added the .wav and .m4a files to the plugin administration list of file types for internal media
      added new string for m4a audio file
      clean up artefact_file_mime_types to change m4a, m4b, m4p and m4r files to be audio/mp4
      perform upgrade to update existing files to have the new mimetype
      
      Change-Id: I6940c249cd715cfc373c1e0881a86da9c86a2e1b
      Signed-off-by: default avatarLisa Seeto <lisaseeto@catalyst.net.nz>
      4681451f
  7. 26 Feb, 2019 1 commit
  8. 12 Feb, 2019 1 commit
  9. 30 Sep, 2018 1 commit
  10. 31 Aug, 2018 1 commit
  11. 14 Aug, 2018 2 commits
  12. 03 Sep, 2017 1 commit
  13. 12 Dec, 2016 1 commit
  14. 02 Sep, 2016 2 commits
  15. 15 Jul, 2016 1 commit
  16. 14 Apr, 2016 1 commit
  17. 31 Mar, 2016 4 commits
  18. 16 Dec, 2015 2 commits
  19. 24 Nov, 2015 1 commit
    • Aaron Wells's avatar
      Display icons for 3rd-party blocktypes plugins · 4f849ed2
      Aaron Wells authored
      Bug 1510421
      
      Defines a new static PluginBlocktype method, get_css_icon(), which
      fetches the name of the CSS icon to use for this blocktype. It returns
      false by default, which tells the theme to "fall back" to the old
      thumbnail.png instead. 3rd-party plugins can override this to
      specify a particular icon to use.
      
      All the core blocktypes have been refactored to extend
      MaharaCoreBlocktype, which uses the blocktype name as the name
      of the CSS icon to use. I also deprecated the "SystemBlocktype"
      class while I was at it.
      
      PluginBlocktype::get_blocktypes_for_category() now returns both
      the results of get_css_icon() and the thumbnail.png path, so that
      themes can decide which they want to use. (And of course
      thumbnail.png is served via thumbnail.php, so 3rd party themes
      can provide their own custom image files if they wish.)
      
      behatnotneeded: Requires installing third-party plugins to test
      
      Change-Id: Idb1ecfc7b21175913708e695788906c11133b0c0
      4f849ed2
  20. 22 Oct, 2015 1 commit
  21. 19 Oct, 2015 1 commit
  22. 23 Sep, 2015 1 commit
  23. 22 Sep, 2015 1 commit
  24. 08 Sep, 2015 1 commit
  25. 15 Jun, 2015 3 commits
  26. 27 May, 2015 1 commit
  27. 07 May, 2015 1 commit
  28. 15 Apr, 2015 1 commit
    • Robert Lyon's avatar
      Stopping SWF files XSS exploitation (Bug #1190788) · 8df9bdfa
      Robert Lyon authored
      By doing two things:
      
      1) Getting the embedded SWF object to set the
       allowscriptaccess = "never" and allownetworking = "never"
      
      2) By forcing a 'download file' link to actually download file
      - this goes for all files now that don't have embedded=1
      in their url.
      
      I've done it this way, having the embedded item have extra url param
      so that if a user tries to manipulate a url by removing params it
      will default to force download.
      
      I've merged the changes I'd done here https://reviews.mahara.org/#/c/3522/2
      
      
      and I've also cleaned up places where the download=1 was used as that is
      not needed now. Now if there are places where we need to embed rather
      than download we add the embedded=1 to the url.
      
      Change-Id: If5290a7c571d06d4178ef2ae5c4c09ed287403b4
      Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
      8df9bdfa
  29. 30 Mar, 2015 1 commit
  30. 12 Mar, 2015 1 commit
  31. 05 Feb, 2015 1 commit