GitLab

Alexander Del Ponte authored Jul 26, 2019 and Robert Lyon committed Oct 02, 2019

The plans are extended to allow for the creation
of template plans in the personal portfolio area.
These templates can then be used to create plans
in many groups for students to copy into their own
portfolio area and complete as assignments.

behatnotneeded: To come later

Change-Id: Ifbdf70541c0a0a254af3cbb9390d883a60e591d0

Evonne authored Sep 11, 2019 and Robert Lyon committed Sep 27, 2019

Inside a plan block when there are more than two plans, the second
plan's heading overlaps the first plan. Fix puts in a clear both
in the div.

behatnotneeded

Change-Id: Ic7bbda42df5d2f5edb4f6aec3ea764b884fc8e37

Evonne authored Sep 11, 2019 and Robert Lyon committed Sep 27, 2019

Removed gray border override for retractable blocks so theme's
border colour can show instead.

behatnotneeded

Change-Id: Idee562cb6fc248d963801b2dd615f2e3827a630f

- get attachment comment counts for bh icons
- display plain text for titles in editing mode
- change the way the commentlink is targetted via js
- add blockid's to resume attachments
- for folder block: add comment count, change titles from
	links to plain text when editing
- change notes attachment file titles from links to plain
	text when editing
- get rid of the single artefact block title links for html exports
---------------------------------------------------------
Add fixes:
- blocks that have set types but no artefacts attached don't have modal links
- pdf block is now using block header and comment count is loaded
- block headers are above titles
- tagged journals have icons when in full and matches recent posts styling
- deleting all comments produces correct icon on block header
- html exports should not hang on opening modal
- get rid of warning error re: dock.show() when redirecting from &modal=1 style url
- code review fixes for all previous patches + fix issue with folders block
- added in viewdetailsfilter.json.php file to save details mode to user account prefs table
- make the details btn mode "sticky" so it stays the save value over multiple pages etc...
- Image Gallery blocks: if displaying a folder of images will get the bar block header and
will have a the fancy box image preview displaying on image click

Change-Id: I425cc5a634e176d580aacdb60a20f869f7cb7496
Signed-off-by: Lisa Seeto <lisaseeto@catalyst.net.nz>

Fixing alignments and hover/active states for assessment buttons.

behatnotneeded

Change-Id: I8774ecc53d5d3744f1e4e0b6debf2e6476e71ce8

The change is for making sure the styling is working for the blocks.

* make file(s) to download use bh icons, metadata on new line
* resume attachments to use icons (buggy but apparently necessary)
* show file(s) to download titles on hover over link
* get rid of '-' for file metadata for size etc...
* fix the editing/display descrepancy of tagged/recent posts titles

Change-Id: Iad7bb30944f5924b43eca96993e3334120076c05
Signed-off-by: Lisa Seeto <lisaseeto@catalyst.net.nz>

add the block-header to the block.
remove the download link from page as it now shows in the modal.
add artefactid and blockid to image.tpl
fix issue with data-toggle collapse targeting syntax error.
update  active block functionality for block headers
update block-comments-details-header.tpl for icon headers
fix Journals, and tagged entries and recent posts to use icons for block header.
change pdf block to use block header icons
clean up .comments-details class that is no longer needed.
add modal functionality for image gallery blocks for thumbnails and thumbnails square presentation.
add modal functionality for some html block, clear up js for icons that is no longer needed.
add title text to icons and block-header
create activateModalLinks() func to tidy up js modal click events in view/view.php

Change-Id: Ib5967d44288557ef4d380eb99241e8442da90f29
Signed-off-by: Lisa Seeto <lisaseeto@catalyst.net.nz>

This change adds modal functionality for folders and nested folders
add javascript to the folder_render_self template.
add new class to make space between icon and title/ metadata in modals
fix blockid warning message error
added folder_render_in_modal.tpl to fix duplicate js script issues interferring with js events
creaeted toggleDetailsBtn() to handle js issues
get rid of old style comments link from showing up.
turn off click functions so json sendrequest doesn't call a billion times.
explicitly call dock.show() in the open_modal func.

Change-Id: I938f98c33479a80afc8f940038ed81a3c84ce4ff
Signed-off-by: Lisa Seeto <lisaseeto@catalyst.net.nz>

This change cleans up the last of the redirects to artefact/artefact.php
Update the links for the journal and journal entries for elasticsearch to go to blog
Update the links for the journal and journal entries in consideration of new reqs
Update artefact/artefact with session msg + access denied error

Change-Id: Ied34542632bd4e49a353ec17937d685614117643
Signed-off-by: Lisa Seeto <lisaseeto@catalyst.net.nz>

This change creates the modals for exported html pages.
Modals are hard-coded onto page with id's of modal_[artefactid]
Bootstrap and jquery files are copied into export js folder.
Profile page is also exported with any modal content.
Add tagged posts modals
get rid of export warning when no $commentcount set in viewposts.tpl
Add recent posts modals so that first journal post was also a modal
Set Parent journal link text to plain text for exports
Add entire resume modals and one resume field modals
Add File(s) to download modals
refactor export_artefact_metadata_modals
add metadata but not comments to resume page
add metata (license info) but not comments to journal pages
add comment count default to 0 in .tpl's if comment count not present (during export)
remove updating comments modals for profile page as this is no longer needed.

Change-Id: Iff50138285951a4f9a1573423f4f74feba97886f
Signed-off-by: Lisa Seeto <lisaseeto@catalyst.net.nz>

do not show note contents when displayed in a modal.
if comments not allowed but license metadata is on, display details link and open model with license data.
make small change to setting of licensemetadata smarty variable
get rid of comments/details links and use the new block header instead.

Change-Id: I9183292278d06a3766ae08b0376237fda8d7206c
Signed-off-by: Lisa Seeto <lisaseeto@catalyst.net.nz>

added the modal_link for resume field attachments
fixed the modal)link typo in employmenthistory template
update commentlink to modal_link for goals and skills template

Change-Id: I8b203628dc47d7019ee75165cb11bc392ddefa03
Signed-off-by: Lisa Seeto <lisaseeto@catalyst.net.nz>

behatnotneeded

The plan block's 'details' link will only display if license metadata is available.
The link will open the modal with licensing information.
Update how the licensemetadata is set in smarty variable.
remove old details link and use new block header instead.
remove the use of modal functionality, block headers & smarty vars

Change-Id: I5f06d9ba84ff018a50ba774763be3fcede9b2576
Signed-off-by: Lisa Seeto <lisaseeto@catalyst.net.nz>

Journal changes:
Change the modal contents to not show post contents or attached files.
Recent posts and Tagged posts (if not in full display) now expandable with post contents and comment links.
Attached files on page block now links only to download and not to display further metadata.
Cleaned up artefact.php links.
remove metada that will show on entry on page from also showing in modal
stop background page scrolling when the modal is opened and "Advanced licensing" is selected.
add the blogpost_render_in_modal.tpl file
get rid of scrolling for data-toggle collapse
add block-header to journal, journal entry
add titles as modal links for recent posts and tagged journal entries
add comments and details icons for recent posts and tagged journal entries
fix things from code review

behatnotneeded

Change-Id: Ic63ebf9fe42e7848559b5e009584fdff0a40770f
Signed-off-by: Lisa Seeto <lisaseeto@catalyst.net.nz>

create modal using configureblock id, update various templates to use the modal for blocks:
Image
Note
File(s) to download
Journal/blogs
add JS to open/close modal, add comments, delete comments, reply to comments, paginate comments.
add JS to handle url that redirects to view/view.php with modal open and populated.
Further changes to each block will be completed in child patches.
Add segment headings to the modal. Fix display of comments to cover width of modal.
Show comment removed msg in modal/page appropriately.
Fix behat test to close modal before continuing.
do not show existing comments if comments not allowed on artefact.
add validation to modal for comments/attachments
disable image as link when editing for image block
trigger focus on modal for accessibility
close modal on escape keydown event
fix merge conflict in view/view.php
fix merge conflict with master
make configureblock modal play nicely when comment block is on the page
update display of error messages to always show at top of modal so user doesn't have to scroll
add accesibility to close modal on escape key down
handle dock show/hide events for paginated pages in modal during validation
create block-comments-details-header template file
create details button and custom scss file with js to show and hide header
update comment links to save add comment and details when commentcount == 0
add active-block class to colour the block-header when active
toggle the details-btn active css
add _block-comments-details-header.scss to patch
change class invisble to class d-none
add block-comments-details-header.tpl to blocktypecontainerviewing.tpl
code review changes
add .no-modal class to links on group home page, dashboard and profile page.
add block header to appear above the title
change assessbtn from anchor tag to button to prevent scrolling.
make all clickable links clickable on page load (ignore assess mode)
fix js issues surrounding assessbtn move and show/hide blocks
change cursor on dashboard, my profile page, group homepage to default when over disabled modal links
update assessbtn to details btn
create tooltip for hover over file download block titles
fix containerElm console log error by not reattaching tinymce unneccessarily.
fix null named attributes issues on e.target when span (icons) instead of anchor is clicked.

Change-Id: I2e5218c040f8a9e252f785165ce9c566ecc2f56e
Signed-off-by: Lisa Seeto <lisaseeto@catalyst.net.nz>

Evonne authored Sep 10, 2019 and Robert Lyon committed Sep 24, 2019

An issue with flex on IE11 where flex item has a max-width, the
fix sets the min-size in flex-basis to 0% instead of 25% so that
it grows to fit.

behatnotneeded

Change-Id: I719acbc6db578444d0621cb4f660cb2226d8960b

Making it a db_table_exists() call instead

behatnotneeded

Change-Id: I5206657a7e76a96dbe878147e07d42a241790764
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Robert Lyon authored Sep 04, 2019 and Cecilia Vela Gurovic committed Sep 20, 2019

Without needing to include the lib/ddl.php file, and create
the xmldb table objects

We do this by trying to query the table to return one value
and capture the SQLException if it doesn't exist

The places changed are where we don't manipulate the table - so have
left upgrade places the same as we will need to do things the ddl.php
way anyway

behatnotneeded

Change-Id: Ic38cee95a221a22e644370b308356cf687a1e831
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Robert Lyon authored May 03, 2019 and Cecilia Vela Gurovic committed Sep 20, 2019

Without needing to create the xmldb table / field objects

We do this by trying to query the column and capture the SQLException
if it doesn't exist

behatnotneeded

Change-Id: I0a15dd4d1d4e47e6650576c084ee9e1d36b4ae62
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Fix puts in the correct classes for the button styles to be displayed.

behatnotneeded

Change-Id: I2197e73a69be96d805f4196692496778173a8564

Robert Lyon authored Aug 29, 2019 and Kristina Hoeppner committed Sep 20, 2019

Change-Id: Ibcb5347254055002c0102dd3f62c4932c9ddefdb
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Mitsuhiro Yoshida authored Sep 09, 2019 and Robert Lyon committed Sep 20, 2019

behatnotneeded

Change-Id: Ie65a2da1c4a6dadb05fb46d00feefb39a09bd754

Lisa Seeto authored Sep 19, 2019 and Robert Lyon committed Sep 19, 2019

- put consent button in own div so it always displays
- add description as info text underneath the button
- change wording/ styling on modal buttons
- Added in newline for accountsuspended string as it wouldn't ignore the <br /> tag
- change name of confirm-no-button to suspend-account-btn for clarity

Change-Id: I1ca009a76b1b3243512f6b9658439c111f2b80f0
Signed-off-by: Lisa Seeto <lisaseeto@catalyst.net.nz>

Matt Clarkson authored Jul 11, 2019 and Robert Lyon committed Sep 19, 2019

Change-Id: Ib0a677db1b04b328f0e679cffa0c4d52fa52ecee

By making a fonttype mixin

behatnotneeded

Change-Id: I4f0938795c3b5f8ab93751915227d0c5370ba48f
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

When on a small screen, the add blocks button in the floating
menu on edit page has a gap on the right. Fix adds 100% to the
button and its wrapper so it will fill up the space just like
the buttons below it.

behatnotneeded

Change-Id: Ia20003a4a8115ac6edae5a1d4ac8a4e00557c2de

Some pages like user profile page where there the content is short,
the previous patch made the content vertically center in the
main-content div. This fix gives the div flex: 1 to tell it to not
do that.

behatnotneeded

Change-Id: I4f8951d799fdbfcb397e46e99592f3f6bd13347e

selected

changed the 'id' to use the display tag.
updated the call to display_tags to not show count

behatnotneeded

Change-Id: Ibac85aedb783c2a83e230842de560e2c67e5827e
Signed-off-by: Lisa Seeto <lisaseeto@catalyst.net.nz>

Kristina Hoeppner authored Sep 12, 2019 and Kristina Hoeppner committed Sep 16, 2019

Fixed the spacing in the notification to make it
more consistent with other mails.

Also fixed the subject where only "page" or "collection" was shown and
thus we don't need the quotation marks.

behatnotneeded

Change-Id: I5403c70dab8fed11718071573c1bc525ada4a768

Evonne authored Sep 10, 2019 and Robert Lyon committed Sep 13, 2019

Put in class card-body for external media video block to add the
space and be consistent with other blocks.

behatnotneeded

Change-Id: I164ecff8b2505a5f5e393ff623dff4512f296345

Evonne authored Sep 10, 2019 and Robert Lyon committed Sep 13, 2019

The small Mahara logo now appears at the smallest breakpoint at 480px 

Also fixed the placement of the user profile icon in the header so
that the image sits away from the border and more centre-aligned
within the toggle.

behatnotneeded

Change-Id: I085590cb5734124a91ee50b063448102943387f2

Evonne authored Sep 06, 2019 and Robert Lyon committed Sep 11, 2019

Fixes so name isn't covered by a person's profile picture in th profile
side bar block when the name is long. 

Also fixed the "Default" theme where the colour of the block
header fits the profile picture better.

behatnotneeded

Change-Id: I1b8f8b2e113156399ac6b3d7a7c032097acee0e2

Evonne authored Sep 10, 2019 and Robert Lyon committed Sep 11, 2019

Reverted commit c9b82dcd
because it has conflicts with z-index negatives. This fix uses flex
to push footer down to bottom of short pages. Note this fix does
not work on IE11, there the normal footer position is used.

behatnotneeded

Change-Id: I03db6217a235a99191685bda75acaa0dbc9deae0

Evonne authored Sep 10, 2019 and Robert Lyon committed Sep 10, 2019

On My tags page, the link next to "Search results for" is not
clickable due to the Edit this tag button floating on top of it
in a transparent layer. Fix give the button group a margin-left
to move it away from the search title. Both the link and the edit
button (sometimes doesn't display) should now be clickable.

behatnotneeded

Change-Id: Idecfbaaf8965b1908a8b6edd3c3300b36da33929

Evonne authored Sep 10, 2019 and Robert Lyon committed Sep 10, 2019

Fixes for first button in button group that appear to have all four
corners rounded rather than just the left ones. Fixes placement of
button group on style guide sitting above the box.

behatnotneeded

Change-Id: I06e19a3633e2692ee6a8f97b13be7751833356af

Evonne authored Sep 06, 2019 and Robert Lyon committed Sep 10, 2019

Fixes short pages where footer colour stops in a strip rather than
extend to the bottom of the browser window.

behatnotneeded

Change-Id: Ia5968cf0f6926c89a83ed89f3b6bcd196327923c

Evonne authored Sep 06, 2019 and Robert Lyon committed Sep 10, 2019

Replacing manually entered values for border-radius to use bootstrap
variable. Visually nothing should be different, just easier long term
maintenance.

behatnotneeded

Change-Id: I68aeb998cd43f3a9c7b1b9b770d6d30a20612c63

when creating a block, run through all the tags and if
they match institution style tag, then construct the tag
with the institution display name and the tag.

behatnotneeded

Change-Id: If6b92d1c2d993368f057f1b6c71354ce6d8cbb3c
Signed-off-by: Lisa Seeto <lisaseeto@catalyst.net.nz>

So that we only try and save the new block one time

behatnotneeded

Change-Id: I6dd1fbe0bcaf98c37db7ee601198efa108867970
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Evonne authored Sep 06, 2019 and Kristina Hoeppner committed Sep 09, 2019

Fixes list-group-item-text background from white to transparent.
An example of where this appears is in the "Latest changes I can view"
block. The page description had a white background, which did not look
good as there shouldn't have been a background.

behatnotneeded

Change-Id: Ib5b08d1a49b6c22458fbf8e0dfe846a00920ff22