Skip to content
GitLab
Switch branch/tag
  1. 26 May, 2016 1 commit
  3. 11 Apr, 2016 1 commit
  5. 21 Mar, 2016 1 commit
    • Robert Lyon's avatar
      Bug 1539262: Removing unnecessary $smarty PAGEHEADING lines · e82c0fcb
      Robert Lyon authored 
      

As they are set to TITLE we can just assign TITLE to PAGEHEADING in
the smarty function call.

We can later override the PAGEHRADING with
$smarty->assign('PAGEHEADING', string); if we need to.

Have also updated a few files where TITLE was not defined.

behatnotneeded - everything should work as before

Change-Id: I3ea592cd37344e68c6e90a3c64947cf99db59471
Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
      e82c0fcb
  7. 23 Feb, 2016 1 commit
  9. 16 Dec, 2015 2 commits
  11. 20 Nov, 2015 1 commit
    • Hugh Davenport's avatar
      Fix behaviour on submitting multiple pages to Moodle · fd9f1f82
      Hugh Davenport authored and Aaron Wells's avatar Aaron Wells committed 
      Bug 1516823

The moodle plugin for mahara assignment submissions [1] had an issue [2]
where is the plugin was configured in non locking mode, multiple
submissions of the same view would result in only the latest submitted
link working.

This was due to the page getting locked then released, which resulted in
a new mt token, which made all the old ones not work. This patch changes
that by accepting a new parameter which checks whether you are locking
and if not, then don't generate and send a token back.

When viewing a view, check for the new parameter mnetviewid or mnetcollid
along with the parameter assignment. If these are present, then Mahara
sends an MNet request back to Moodle which tells Mahara whether the user
has the permission to view the page.

This requires an update to the Moodle plugin, which is sent for review
currently [3]. Mahara detects whether this plugin is upgraded and
publishing the new MNet function. If it isn't, it falls back to original
behaviour gracefully. This is done by attempting to send a MNet request.

[1] https://github.com/MaharaProject/moodle-assignsubmission_mahara
[2] https://github.com/MaharaProject/moodle-assignsubmission_mahara/issues/2
[3] https://github.com/MaharaProject/moodle-assignsubmission_mahara/pull/19

behatnotneeded: Can't yet test MNet issues in Behat

Change-Id: I80739181b58bf7cf9c326e7b0a588b6239f864f1
      fd9f1f82
  13. 19 Oct, 2015 1 commit
  15. 27 Sep, 2015 1 commit
  17. 24 Sep, 2015 1 commit
  19. 21 Sep, 2015 1 commit
  21. 16 Sep, 2015 1 commit
    • Robert Lyon's avatar
      Bug 1486763: Now deleting correct comment · 6da147c1
      Robert Lyon authored 
      

Was a problem with the old delete button being an image and so passed
the _x value, which was then checked for.

Changed it so it checks that the submit param exists, which is more
robust

behatnotneeded : problem of finding the row that you just deleted as
all deleted rows have the same 'Comment removed by the author' text

Change-Id: Iea379badd2d364112d107977b8f53a62ac272428
Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
      6da147c1
  23. 20 Aug, 2015 1 commit
  25. 17 Aug, 2015 1 commit
  27. 30 Jul, 2015 2 commits
  29. 20 Jun, 2015 1 commit
  31. 15 Jun, 2015 7 commits
  33. 31 Mar, 2015 1 commit
  35. 26 Mar, 2015 1 commit
  37. 26 Feb, 2015 1 commit
  39. 25 Feb, 2015 1 commit
  41. 05 Feb, 2015 1 commit
  43. 16 Dec, 2014 1 commit
  45. 16 Nov, 2014 3 commits
  47. 05 Nov, 2014 1 commit
  49. 18 Sep, 2014 1 commit
    • Robert Lyon's avatar
      The archiving of submitted pages/collections from groups (Bug #1335670) · 5c57b565
      Robert Lyon authored 
      

This patch contains:
- The export queue system where pages/collections on release from
submission are added to the export queue table ready to be archived.
- The export queue admin page showing what is in the queue to be
exported. The cron runs every 6 minutes. Queue items failed to export
are also shown here.
- The archive list admin page, where one can download the generated
leap2a files for the archived submissions.

In this patch you should be able to add things to the export queue by
either releasing a sumbission on a group that has 'archive
submissions' option ticked. This will add the archive to that archived
submission page, or you can also run a leap2a export from portfolio
export which will add the export queue and send you an email once the
export is done.

Things to note:
- The is a server busy function that stops the export queue from
running but I'm not too sure if the threshold is too low/high
- The export queue tries to export the first 100 items each run but if
resources are fine in handling that easily then the number could be
higher but I'm not sure of what will be a good number.
- Currently there is alsoe infrastructure like table columns for dealing
with releasing submissions from external systems (eg moodle) but that
functuionality is yet to be built.
- The checking of server busy in MS windows untested - may need to
just let MS ignore server busy check as there doesn't seem to be
standard way to check this.

Change-Id: If4c1d272e9c5d46fbf16b2ff73ceb2687c06ffd4
Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
      5c57b565
  51. 16 Sep, 2014 1 commit
    • Nigel Cunningham's avatar
      (Bug548021) Add support for anonymising pages. · 9624d430
      Nigel Cunningham authored 
      

This patch adds support for anonymising pages.

It creates a site option in the General Settings section named 'Allow
anonymous pages' that must be checked for any page to be anonymised.

If the site option is enabled, a new 'Anonymise' setting in the
'Edit title and description' tab of pages is enabled, allowing the owner
to request that this page be anonymised.

When both settings are enabled and a user views a page, two things may
happen to the author's information.

First, if the user is not logged in or does not have admin, staff or
owner privileges for the page, the author's name is replaced by the
anonymous text (defaulting to "(Author's name hidden)") in both the
body of the page and the metadata author field.

If the user does have admin, staff or owner privileges for the page,
the author's name is anonymised as above except that the text displayed
is made into a link. When this link is clicked, the anonymous author
text is replaced by the normal author information for the page.

Anonymous pages displayed in the 'Latest pages' block and shared with
a group are also anonymised by this patch.

Change-Id: I2e2c92f641329a1a305cf58a5c5d47bf95436a8b
Signed-off-by: default avatarNigel Cunningham <nigelc@catalyst-au.net>
      9624d430
  53. 24 Jul, 2014 1 commit
  55. 16 Jul, 2014 1 commit
  57. 22 Apr, 2014 1 commit
  59. 16 Apr, 2014 1 commit
    • Yuliya Bozhko's avatar
      Move objectionable forms from view library (Bug #1298646) · 2df0d557
      Yuliya Bozhko authored 
      

So that we can later use them separately for artefact level access,
and report artefacts separately from pages.

When testing, everything should work as it worked before with
reporting objectionable material.

Also fixed "Creating default object from empty value" error
when ActivityTypeObjectionable object is constructed.

Change-Id: I6d95a5546b2425d9b522435da26902e420139d84
Signed-off-by: default avatarYuliya Bozhko <yuliya.bozhko@totaralms.com>
      2df0d557