GitLab

The old ones based on lang strings

behatnotneeded - can't test dataroot

Change-Id: I08963fd73f2d2102c9c34535593e8afb50b6104b
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Robert Lyon authored Oct 06, 2016 and Aaron Wells committed Oct 21, 2016

In case we have any missing studentid/preferredname artefacts if a
user was created with webservices before it was fixed

behatnotneeded

Change-Id: I520d580b5af496260d524ea9434aace41a22bcc1
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

behatnotneeded

Change-Id: I8f36fb267bfbd1a910e0c7f092c0e4cfe490ecdb

Change-Id: I4960f6f3102ea1386b1c6057a547edafdf0179b2
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

To hold the id of the smartevidence framework the collection is using

Defaults to null

behatnotneeded: to come later

Change-Id: Idb33e0d71adca8cc089f97aa48826e69e6f16fa8
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

This patch does a few things:

1. Renames "webservice_enabled" config to "webservice_provider_enabled",
to indicate that this config only controls Mahara's actions as
a webservice provider, *not* a webservice client.

2. Renames all the "webservice_<protocol>_enabled" configs to
"webservice_provider_<protocol>_enabled" to indicate that they only
control whether Mahara will provide webservices via that protocol,
and not whether Mahara will use that protocol as a client.

3. Renames "webservice_connections_enabled" config to
"webservice_requester_enabled", to clarify that this config
controls whether Mahara is allowed to request webservices
from external sources.

4. Updates language strings to make these changes clearer.

5. Rearranges and renames the form methods in
webservice/admin/index.php to make the flow of control more
obvious. Now the main form method is first, followed in order
by the methods that generate its subforms and each of their
submit handlers.

behatnotneeded: Covered by existing tests

Change-Id: I58dadb352d1f1542ca67a104ebfd702b4ca90fc9

And avoiding storing full path to dataroot temp dir in db for imported
entries

behatnotneeded

Change-Id: I18fb3a76accd57517e340ce98a19f7b10bd4814c
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

It turns out a lot of existing code checks the boolean
value of usr.suspendedcusr to determine if a user should
be treated as suspended or not. The LDAP sync cron (and,
indeed, any code suspending users via a cron task) was
setting usr.suspendedcusr to 0, which is boolean false,
so these users would be treated as not suspended.

We are going to update all usr.suspendedcusr = 0
to a valid site admin ID.

Change-Id: Iecfbfd8a4cdd98d5d07149bb40c64308262ea234
behatnotneeded: Test to come later

Robert Lyon authored Dec 18, 2015 and Aaron Wells committed Jul 25, 2016

This got added in 2010 via
commit 87a2c5f2



but we don't need it now, and will end up complicating the ability to
do views in multiple collections, so will remove

behatnotneeded  - existing tests should cover

Change-Id: Ie39a72442cae10727bf9f26ed86050e66e7df4bd
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
Signed-off-by: Aaron Wells <aaronw@catalyst.net.nz>

Part of the change is to remove duplicate view access rows as there is
no need to have duplicates of the exact same access for a view.

Adding the id to view_access will allow us to have different view
access for a view in multiple collections in the future

behatnotneeded - should be covered by existing tests

Change-Id: I8d3d6f0a011d0ed01a5ff2931e8e16d3000f4f16
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
Signed-off-by: Aaron Wells <aaronw@catalyst.net.nz>

Currently all the artefacts that save html/tinymce data do so in the
description field - except the internal profile introduction field.

Seen as we are already doing special handling of this plugin we might
as well save the html/tinymce data into the 'description' column of
the db for consistency sake.

behatnotneeded - existing tests should suffice

Change-Id: I68da79f1c9423e19218162d8315008134251c31f
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Piers Harding authored Mar 18, 2016 and Aaron Wells committed Jul 08, 2016

* added new client connection manager screens
* added client connection manager backend

behatnotneeded

Change-Id: Iac103616c7a9cd68cc94ea301a4cb808fe090669

Aaron Wells authored Jun 10, 2016 and Robert Lyon committed Jul 07, 2016

Not in use since Mahara 1.2.

Change-Id: I8aa24c11eb82a748465fc58eeadb4819061b8bcd
behatnotneeded: Covered by existing tests

Change-Id: I8ec8c26eb7bc8458e125aa0cc7ab0790657708a8
behatnotneeded: Can't test mnet in behat

And adding an institution selection to the Admin -> Group search

Also making sure that we can retain supplied shortname or throw error
if there is a clash

behatnotneeded

Change-Id: Ibbd6c05c1428e522c048b10c64389ebe3360473a
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

behatnotneeded

Change-Id: Ic5d4fbb3faa16afb893e45c5303449122c7cd368

behatnotneeded

Change-Id: Ib373e765d30a265f78944ef0066bc9895b3d68b9

Bug 1580499. Updating comments feature to adapt to the new
behavior, and removing redundant "feedback_configuration" feature
file.

Change-Id: Ib48cbb19f6ab9cc4937f31cef504724569680e1f

1. Add some documentation to session.php explaining what
the session.gc_maxlifetime ini setting does.

2. If we can't access $CFG->session_timeout, use a timeout of
an hour instead of the PHP default of 24 minutes.

3. Limit $CFG->session_timeout to 30 days, because we're already
enforcing that limit in session.php

4. Add "usr_session.mtime" column so that we can delete old sessions
based on inactivity instead of creation date.

5. Make the cron delete old session files as soon as they've expired,
rather than padding that an additional two days.

Change-Id: I9da2b26217774566b1131e997724359715edb2fe
behatnotneeded: Covered by existing tests

This patch does 2 things:
1) Changes all groupviews blocks on groups that allow group
submissions but don't have showsubmitted set to set it as true
2) When creating a new group that allows submissions to set the
showsubmitted = true at that time.

Change-Id: I8dbc7f9f4919fbb21aded3ff0f2637152b4d3480
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Son Nguyen authored Dec 08, 2014 and Robert Lyon committed Apr 27, 2016

- Change ownership of default system templates
 from user 0 to institution 'mahara'
 and set template to 2
- Enable to add site files into site templates

behatnotneeded - existing tests for system templates are ok

Change-Id: Idfd5fca423e6f6a5f66d6cf944f7c5f88112584c
Signed-off-by: Son Nguyen <son.nguyen@catalyst.net.nz>

Change-Id: Iaf073a9271ccd2402934dd25338600330dbce960
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Son Nguyen authored Mar 24, 2016 and Robert Lyon committed Mar 31, 2016

Allow loading openbadgedisplayer block via ajax.
Dynamically load badge groups from sources.
Cache badge details in database for one day if $fromcache is true.

behatnotneeded

Change-Id: I36c8054fd6daf7ca1fcf1fe3a22672c9eb009c6e

David Ligne authored Mar 22, 2016 and Robert Lyon committed Mar 29, 2016

behatnotneeded: Changes on database columns types only.

Change-Id: I0e80fe7b4ca7552c854f3496db6496e984bbdd53

Aaron Wells authored Mar 17, 2016 and Robert Lyon committed Mar 23, 2016

Bug 1558361: TinyMCE will filter them out on the editing
side, and HTMLPurifier will filter them out on the display
side.

behatnotneeded: Would require non-trivial new Behat step to
check whether links have "target" attribute.

Change-Id: If27462b2ca1a382ceeaadb374aade1f795f261bd

Robert Lyon authored Jan 27, 2016 and Aaron Wells committed Mar 16, 2016

As this is confusing debugging issues with view layout as the
view.numcolumns column is not actually used anymore for working
out the layout, but it's still being populated when a page is made.

behatnotneeded - existing tests will do

Change-Id: If90dff066201e7356601b08c9b7150cab8a77f45
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

As this is the preferred plugin for notifications now

Change-Id: I6ca49c863bb1cd9a8f3da891ebe2ab187c3d0a1e
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Due to a mistake in how blocks were ordered in the system

behatnotneeded - existing tests should be ok

Change-Id: Iac857c85d60e5948b6f95ddccee7a2e8cf43b1b4
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Some new countries, some split from Netherlands Antilles, some countries
changed their titles etc

Change-Id: I1ce8d31b8a75981a59546687cd395cc668d943c7
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Jean-Philippe Gaudreau authored Feb 12, 2016 and Robert Lyon committed Feb 24, 2016

In MySQL, the default "text" column size is 65kB. Because this column
can hold the serialized text from several other columns, it needs to
be larger than that. Setting it to "big" generates a "longtext", which
is 4GB.

This change has no effect in Postgres. Postgres has only one text
size (unlimited). The XMLDB generator is smart enough that it
recognizes this and doesn't run any SQL in this case.

behatnotneeded: Changes on database columns types only.

Change-Id: I2b72e840676cb7345561ef81d51846509bc04049

Dale Smith authored Jan 13, 2016 and Aaron Wells committed Feb 10, 2016

Bug 1534081

  * This alters the default allowed attributes for iframe and adds:
    - allowfullscreen
    - mozallowfullscreen
    - webkitallowfullscreen
    All are allowed 0, 1 or empty values.
  * This resolves issues with vimeo and youtube, who require these attributes before
    showing the fullscreen icon: https://developer.vimeo.com/player/embedding

behatnotneeded: Can't test Flash with behat

Change-Id: Ie57c3c3968c4f7cd58a544135351ef506aa6be11

Change-Id: Ib0de08d1ed51baa1f5e58ec1b805eacf034bb541

Bug 1526076: I believe the initial intent was that
Mahara core, and/or each plugin, could add a value
to its version.php file indicating "disablelogin"
true or false. And in this way, an upgrade could
indicate whether it was a small enough upgrade that
users did not need to log out for it.

However, in practice this is not practical because
we don't know what version of Mahara the user is
upgrading from, and that is what determines whether
or not it's a "stable" upgrade.

Additionally, the core disablelogin has been set to true
for the past 7 years, and the plugin disablelogin
setting no longer has any effect.

Removing disablelogin should hopefully make our
maze of init.php auth_setup() login stuff a little
bit easier to follow.

behatnotneeded: Covered by existing tests

Change-Id: I5f8a2b4faa95b9225bb926de6a54a622ea1a9618

Bug 1523499: Old wiki.mahara.org links without the "/wiki",
and HTTP links that should be HTTPS.

Also updated the installer release notes link to point to
the base "Release_Notes" page in the wiki, because we no
longer maintain separate wiki pages for each release.

behatnotneeded: Covered by existing tests

Change-Id: I02e80eb4d8df5adddee88e77156e8e103ca24c51

In MySQL, the default "text" column size is 65kB. Because this column
can hold the serialized text from several other columns, it needs to
be larger than that. Setting it to "big" generates a "longtext", which
is 4GB.

This change has no effect in Postgres. Postgres has only one text
size (unlimited). The XMLDB generator is smart enough that it
recognizes this and doesn't run any SQL in this case.

behatnotneeded

Change-Id: I0311bf9d25dba531ced72e6f74b8d5b2d317e745

... as decided during the developer meetings,
and reflected in the README

Change-Id: Ibe2f353f9ed1b7ed7680e37554f0ff21f6b8846c

behatnotneeded

Change-Id: I55734b2c42c5f67a0a324de306083b9e033394be

Son Nguyen authored Sep 07, 2015 and Robert Lyon committed Oct 22, 2015

Refactor updating embedded images

Deals with the deleting of embedded images in a:
- blog
- forum post
- forum topic
- group description
- note
- page description

Also sorts out the problem where a note embedded item can be saved
with both 'editnote' and 'textbox' resourcetype. We only need one.

Also add 'static' to EmbeddedImage::methods()

behatnotneeded

Change-Id: Ife1f9dee5ffe9eae4468eadb8f46a16a0a2a9044

- Add new column 'threadedposition' to table artefact_comment_comment
- Update the column for existing comments
- Calculate the position for new comments
- Display threaded commented using this for correct order
- Add a behat test

Change-Id: I607f26fccccee8f761754a41a21c6f58dd74cfb6

... to keep it higher than 15.10_STABLE starting version

Change-Id: I966ace990481652c3e4c8947b2a5692a8e760536