Commits · 6de718b7c55beef8d473b3c55b11114bbc5ac54e · mahara / mahara

17 Jul, 2019 2 commits

Bug 1835321: Manager can't see peer block when published · 6de718b7

Cecilia Vela Gurovic authored Jul 04, 2019 and

Robert Lyon committed Jul 17, 2019

WR#315075

Once the asessment is published by the author,
it'is supposed to be visible to everybody that
has access to the view

behatnotneeded

Change-Id: I116b665945a3d45fa2a14bb7654e55f561428368
(cherry picked from commit 7a2d6ce6)

6de718b7

Bug 1825274: Adding nowrap to subscribe/unsubscribe buttons · 36d0e94c

Robert Lyon authored Jul 17, 2019



So the stay on one line when in small screen mode

behatnotneeded

Change-Id: I6bce80396594ba00c62d929e8d78f65a283cf4ab
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 1cdec325)

36d0e94c

16 Jul, 2019 2 commits

Bug 1826940: Allow saving to external services log a valid auth value · 9f004185

Robert Lyon authored Apr 30, 2019



@TODO: Find out why it's trying to save the wstoken authentication token rather
than the value 'TOKEN'

behatnotneeded

Change-Id: Iecad50d41ef439b195ebf4ecd22e486092e4593e
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 31fbdf0b)

9f004185

Bug bug1836325: fix error with group search · 8f26dfc2

Ghada El-Zoghbi authored Jul 12, 2019 and

Robert Lyon committed Jul 17, 2019

If a group category is specified in the search,
it was failing due to incorrect order of values
passed to the SQL query.

Sponsored by The Australian National University

behatnotneeded

Change-Id: I53b822c16e9316d572b018c33f44deea53650845
(cherry picked from commit fa575209)

8f26dfc2

15 Jul, 2019 1 commit

Bug 1830278: Need to check we have access to view · e1f6ac6f

Robert Lyon authored May 21, 2019 and

Cecilia Vela Gurovic committed Jul 15, 2019



behatnotneeded

Change-Id: I06dd502550e6da7d66406990b9ac8e7ee94ccc17
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 50ba463a)

e1f6ac6f

08 Jul, 2019 1 commit
- Bug 1833390: Anchor hides behind header · 39b5238c
  anupamadharmajan authored Jun 25, 2019 and Robert Lyon committed Jul 09, 2019
```
behatnotneeded

Change-Id: I8ac2b4533b4116de12e9b2739b5c4a9374cab454
(cherry picked from commit 5d9fcca2)
```
  39b5238c
06 Jul, 2019 1 commit

Bug 1833034: fix error when removing an image · 07b3610f

Ghada El-Zoghbi authored Jun 27, 2019 and

Robert Lyon committed Jul 07, 2019

Sponsored by The Australian National University

behatnotneeded

Change-Id: If92710cc6c48d7f185f094ab84e2a6e136bfcfc0
(cherry picked from commit af07e62f)

07b3610f

25 Jun, 2019 1 commit
- Bug #1832665: SmartEvidence framework indenting not working on long headings · 4d6813eb
  Liam authored Jun 19, 2019 and Robert Lyon committed Jun 25, 2019
```
behatnotneeded

Change-Id: I4f51e3c6dbb2abbac165f14d99e9170afc72a2cc
(cherry picked from commit 469e8b53)
```
  4d6813eb
24 Jun, 2019 5 commits

Bug #1826801: Wrong link text color in "More options" page menu when link is active · 7535bc69
Liam authored May 01, 2019 and Robert Lyon committed Jun 24, 2019
```
behatnotneeded

Change-Id: Id912eb6b7d2b25216b29861a35c40d0eed77ebd9
(cherry picked from commit ac09a0e4)
```
7535bc69
Bug #1829091: config theme not picking up on some colours · 0676051b
Liam authored May 15, 2019 and Robert Lyon committed Jun 24, 2019
```
behatnotneeded

Change-Id: Ia2b1e0dee3fcbbd8379fa8f5ae8774619977765a
(cherry picked from commit 793c2191)
```
0676051b
Bug #1830798: Text is overlapping on "Edit access" · 503483e8
Liam authored May 29, 2019 and Robert Lyon committed Jun 24, 2019
```
behatnotneeded

Change-Id: I12e9b73c241aec82d7313fcf9575eb62812a6072
(cherry picked from commit 99015467)
```
503483e8
Bug #1830819: Edit dashboard button too low when not using an h1 heading · fe103483
Liam authored May 29, 2019 and Robert Lyon committed Jun 24, 2019
```
behatnotneeded

Change-Id: If1827b18ac8b398316be89546052847de73edeb6
(cherry picked from commit 66bb4859)
```
fe103483

Bug 1832308: Group setting and isolated institutions · 8f1eeb12

Ghada El-Zoghbi authored Jun 13, 2019 and

Robert Lyon committed Jun 24, 2019

The public setting on a group should not affect
the jointype.

Bring back original 18.10 functionality for
group settings page by:
* Removing the friends customisation.
* Removing affect of Public setting on other toggles.

Bring back original 18.10 functionality for who
can join a group:
* Users will be able to join the group on their own -
  if it is open - regardless of the isolatedinstitutions
  and public settings.

Please note for isolatedinstitutions:
Only site admins can create public groups.
It is up to the site admin to add users to groups
if they are set to public.
It is also up to the site admin to correctly set the jointype
for the group.
Therefore, for open groups, users can join the
group if it's in their institution.

Sponsored by The Australian National University

behatnotneeded

Change-Id: I0901f1ddf3b1c982dab0b3f4725755b6b0cdf5f2
(cherry picked from commit 53d7eb7a)

8f1eeb12

21 Jun, 2019 1 commit
- Merge "Bug 1785985: Offset the problematic cron jobs" into 19.04_STABLE · c25ef94f
  Robert Lyon authored Jun 21, 2019
  
  c25ef94f
20 Jun, 2019 3 commits

Merge "Bug 1817326: Modal in a Modal popup problem for editcomposite" into 19.04_STABLE · c7e4190f
Robert Lyon authored Jun 21, 2019

c7e4190f

Bug 1817326: Modal in a Modal popup problem for editcomposite · b8532ff6

Robert Lyon authored Jun 21, 2019



When closing the inner modal it removes a class from the <body> tag
causing the scrolling to break

behatnotneeded

Change-Id: Ic7d6678a6d69d57343678f1ca57e8fa2e00861e2
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 5bff19e5)

b8532ff6

Bug 1817326: Modal in a Modal popup problem · 594184f1

Robert Lyon authored Jun 21, 2019



When closing the inner modal it removes a class from the <body> tag
causing the scrolling to break

behatnotneeded

Change-Id: I9d132a91cd48500276951c24c0987b418daacb6e
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 9bd277e5)

594184f1

19 Jun, 2019 6 commits

Bug 1833325: Apply navigation block title to all pages in collection · 93df21b5

Ghada El-Zoghbi authored Jun 19, 2019 and

Robert Lyon committed Jun 20, 2019

When adding a navigation block to all pages in a collection,
include the block's title on all the other pages where the
block will be added.

Sponsored by The Australian National University

behatnotneeded

Change-Id: I0126dcbdc0bad5546f2b08f9bee347084b66f42c
(cherry picked from commit bfb278ad)

93df21b5

Bug 1833034: Allow folder fail message be removed on success · d05113f5

Robert Lyon authored Jun 17, 2019



And show a success message

Also remove metadata edit error message on form resubmit rather than
appending the same message again

behatnotneeded

Change-Id: I31f99a6ca384b74ca3e2ea795055667811f58e0a
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit e69b8a85)

d05113f5

Bug #1828150: clicking on calendar icon doesnt bring up the datepicker on calendar inputs · d3af5786
Liam authored May 08, 2019 and Robert Lyon committed Jun 20, 2019
```
behatnotneeded

Change-Id: I39a5df01d3a01abfcd75f078bc8074cb870d424d
(cherry picked from commit c2798247)
```
d3af5786

Bug 1831689: Adjusting how we update dates on the the view access page · d3d2359f

Robert Lyon authored Jun 12, 2019



There was a problem where we set up fields with empty date and then
try to add a date to it

Instead we should set up the datepicker with the date so that works
out what type of date it is first so then can handle it correctly

Note: if trying to use format DD/MM/YYYY it will complain that it is a
non-compatible date

behatnotneeded

Change-Id: I401e0812dc2c4189b715033fcf7b745c52425b05
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit afd9e7a7)

d3d2359f

Bug #1828140: missing btn-primary class on validation email page · cd717b7b
Liam authored May 08, 2019 and Robert Lyon committed Jun 19, 2019
```
behatnotneeded

Change-Id: I212947979eb9223ee4fe530185934806e911c4e3
(cherry picked from commit eeaeb4a2)
```
cd717b7b

Bug 1829099: Display group collection title on group's "About" page · 10c94b63

Robert Lyon authored Jun 19, 2019



Fixing for pagination as well

behatnotneeded

Change-Id: I36815af5ceac75bdc8ee389f478a2bb037fe0452
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 6a077cda)

10c94b63

17 Jun, 2019 1 commit

Bug 1832805: Add missing lang strings when saving page to timeline · 3cfbd58d

Ghada El-Zoghbi authored Jun 17, 2019 and

Robert Lyon committed Jun 18, 2019

Four new lang strings:
* cantversionviewinvalid
* cantversionvieweditpermissions
* cantversionviewsubmitted
* cantversionviewgroupeditwindow

Have separated the scenarios out for better feedback to the user.

Sponsored by The Australian National University

behatnotneeded

Change-Id: Id4952c37f35631b2f6a1dfad8129bac48108d733
(cherry picked from commit 1a08674a)

3cfbd58d

14 Jun, 2019 3 commits

Bug 1831419: validate insertion of event log for comment · 0ac5ce6d

Ghada El-Zoghbi authored Jun 03, 2019 and

Robert Lyon committed Jun 15, 2019

When a page is shared by a group and the event log
is set to All, check if a log needs to be inserted
for the event: sharedcommenttogroup.

Sponsored by The Australian National University

behatnotneeded

Change-Id: Iafe2120a37049a1b1bca9ab1e23503d93efc12ea
(cherry picked from commit 7040639d)

0ac5ce6d

Bug 1832803: Check for empty string before passing it to DOMDocument · 251b026f

Ghada El-Zoghbi authored Jun 14, 2019 and

Robert Lyon committed Jun 15, 2019

If an empty string is passed to the DOMDocument, a warning is
generated. Avoid the warning by checking for an empty string.

Sponsored by The Australian National University

behatnotneeded

Change-Id: I4bd3982de81f6db97601a1dbe5232d344e87ca81

251b026f

Bug 1832796: Group journals - display add link only if user has permission · c40945d8

Ghada El-Zoghbi authored Jun 14, 2019 and

Robert Lyon committed Jun 15, 2019

For a regular member who does not have permission to
add a journal to a group, the display message should
not include the 'Add one' link.

Sponsored by The Australian National University

behatnotneeded

Change-Id: I657f47b51b2c505cab4c2501f39e03b0252bdf72
(cherry picked from commit 9188fc20)

c40945d8

10 Jun, 2019 1 commit

Bug 1831835: Site admins can send messgaes to anyone · 88833dca

Ghada El-Zoghbi authored Jun 07, 2019 and

Robert Lyon committed Jun 11, 2019

Added behat test script
Site admins can send to any user in the system
regardless of the user's notification settings.

This capability was mistakenly removed in 19.04.

Sponsored by The Australian National University

Change-Id: I36e83ea4ae1b7b8765d70e067f49522de0d0aeb9
(cherry picked from commit e3bd6073)

88833dca

29 May, 2019 1 commit
- Bug #1830797: Left-align lang strings · a7709cd4
  Liam authored May 29, 2019 and Robert Lyon committed May 30, 2019
```
behatnotneeded

Change-Id: I90c67b4632d706a284da4d70b50c1bc818621b12
```
  a7709cd4
26 May, 2019 1 commit

Bug 1830302: Check if site is set for isolated institutions · ec0b86db

Ghada El-Zoghbi authored May 24, 2019 and

Robert Lyon committed May 27, 2019

When sending a message to another user, the check was
assuming that the site is set up as an isolated
institution and ignoring the user preference for
messages.

Sponsored by The Australian National University

behatnotneeded

Change-Id: I52936cd153336580146a9ac3eaf6e150a0e3affb
(cherry picked from commit 28fc80f6)

ec0b86db

21 May, 2019 2 commits

Merge "Bug #1825686: Content chooser has different icon and text sizes" into 19.04_STABLE · d77c4706
Robert Lyon authored May 22, 2019

d77c4706

Bug #1829096 Print stylesheet prints title on separate page · fe705fb8

Evonne Cheung authored May 15, 2019 and

Robert Lyon committed May 22, 2019

Flex causes content within rows to print on separate pages,
changed to row display: block; for print. Also hidden page
actions, gave page some real margins so it doesn't print to
the edge.

behatnotneeded

Change-Id: I33d068a3d8f6fb8965de8028a3204d094a6222e4
(cherry picked from commit 9f3dc7b2)

fe705fb8

16 May, 2019 2 commits

Bug 1785985: Offset the problematic cron jobs · 4c620d4d

Robert Lyon authored May 16, 2019

As mentioned in forum post
https://mahara.org/interaction/forum/topic.php?id=8450#post33705



behatnotneeded

Change-Id: I700c295d6d4ced232a119c3f8dbbc922a73298d3
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

4c620d4d

Bug 1829099: Display group collection title on group's "About" page · 1fd6e938

Robert Lyon authored May 15, 2019



behatnotneeded

Change-Id: I3c8b901a265cf11fd31d2607696c087762e493c8
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit af5ce8da)

1fd6e938

15 May, 2019 1 commit
- Bug #1825686: Content chooser has different icon and text sizes · 158c68b0
  Liam authored May 08, 2019
```
behatnotneeded

Change-Id: I2bb2fe0f12d646657fae93052bbf6cdb579944c1
```
  158c68b0
14 May, 2019 4 commits

Bug 1827797: PDF viewer not hiding submenus on loading · 22a89c94

Robert Lyon authored May 06, 2019 and

Cecilia Vela Gurovic committed May 14, 2019



This is due to the PDFjs using it's own .hidden css
and we changed 'hidden' class to 'd-none' in the html.
We need to change it back to 'hidden' again.

behatnotneeded

Change-Id: I91fd9dbd890d1e0effa98f667461fc49b24dc154
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 9bf5ee03)

22a89c94

Bug 1828743: Allowing nav menul scroll appear in production mode · 83931d4d

Robert Lyon authored May 13, 2019 and

Cecilia Vela Gurovic committed May 14, 2019



behatnotneeded

Change-Id: Iad903ea2d46ea9502644af3058dcd61cc68aa3c0
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 2ff032c5)

83931d4d

Bug 1827966: HTML export folder index pages not generated · 704050af

Robert Lyon authored May 07, 2019 and

Cecilia Vela Gurovic committed May 14, 2019



Problem with trying to use expression as variable

behatnotneeded

Change-Id: I58409ab8373b9db8af9bc1a2b682995e3722f140
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 2ab0b286)

704050af

Bug 1698699: Rewrite path to PDF in HTML export · 9b29d17e

Robert Lyon authored May 06, 2019 and

Cecilia Vela Gurovic committed May 14, 2019



This patch rewrites the path to the html export version of the PDF file

behatnotneeded

Change-Id: I8d534af41258d219046e5f3586bf904777242cb9
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit d094f841)

9b29d17e

13 May, 2019 1 commit

Bug 1828141: Create a new institution correctly · 883bb2cb

Robert Lyon authored May 08, 2019 and

Cecilia Vela Gurovic committed May 13, 2019



Need the default settings be interger rather than true/false

behatnotneeded

Change-Id: I65a032e3a5b1cf363b6f0ebcc6c7f5a3b30c2f34
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit e3171960)

883bb2cb