1. 01 Sep, 2016 3 commits
  2. 31 Aug, 2016 3 commits
  3. 30 Aug, 2016 1 commit
    • Aaron Wells's avatar
      Bug 1600099: Cleanup of the webservice admin page · ce1a97ac
      Aaron Wells authored
      This patch does a few things:
      
      1. Renames "webservice_enabled" config to "webservice_provider_enabled",
      to indicate that this config only controls Mahara's actions as
      a webservice provider, *not* a webservice client.
      
      2. Renames all the "webservice_<protocol>_enabled" configs to
      "webservice_provider_<protocol>_enabled" to indicate that they only
      control whether Mahara will provide webservices via that protocol,
      and not whether Mahara will use that protocol as a client.
      
      3. Renames "webservice_connections_enabled" config to
      "webservice_requester_enabled", to clarify that this config
      controls whether Mahara is allowed to request webservices
      from external sources.
      
      4. Updates language strings to make these changes clearer.
      
      5. Rearranges and renames the form methods in
      webservice/admin/index.php to make the flow of control more
      obvious. Now the main form method is first, followed in order
      by the methods that generate its subforms and each of their
      submit handlers.
      
      behatnotneeded: Covered by existing tests
      
      Change-Id: I58dadb352d1f1542ca67a104ebfd702b4ca90fc9
      ce1a97ac
  4. 29 Aug, 2016 2 commits
  5. 28 Aug, 2016 2 commits
  6. 26 Aug, 2016 4 commits
  7. 25 Aug, 2016 5 commits
  8. 24 Aug, 2016 4 commits
  9. 23 Aug, 2016 4 commits
  10. 22 Aug, 2016 4 commits
  11. 21 Aug, 2016 1 commit
  12. 19 Aug, 2016 7 commits
    • Aaron Wells's avatar
      Bug 1542126: Cleaning up very old error handler code · 287141c7
      Aaron Wells authored
      This patch contains these three related changes:
      
      1. Removes the "THIS IS BAD" message that was printed when 3rd-party
      exception or an instance of MaharaException was thrown.
      
      2. Removes the completely unnecessary "MaharaThrowable" interface.
      
      3. Adds an comment explaining why MaharaException is not abstract
      
      4. In the case of a smarty exception while printing an error, prints
      the name and content of the smarty exception.
      
      behatnotneeded: Covered by existing tests
      
      Change-Id: I800a868bd187efb76ed37cca872ce262c2abbdb0
      287141c7
    • Aaron Wells's avatar
      CLI upgrader, better handling of out-of-sequence plugin upgrades · 0e1704c1
      Aaron Wells authored
      Bug 1614805. When a plugin is installed "out of sequence" by a
      call to plugin_upgrade in the core lib/db/upgrade.php file, the
      AJAX-based web upgrader handles it gracefully, because it does
      check_upgrade() before upgrading each plugin, detects the change
      in status, and doesn't run the upgrade for that plugin a second
      time.
      
      The CLI upgrader, on the other hand, uses the same cached data
      from check_upgrades() all the way through, causing it to re-run
      upgrades for such plugins.
      
      This patch makes it behave the same as the AJAX plugin, running
      check_upgrade() again immediately before each component gets
      upgraded. This does cause some redundancy in code execution,
      but it shouldn't be enough to cause a noticeable performance hit.
      
      Change-Id: Id5c431fc9e636df2cab05d22e6cc424271ce9f3d
      behatnotneeded: Covered by existing tests
      0e1704c1
    • Son Nguyen's avatar
      Bug 1613483: Hide "Open file" button in the toolbar · 9c02263d
      Son Nguyen authored
      behatnotneeded
      
      Change-Id: I3204369ec36bbfa01227f210e8fc79526679f660
      9c02263d
    • Aaron Wells's avatar
      Merge changes from topic 'htmlpurifier_upgrade' · 7e555998
      Aaron Wells authored
      * changes:
        Prevent HTTP iframes on an HTTPS site
        Add more legal color formats (Bug 1264098)
        Allow CSS comments in customised skins. Bug 1369830
      7e555998
    • Robert Lyon's avatar
      Allow the pdf viewer to display menu items in user's lang (Bug 1423435) · 9aaadf0a
      Robert Lyon authored
      Change-Id: I0b13222887d66d174f5e12d037dda4594acc0512
      9aaadf0a
    • Robert Lyon's avatar
      Embed pdf has horiz scrollbar on default 3 column layout (bug 1237137) · 6ef27c8c
      Robert Lyon authored
      Seen as the 3 column layout is the default one the embed pdf view
      should fit within it.
      
      Currently if you have a browser windo open fully, a 3 column layout,
      and a pdf embedded you get a horizontal scrollbar on the embed pdf.
      
      A slight adjustment of the min-width and it goes away.
      
      The scrollbar will be there for 4 or 5 column widths but that is ok as
      they are quite thin columns.
      
      Change-Id: Ib01118d9fffab14440308eaf04b5038fdfeca9c3
      6ef27c8c
    • Robert Lyon's avatar
      Getting the bottom of the pdf viewer to display (bug 1240776) · d09a09ab
      Robert Lyon authored
      - change allows for a bit of the base of the display so it doesn't
      look broken
      
      Change-Id: Ie163f986a4c6abcf60cb26fc3b479122c119fc10
      d09a09ab