1. 31 Aug, 2016 1 commit
  2. 19 Aug, 2016 1 commit
    • Aaron Wells's avatar
      Bug 1542126: Cleaning up very old error handler code · 287141c7
      Aaron Wells authored
      This patch contains these three related changes:
      
      1. Removes the "THIS IS BAD" message that was printed when 3rd-party
      exception or an instance of MaharaException was thrown.
      
      2. Removes the completely unnecessary "MaharaThrowable" interface.
      
      3. Adds an comment explaining why MaharaException is not abstract
      
      4. In the case of a smarty exception while printing an error, prints
      the name and content of the smarty exception.
      
      behatnotneeded: Covered by existing tests
      
      Change-Id: I800a868bd187efb76ed37cca872ce262c2abbdb0
      287141c7
  3. 08 Aug, 2016 1 commit
    • Aaron Wells's avatar
      Bug 1570221 Don't print parameter values to logs when in production mode · 9a297249
      Aaron Wells authored
      The best way to prevent sensitive data from being printed to the logs
      is to avoid printing the value of *any* parameter. For instance, a
      password parameter may have an unusual name, or it may be passed
      through a general-purpose function like "strlen()".
      
      Since parameter values are useful for debugging, we can still print
      them when not in production mode (although with known password
      params still scrubbed out).
      
      Note this patch both scrubs likely password params, and hides their
      scrubbed value. That's mostly because I'm lazy, but it also obscures
      the password's actual length.
      
      Change-Id: I4a1ab4c89a169c6b29a7b63384c2412cee761ab7
      behatnotneeded: Can't test with behat
      9a297249
  4. 10 May, 2016 1 commit
  5. 27 Apr, 2016 1 commit
    • Aaron Wells's avatar
      PHP7 changes the type required for exception handler · c3d7f4f6
      Aaron Wells authored
      Bug 1575969. In PHP7 some errors throw an Error object (to
      the exception handler) instead of generating an error
      (handled by the error handler). The official way to make
      an exception handler that will work in PHP 5 & 7, is to
      leave off the parameter's type declaration.
      
      Change-Id: I5fc1c3765d5a311eb499d62915e676f8d9ee07a0
      behatnotneeded: Covered by existing tests
      c3d7f4f6
  6. 21 Apr, 2016 1 commit
    • Aaron Wells's avatar
      Bug 1567186: More thorough checking for passwords in stacktraces · 15d479f5
      Aaron Wells authored
      Rather than having an increasing list of specific parameters
      that we know to have passwords, this patch censors the content
      of any parameter with a name that contains the string "password"
      or "pw".
      
      behatnotneeded: Can't test with Behat
      
      Change-Id: Ifaa2ec10cf749c173b1a8d0928c6cc052124a83f
      15d479f5
  7. 11 Nov, 2015 1 commit
    • Jono Mingard's avatar
      Remove unused and superfluous JavaScript (Bug #1323920) · a4dc90b3
      Jono Mingard authored
      Some of these files aren't loaded on any pages, some (ie. debug.js)
      are no longer necessary with modern debugging tools, and some have
      been replaced by Bootstrap functionality
      
      behatnotneeded: should be functionally identical
      
      Change-Id: I6d1b3874de5d42ccc00a8c0d2bb0e8bc162747d4
      a4dc90b3
  8. 20 Jun, 2015 1 commit
  9. 17 Dec, 2014 1 commit
  10. 30 Jul, 2014 2 commits
  11. 13 Jan, 2014 1 commit
    • Aaron Wells's avatar
      Silence most E_STRICT errors · 8d17e071
      Aaron Wells authored
      Bug 1268746: In PHP 5.4 E_ALL changed to include E_STRICT, causing Mahara to throw
      a lot of strict standards errors. This should silence most of them.
      
      HOWEVER, because most strict standards happen at compile-time, this will have no
      effect on strict standards errors caused in the files that have already been
      loaded by the time we call error_reporting() and set_error_handler(), which includes:
       - The file invoked directly by the URL
       - init.php
       - errors.php
       - config.php
       - config-defaults.php
      
      Change-Id: I7a7fdf7facb1f30e186a0e8a27f1c3b7473200da
      8d17e071
  12. 14 Oct, 2013 1 commit
  13. 19 Sep, 2013 2 commits
  14. 17 Aug, 2012 1 commit
  15. 18 Jun, 2012 1 commit
  16. 08 Jun, 2012 1 commit
  17. 21 Feb, 2012 1 commit
  18. 01 Dec, 2011 1 commit
  19. 13 Sep, 2011 1 commit
  20. 01 Sep, 2011 1 commit
    • Richard Mansfield's avatar
      Add more flexible group jointypes (bug #610690) · 027ffc0d
      Richard Mansfield authored
      The four existing jointypes, 'open', 'controlled', 'request' and
      'invite' are mutually exclusive, but they don't need to be so strict.
      This patch introduces more flexibility in the way groups allow new
      members to join.
      
      * Group admins can always send membership invitations to a group, even
        if it's open or controlled
      * Membership requests can be enabled for any group unless it has open
        membership.
      * The grouptype now determines the set of roles available to a group,
        but no longer restricts the available join types.
      
      The db upgrade will preserve existing behaviour apart from enabling
      invitations on open, request, and controlled groups.
      
      Change-Id: I8bb0940a37f3c0c36366c1d5b8d27e8b9914a7e3
      Signed-off-by: default avatarRichard Mansfield <richard.mansfield@catalyst.net.nz>
      027ffc0d
  21. 08 Aug, 2011 1 commit
  22. 13 May, 2011 1 commit
  23. 30 Mar, 2011 2 commits
  24. 09 Aug, 2010 1 commit
  25. 12 Jul, 2010 1 commit
  26. 07 Jul, 2010 1 commit
  27. 16 Mar, 2010 1 commit
  28. 03 Mar, 2010 2 commits
  29. 20 Nov, 2009 1 commit
  30. 18 Nov, 2009 2 commits
  31. 21 Oct, 2009 1 commit
  32. 19 Oct, 2009 1 commit
  33. 13 Oct, 2009 2 commits
  34. 15 Sep, 2009 1 commit