1. 02 Mar, 2012 1 commit
  2. 24 Feb, 2012 1 commit
  3. 23 Feb, 2012 1 commit
  4. 19 Feb, 2012 1 commit
  5. 16 Feb, 2012 1 commit
  6. 13 Feb, 2012 1 commit
    • Richard Mansfield's avatar
      Add a maximum number of users for csv files (bug #823048) · 7f231697
      Richard Mansfield authored
      
      
      This allows $cfg->maxusercsvlines to be specified in config.php to
      stop admins and institutional admins from uploading large csv files.
      This is potentially useful on large multi-user sites.
      
      And until such time as we can reduce the amount of memory used by the
      create_user function, setting this option will provide the user with
      some feedback on csv upload failure (because we can't easily trap the
      php out-of-memory error).
      
      See also bug #548042.
      
      This commit also adds a call to set_time_limit() after processing each
      user, so that the script doesn't fail due to php's max. execution
      time.
      
      Change-Id: I662231288c7d0c6e70602c548123f12c63427a97
      Signed-off-by: default avatarRichard Mansfield <richard.mansfield@catalyst.net.nz>
      7f231697
  7. 07 Feb, 2012 1 commit
    • Richard Mansfield's avatar
      Add admin report on access lists of user pages (bug #919009) · 6266cae9
      Richard Mansfield authored
      
      
      Adds a new "User reports" page to the admin section, accessible by
      admins, which produces a list of all the pages owned by a given set of
      users, and a list of who is on the access list for each page.
      
      The users are selected using the checkboxes on the admin user search
      page, and the page is reachable from admin user search using a new
      "View reports" button on that page.
      
      The CSV download that previously appeared on the Bulk actions page is
      more appropriate on a reports page, so CSV download is also moved from
      Bulk actions to User reports.  Email and remoteuser fields are only
      displayed to site and institution administrators.
      
      Because some sites will not want to allow staff to see the page access
      lists of all users in their institutions, access to this page by staff
      is controlled by a new "Staff report access" site setting.
      
      Change-Id: Id02b58416e3dfb28fd39c1170426ddefe6669efe
      Signed-off-by: default avatarRichard Mansfield <richard.mansfield@catalyst.net.nz>
      6266cae9
  8. 31 Jan, 2012 1 commit
    • Richard Mansfield's avatar
      Allow staff to access the admin user search page (bug #919009) · 2f43bf94
      Richard Mansfield authored
      
      
      Staff members will be able to search through all users in their
      institutions, but they cannot edit a user unless they are also an
      administrator for them (institution or site administrator).
      
      Links from the usernames to the account settings page are only
      displayed when the logged-in user is an administrator for the listed
      user.
      
      The "edit selected users" button is only displayed to site and
      institutional admins, and the bulk actions page it links to now
      explicitly states which users have been filtered out due to lack of
      institutional admin privileges.
      
      Email addresses are removed from the list for staff users.
      
      If the logged-in user is an admin in one institution, and staff in
      another, email is displayed and usernames linked only for the
      'adminned' users.  The bulk actions page is still reachable, but any
      selected users who are not adminned by the logged-in user will be
      removed.
      
      Change-Id: Ia65a960df9af7c5794002007e7580ba5f9a4c9d7
      Signed-off-by: default avatarRichard Mansfield <richard.mansfield@catalyst.net.nz>
      2f43bf94
  9. 17 Jan, 2012 1 commit
    • Richard Mansfield's avatar
      Check for authinstances in use when deleting institutions (bug #917873) · d1310840
      Richard Mansfield authored
      
      
      When you delete an institution, and one of the institution's
      authinstances is still in use by some users, you get an sql error and
      a nonrecoverable error screen. (This can only happen when the users
      still using the authinstance are not institution members, because
      there is already a check to stop deletion of institutions with
      members).
      
      This patch allows the institution to be deleted anyway, reassigning
      the offending users to a 'default' authinstance.  If we can't find a
      sensible default authinstance, it will at least display a more helpful
      error message.
      
      Also, when attempting to delete an institution with members, set an
      error on the form rather than throwing a ConfigException.
      
      Change-Id: I9c85a3c8c80411e3cf526767b9142efb12907e5c
      Signed-off-by: default avatarRichard Mansfield <richard.mansfield@catalyst.net.nz>
      d1310840
  10. 10 Jan, 2012 1 commit
  11. 06 Jan, 2012 2 commits
  12. 17 Nov, 2011 1 commit
  13. 28 Sep, 2011 1 commit
    • Richard Mansfield's avatar
      Create all profiles with logged-in access by default (bug #807278) · f820ea6c
      Richard Mansfield authored
      
      
      There is currently only a site-wide setting for logged-in profile view
      access.  This means that when two institutions share a site, and one
      wants open profiles and another only wants institution-visible profiles,
      new users in the open-profile institution must be asked to manually add
      logged-in access on their profile.  Because we expect many more
      open-profile institutions than closed-profile institutions on a site, it
      makes more sense to put the onus on the closed-profile institutions to
      ensure their members remove logged-in access manually.
      
      This change ensures logged-in access is added to all new profiles, but
      only locks that access when the loggedinprofileviewaccess setting is on.
      
      Change-Id: I3375d7b2f8eb635a11879bf7758267f48f74c508
      Signed-off-by: default avatarRichard Mansfield <richard.mansfield@catalyst.net.nz>
      f820ea6c
  14. 21 Sep, 2011 1 commit
  15. 20 Sep, 2011 1 commit
  16. 15 Sep, 2011 1 commit
  17. 13 Sep, 2011 2 commits
    • Andrew Robert Nicols's avatar
      Add CLI Installer and Upgrade (Bug #844604) · 22e450eb
      Andrew Robert Nicols authored
      
      
      This commit adds a Command Line Interface install and upgrade mechanism.
      This should provide for unattended installations and upgrades.
      
      Change-Id: I7eaff22f76e30345102405b302bb12fdbd897d4c
      Signed-off-by: default avatarAndrew Robert Nicols <andrew.nicols@luns.net.uk>
      22e450eb
    • Andrew Robert Nicols's avatar
      Bug #824445: Improve error reporting for missing plugins · 0a694de5
      Andrew Robert Nicols authored
      
      
      This set of changes attempts to handle missing plugins in a better fashion.
      Rather than throwing an uncaught error which causes a unrecoverable site
      error, which in turn means that no user can use any other plugin; this
      patch disables the problem plugin and informs administrators of the issue.
      
      To handle the case where core plugins, which under normal circumstances
      cannot be disabled, are missing and disabled; the plugins.tpl template is
      also changed to test for the contents of the activateform, instead of
      whether the plugin can ordinarily be disabled. This means that if the issue
      is then fixed, the plugin can once again be re-enabled, at which point the
      [ hide ] link will no longer appear.
      
      Change-Id: I6f9fa73ae0ac307b5f5f8f30b8205690926f54fc
      Signed-off-by: default avatarAndrew Robert Nicols <andrew.nicols@luns.net.uk>
      0a694de5
  18. 12 Sep, 2011 1 commit
  19. 08 Sep, 2011 3 commits
  20. 01 Sep, 2011 2 commits
    • Richard Mansfield's avatar
      Allow per-group page editing permissions · 5117c733
      Richard Mansfield authored
      
      
      The roles which have edit permissions on group views is set for each
      grouptype.  This changes the setting to be per-group.
      
      Partially addresses bug #547362, bug #631189
      
      Change-Id: I3f51f0ed44b7f479a094a2c5b2e2ee4807722e34
      Signed-off-by: default avatarRichard Mansfield <richard.mansfield@catalyst.net.nz>
      5117c733
    • Richard Mansfield's avatar
      Add more flexible group jointypes (bug #610690) · 027ffc0d
      Richard Mansfield authored
      
      
      The four existing jointypes, 'open', 'controlled', 'request' and
      'invite' are mutually exclusive, but they don't need to be so strict.
      This patch introduces more flexibility in the way groups allow new
      members to join.
      
      * Group admins can always send membership invitations to a group, even
        if it's open or controlled
      * Membership requests can be enabled for any group unless it has open
        membership.
      * The grouptype now determines the set of roles available to a group,
        but no longer restricts the available join types.
      
      The db upgrade will preserve existing behaviour apart from enabling
      invitations on open, request, and controlled groups.
      
      Change-Id: I8bb0940a37f3c0c36366c1d5b8d27e8b9914a7e3
      Signed-off-by: default avatarRichard Mansfield <richard.mansfield@catalyst.net.nz>
      027ffc0d
  21. 24 Aug, 2011 1 commit
  22. 23 Aug, 2011 1 commit
  23. 16 Aug, 2011 1 commit
  24. 01 Aug, 2011 3 commits
  25. 27 Jul, 2011 1 commit
  26. 21 Jul, 2011 1 commit
  27. 19 Jul, 2011 1 commit
  28. 05 Jul, 2011 1 commit
  29. 04 Jul, 2011 1 commit
  30. 01 Jul, 2011 1 commit
    • Hugh Davenport's avatar
      Add page for Group CSV Uploads · d022f93a
      Hugh Davenport authored
      
      
      You can now use the web API service for groups to upload
      a CSV file to create and update groups
      
      The new page is below, and gives all the details about the format
      /admin/groups/uploadcsv.php
      
      Bug #547688
      
      Change-Id: Ic116c836e607ae3d1f6c0f67bbbf1f9c119828a8
      Signed-off-by: default avatarHugh Davenport <hugh@catalyst.net.nz>
      d022f93a
  31. 28 Jun, 2011 3 commits