GitLab

Put all of the delete confirmation messages into message divs, so that a) they wrap and b) the buttons are centred under the messages.

This lets admins, etc. upload feedback too.

Otherwise, $db->BindTimestamp() will return the string 'null' for 0 and '0', which no code in Mahara is expecting.

Noticed as part of the previous commit, where $user->lastlogin defaulted to 0 (which was incorrect), and which db_format_timestamp was converting to 'null'.

When creating the user object, set the default lastlogin time to null, not 0. They mean two different things.

'null' means 'user never logged in'. 0 means 'user last logged in Jan 1 1970'.

We WANT to do that, but the system doesn't yet. So let's not lie.

More help wordsmithing. Add/remove columns help now makes it clearer that you can always change the number of columns on the view layout page.

Set an explicit width on the viewinfo column when showing friends. This way, it's all the same width regardless of whether the user has views or not. Fixes #1946.

Moved the smarty core files into htdocs/lib/smarty/libs. Moved the mahara custom plugins into htdocs/lib/smarty/mahara.

This is so the debian packaging can depend on the smarty package.

Look for smarty in htdocs/lib/smarty/libs, which is consistent with upstream (and therefore debian). Look for mahara plugins in a separate directory.

This is so the debian packaging can depend on the smarty package in debian rather than bundling our own.

So people don't get confused over the purpose of those links. Tabs is a much more intuitive interface.

Now the subject line is a lot shorter, and the boilerplate within the e-mail is simpler.

I filed a feature request for other, more invasive improvements that can be done past 1.0: #1987.

Make the default notification plugin for all notifications types 'email'. This should encourage more use of the system by users.

Only set the defaultquota to its default if the plugin is being installed. Otherwise this overwrites any custom defaultquota setting chosen every time the plugin is upgraded.

Noticed for the file 0.4.2 upgrade.

Correct the order of arguments passed to can_message_user on user/view.php. Fix a case in that function that might result in a fatal error, if an id is passed to it for $from.

Use safer dom manipulation techniques when re-arranging the items in the authlist element. Speculative fix for #1930.

In reality, the javascript there is really messy and should be rewritten the MochiKit Way(tm).

I suspect Heinz hasn't deleted some old images, and has just untarred over the top of the codebase.

Link to the artefact viewing script instead of to view.php, which has been out of date for a while...

* Force password change: if checked, users are forced to change their password on next log in. This was mandatory before, now people uploading CSV files can choose.
* E-mail users about accounts: if checked, users are sent an e-mail about their new account. This was never an option before and never happened, now it is on by default.

We send a slightly different e-mail based on whether the user needs to change their password or not. This affects the Add User script a tiny bit.

Make it so display_name doesn't require the user to have staff and admin properties set. That was really pissing me off.

Don't show the 'user was suspended because' message if there is no reason for why the user has been suspended.

Make sure the group links open in a new window so people don't lose their changes when editing view access.