Bug 1401324

Change-Id: I82cc854004937161c29d74a6c26fc6a00352470b

We can't pass anything other than an array or null to
get_recordset_sql()

Change-Id: I62717401d3f4960f0e5a5fc76bf8156b0853b9fc
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Bug 1401313: The "toupgradecount" was only counting plugins, not core
and local. This specifically caused problems for the command-line upgrade
script.

Change-Id: Ia7b666af890d84613ed34f0c72f395c77fdad358

Bug 1400975

Change-Id: I0b7145a6febdb9a5e7c32da9e5ae6cc138840f9b

Bug 1400524: On a large site, the database queries to retrieve
all records from the artefact table can take too long to execute
and cause the PHP script to time out.

This optimization attempts to fix that by separately handling
the simpler case of parentless artefacts, and by removing
a redundant "select * from artefact"

Change-Id: Iddcfea3161fbfe804ec808119fe771757e7cdd5e

Before, the webservices admin pages were appearing under various
different menus.

I've taken them and put them as a third tier under
the Extensions -> Webservices menu

Change-Id: I8866da25ec54ba1a98392bfde628fe5182602270
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Will need some design team cleaning up of the css so best test to make
sure it functionally works/makes sense

Change-Id: I3ac5e45aa1210c14a93b18c31a0c826a1b2dfd83
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

- Changing the readonly checkboxes to be icon images
- adding a sitewide function display_icon() to render the ticks/crosses
- added a list of generic states to the mahara lang file
- tidied up the varying uses of enabled/disabled to use the generic ones

Change-Id: I009c6d54f0033dd46391c61387c84575536dcd4b
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

* changes:
  Change webservice config to not have nested Pieforms (Bug #1397128)
  Fix data in service group on creation
  Restricting the institution get members (Bug 1393530)
  Handling webservices validate_password better (Bug 1393530)
  Tidying up the initial code to mahara standards (Bug #1393530)
  Adding the webservices plugin (Bug 1393530)

The webservices config had a parent Pieform without <form> tags,
which was used solely for layout. Inside this it nested other Pieforms.
This caused problems due to the nested forms (fieldsets and legends
didn't work properly).

This patch replaces the parent Pieform with a Dwoo template to avoid
those problems.

Change-Id: Ic5b8fa935f403e1002669efa315627f110bcdcc3
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Robert Lyon authored Nov 28, 2014 and Aaron Wells committed Dec 09, 2014

Bug #1396433: Service groups should be disabled upon creation,
and tokenuser cannot be null (or it'll crash)

Change-Id: Id33279390c275e4c1b6f5316d85700a445970d71
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

To test: checkout master - try and add a comment to a page on page
reload you should get an error

With patch - adding/viewing comments should work again

Change-Id: Ic32a5f7daf273385b745c57622abac369e388197
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Change-Id: I63c4c566504492abb947202f8cf3ba5838770c9f
Signed-off-by: Yuliya Bozhko <yuliya.bozhko@totaralms.com>

A mistake was made where a user was allowed to add more than one
"group pages" block to the group homepage. This wasn't a problem until
we added pagination to the "group pages" block.

This patch attempts to clean up that error and merge any existing
multiple block instances into one "group pages" block instance.

Change-Id: I38acada835a4c245c97f0008543519a9dd2072a3
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Son Nguyen authored Dec 05, 2014 and Aaron Wells committed Dec 05, 2014

Bug 1399464: $values param must be an array

Change-Id: Ia865e42641830400fffeb3950f6cbe4fbed7ccbb
Signed-off-by: Son Nguyen <son.nguyen@catalyst.net.nz>

Change-Id: I1b8f1d002dd4679b25c7ae4fdcdb6af2ee73e933

Changing the value from postgres7 to postgres as we are really only
supporting postgres 8.3+

Also updated the list of reserved keywords to contain all the reserved keywords
that exist in postgres 8.3.
And added new postgres 9.3 reserved words to end of list

Change-Id: Ia233b8f21bff9983cf6918691283886467a607e4
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

in the calls of the dml function: get_record_sql()

Change-Id: I28d6d03258c6141e9cdca21bf201228522d8b809
Signed-off-by: Son Nguyen <son.nguyen@catalyst.net.nz>

Bug #1384473

Change-Id: I7a74dc86cb3794b8442084e30f2d13a89b80a7bd

On install an error was being thrown:

In Postgres:
Failed to get a recordset: postgres7 error: [-1: ERROR: bind message
supplies 1 parameters, but prepared statement "" requires 0] in
adodb_throw(SELECT name FROM "blocktype_installed" WHERE name IN
('profileinfo','myviews','mygroups','myfriends','wall'), Array)

In Mysql:
Failed to get a recordset: mysqli error: [1064: You have an error in
your SQL syntax; check the manual that corresponds to your MySQL
server version for the right syntax to use near 'NULL' at line 1] in
adodb_throw(SELECT name FROM "blocktype_installed" WHERE name IN
('profileinfo','myviews','mygroups','myfriends','wall')NULL, )

Change-Id: Ifd74ccfce5c8352db2fdc55378f9eede236354c7
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Bug 1384473

This reconnects to the db after wakeup, as resource types cannot be
serialized and unserialized.

This is necessary for unit tests, phpunit backups and restore globals
between each test.

(cherry picked from commit 41707745

)

Change-Id: I00f38a6cf101019fb684b4f5c9b40c2d937b614d
Signed-off-by: Penny Leach <penny@mjollnir.org>
Signed-off-by: Andrew Robert Nicols <andrew.nicols@luns.net.uk>
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Bug 1384473

Indexes on functions of columns have a 0 in the indkey column of
pg_catalog.pg_index, which doesn't refer to a column.

Don't return any columns for the index, rather than returning an empty
column name.

(cherry picked from commit b87d9961

)

Change-Id: Idd9bcdd04f15c99e76e028d62236a4d932ee845c
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

See Eduforge #2318 or LP #547951.

Bug 1384473

(cherry picked from commit 4bdafccb

)

Change-Id: I0e38e7f4f4e8da35f6c9f8e728213c2218e9a36f
Signed-off-by: Francois Marier <francois@catalyst.net.nz>
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Bug 1384473

And implicit count() of the array keys/columns. This saves a good 5%
of the exec time of get_records('config')

(cherry picked from commit 4652e561

)

Change-Id: I1b1addb0ade04eabc4d923d242261ed09fae4cea
Signed-off-by: Francois Marier <francois@catalyst.net.nz>
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Includes fixes for:
mysql/mysqli: Fix ability for MetaTables to filter by table name,
broken since 5.15.
See http://phplens.com/lens/lensforum/msgs.php?id=19359

postgres8: New class/type with correct behavior for _insertid().

postgres9: Fixed assoc problem.
See http://phplens.com/lens/lensforum/msgs.php?id=19296



Change-Id: If54f95815015ab9b7f58e102fb6c65cd086b8ac2
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

1. Data generator
2. Config manager
3. Form fixtures
4. Some sample test features

Add shell script for running Behat

Moving core feature files to 'test' folder outside the docroot

Fix Mysql bugs

Change-Id: I00f3558c178541ae7f81ce9fb1ce6226e7a9654e
Signed-off-by: Aaron Barnes <aaronb@catalyst.net.nz>
Signed-off-by: Son Nguyen <son.nguyen@catalyst.net.nz>

Requires https now - used to work with http but no longer

Change-Id: I4aae1d36c532dcdfc96b5a4a673910b654ea9a2c
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Change-Id: I7a1f7d42d9739a9ab1507d56aaf3a51ee0e7ef1a

Son Nguyen authored Nov 17, 2014 and Aaron Wells committed Dec 03, 2014

... in order to silence all the E_ALL notices

Change-Id: I0fdc9fc68ae7ffd2fa2dffe68dfbd79ee9599c06

to only those in the institution indicated

Change-Id: Ic4292676017af5f6aecdb491880901e84027dca6
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>