GitLab

Rebecca Blundell authored May 23, 2018 and Robert Lyon committed Jun 07, 2018

Change-Id: I62bf8065c82fba34f9eea1a3e3e004523b19abee

The fix in Bug 1774309 fails to work correctly when the site
is in a subdirectory of the apache root.

To test:
1) Adjust your site's apache file and set the DocumentRoot to be
parent of htdocs
2) Change the 'wwwroot' db value for site to include the 'htdocs/' bit
3) Restart the apache server
4) Go to site, adding 'htdocs/' to url
5) Try logging in

before patch: end up not found page with url containing two 'htdocs/'

after patch: end up at correct place

behatnotneeded

Change-Id: Ic5e1de2c5edaf96bbdd9b2403f0f65e45a4b80c0
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

To allow checking for a popup we need to stop the after_step hook
closing the popup before we check it.

To do this we need to add tag called @allow_popups to the feature file
so that popups stay open for the next step to check

To use with steps:
- And I should not see a popup
- And I accept the alert popup
- And I accept the confirm popup
- And I cancel the confirm popup
- And I should see "text" in popup

Change-Id: I5fa4827b12b355204141dd8b052bc4f5c77ae3a0
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

* changes:
  Bug 1773864: Throw MaharaException with valid error number
  Bug 1774309: Only redirect with QUERY_STRING when it exists

Mark Webster authored May 17, 2018 and Robert Lyon committed May 31, 2018

Adds timezone dropdown the site settings. If no timezone selected
it uses site settings country to determine correct timezone and sets
that in the database.
PHP and DB session timezones will then assume this setting for all times.

This makes setting $cfg->dbtimezone obsolete - there is a warning to
admins to update their timezone setting on admin dashboard.

Limitations:
- A timezone or country MUST be selected in site options.

- Will not correct existing incorrect times, as no timezone info was
stored in the DB for dates/times, so it's impossible to determine what timezone
was used when saving.

- Changing the timezone will not adjust the display of existing times, for the
same reason.

behatnotneeded

Change-Id: I34c64cd51ece6758e76dd8c37007dcb316005845

Ghada El-Zoghbi authored May 29, 2018 and Robert Lyon committed May 31, 2018

Pass error number and message correctly to the
MaharaException call when coming back from the
externalfeed curl call.

Sponsored by Central Queensland University

behatnotneeded

Change-Id: I03a2b666bde3905d2466ffbe35f1b35ca8a088bf

If trying to access a page requiring login the system remembers the
path (QUERY_STRING) you were trying to access when login is successful

But if you login from the homepage there can be no QUERY_STRING set

Noticed when doing behat tests

behatnotneeded

Change-Id: I38cf1f6df7432d70ced5fe5df84bd56b47f1f163
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

* changes:
  Bug 1771473: tags search - filter and sort selectors update each other
  Bug 1771473: Confusion of sorting

Change-Id: Ieb4ebab6ac57ff0ef4f4f89b409884e9d6bc3db7

makes it possible to select date sorting
for each artefact type

behatnotneeded

Change-Id: I7e74bdfbbe8b4df35028e1890833298e73516a45

Rebecca Blundell authored Apr 26, 2018 and Robert Lyon committed May 29, 2018

- changed some lang strings to make them work whether registered or not.
- made Registration box always visible
- added functionality to remove registration
- removed option to change email setting. Registration means sending
  updates.
- added registration_firstsent field to use for telling the admin how
  long their site has been regiestered.
- removed switch for "Send weekly updates" from "Site options" page as
  it seemed confusing to have it in 2 places with different wording.
- updated failing behat tests

Change-Id: I47609df6a0ae34932e5c0d2d34a338fe08c7570a

The baseurl for the pagination was not getting set correctly if 'all'
tags was joined with a special sort/filter.

behatnotneeded

Change-Id: Ic5ebcd4388b7808062a91ea463031e4c5ffa2083
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

- changed composer dependencies to make 7.2 work
- switched to carat syntax which allows upgrade up to anything below the next major version.
- fixed use of count to check for null in Behat2Renderer.php
- tested dependencies with php 5.6, 7.0, 7.1, 7.2. You do need to
  manually delete the composer.lock file and run make initcomposer to resolve issues.

behatnotneeded

Change-Id: I725d8ac6a2f8ca9d67c95d7d6184882a364c0762

This can be missing in collection object when upgrading from older
site and new db field is not created yet

behatnotneeded

Change-Id: I275a6387546eb8adaefd8b35f8b96dc754979cf5
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

behatnotneeded

Change-Id: I798d052506c9acefa0e4b55c993135f3b70d27c5

behatnotneeded

Change-Id: I9f2bf9d7db925e135107659e2d8e4e8b38d5f7ef

The JS scroll to id step seems to be scrolling to the bottom of id
The code is correct for scrolling to top
I've changed the id to one higher up the page to see if this passes.

Change-Id: Ia3f609451d93ed65b09813dd05a97e064370ea41

Change-Id: I05fe572187b91b3bfabb2b672ceff8aeb5fdbf87

behatnotneeded

Change-Id: Ide581c47d02772478fe04a85673e8d72cdd919e0

New test to check footer settings and headings correctly displayed

Change-Id: I64fa379a05cbe555a22f3ec6104edb349544a24f

Sarah Kirby authored Apr 04, 2018 and Robert Lyon committed May 24, 2018

are not present or enabled

behatnotneeded

Change-Id: Ie47a4e8735a8cc4fb13640a6c991b8af0c32171c

behatnotneeded

Change-Id: Idcd2689e6c196a6604e5f4706fb9019c4f0e3c88