Ran the copyright notice corrector script so all Mahara related files are correctly licensed under the GPL3.

Trigger tinyMCE to save all elements on the page when submitting a form. Removes a workaround from pieforms.

Use the pieform hooks to load/remove TinyMCE instances. This means that they get loaded and reloaded properly when the forms are submitted by AJAX.

fixing bug where users are unable to give logged in users, friends, public or groups access to views
problem caused by me changing what I thought were just language strings, which messed everything up

Conflicts:

	htdocs/lib/form/elements/userlist.php

Fix some problems where some code was attempting to use the ArtefactChooserData class even when it wasn't necessary, causing errors when searching in the artefact chooser.

Native to Mahara at the moment, while it's tested.

It works by taking an existing list and providing radio buttons between each element and on the ends so that the user can choose where in the list they want the new element to go.

The element returns new 'weight' values for every element in the list.

WTF was I smoking... make sure the artefactchooserdata class is sent if the artefactchooser is not a 'selectone'. Make sure to always send the javascript to wire up the tabs properly.

Only output the checkbox remembering javascript when it's required, rather than also when the radio buttons are being used.

Added a helper object to work out what checkboxes have been chosen on each page of the artefact chooser. Fixes #1718.

The fix involves using a helper object to remember what has been selected and what has been seen on each page. The helper munges hidden inputs around so that the correct data is sent back to the server, where 'correct' means the list of checkboxes checked on all pages that were visited, and the list of all checkboxes that were on visited pages.

It's quite a lot of javascript to send back with each request, so could be broken out somehow into a separate file at a later date.

Signed-off-by: Andrew McMillan

The workaround is annoying. I hate IE. Konqueror can have a little hate too. There you go, little konqueror.

Namely: the string saying how many results there are, and the string that says there are no artefacts to choose from.

Now the items are layed out in a grid to the right of the searcher, which saves some vertical space and has more fluidity to the layout.

Also, the calendar elements have from/to text, which is a small violation of the language text freeze but makes the purpose of the calendar items for each element much clearer.

I'd like to add more text to this page as an explanation, though that would be a larger violation.

Changed a smarty() call to smarty_core(), using the full object for a form element template is overkill.

The fix basically works by adding a hidden submit button at the very beginning of the form. Its "name" is the same as for whatever current action is being performed. Thus, when enter is pressed, the same value is passed through.

In javascript mode, this form element's name attribute is poked every time a new element is configured to be correct for that. There is also some special event handling for the search tab of the artefact chooser, so it does not trigger a form submit - just a 'click' event on the correct button.

Handle the case when there is no pagination related DOM stuff available - as happens when there are no results.

Fixes: If the artefact chooser has no tabs, then every single link on the page will be wired up to attempt to retrieve more data via AJAX for the artefact chooser.

Fixed by checking that there are actually tabs first.

Together with the previous commit, fixes #1720

Add support to the artefact chooser for a 'search' tab that allows drilling through the artefacts that can be chosen.

It works in firefox fine, and works without javascript fine (therefore it works in ie6). Opera also works. Konqueror and IE7 do not work properly.

allow public views setting now prevents adding and using public views

Use the key 'javascript' instead of 'js' everywhere, for consistency with the vast majority of stuff we already have doing things this way (render_self)

Removed the 'offsetname' configuration parameter. The artefactchooser element will only work if it's the only thing on the page anyway.

Allow configuration of the template used to show results in the artefact chooser also. This allows files to show results formatted differently to blogposts, for example.

Takes into account the existing selected things that might not be on the page when the element is submitted.