1. 14 Mar, 2016 1 commit
  2. 24 Feb, 2016 1 commit
    • RafGDev's avatar
      Bug 1536439 Show timelapse for comments if they are less than 1 day old · 4241b640
      RafGDev authored and Robert Lyon's avatar Robert Lyon committed
      Adding a format_timelapse(timestamp1, timestamp2) function to return a
      human readable time difference if the difference is less than a day,
      eg 3 hours and 1 min ago to give visual cue that the item was
      made/updated very recently.
      
      behatnotneeded
      
      Change-Id: I426d10da9ebc7ef1a5b464146fca386f19977579
      4241b640
  3. 02 Feb, 2016 1 commit
  4. 19 Jan, 2016 1 commit
  5. 09 Dec, 2015 1 commit
  6. 27 Nov, 2015 1 commit
  7. 25 Nov, 2015 1 commit
  8. 20 Nov, 2015 1 commit
    • Hugh Davenport's avatar
      Fix behaviour on submitting multiple pages to Moodle · fd9f1f82
      Hugh Davenport authored and Aaron Wells's avatar Aaron Wells committed
      Bug 1516823
      
      The moodle plugin for mahara assignment submissions [1] had an issue [2]
      where is the plugin was configured in non locking mode, multiple
      submissions of the same view would result in only the latest submitted
      link working.
      
      This was due to the page getting locked then released, which resulted in
      a new mt token, which made all the old ones not work. This patch changes
      that by accepting a new parameter which checks whether you are locking
      and if not, then don't generate and send a token back.
      
      When viewing a view, check for the new parameter mnetviewid or mnetcollid
      along with the parameter assignment. If these are present, then Mahara
      sends an MNet request back to Moodle which tells Mahara whether the user
      has the permission to view the page.
      
      This requires an update to the Moodle plugin, which is sent for review
      currently [3]. Mahara detects whether this plugin is upgraded and
      publishing the new MNet function. If it isn't, it falls back to original
      behaviour gracefully. This is done by attempting to send a MNet request.
      
      [1] https://github.com/MaharaProject/moodle-assignsubmission_mahara
      [2] https://github.com/MaharaProject/moodle-assignsubmission_mahara/issues/2
      [3] https://github.com/MaharaProject/moodle-assignsubmission_mahara/pull/19
      
      behatnotneeded: Can't yet test MNet issues in Behat
      
      Change-Id: I80739181b58bf7cf9c326e7b0a588b6239f864f1
      fd9f1f82
  9. 17 Nov, 2015 1 commit
    • Robert Lyon's avatar
      Bug 1517228: perf_to_log function amd misisng data · e9584a54
      Robert Lyon authored
      
      
      Because some systems may not have all the available data we should
      check if the data exists before trying to display it.
      
      To test:
      Before patch change the line in lib/mahara.php
       if (function_exists('posix_times')) {
      to
       if (!function_exists('posix_times')) {
      
      and make sure the 'perf_to_log' config option is set to true
      
      This will cause the errors we are trying to deal with to show up
      
      behatnotneeded
      
      Change-Id: If9610fa0eaf4c8bb036b21c1c75e10d828de7934
      Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
      e9584a54
  10. 20 Oct, 2015 2 commits
  11. 13 Oct, 2015 1 commit
  12. 08 Oct, 2015 2 commits
  13. 07 Oct, 2015 1 commit
  14. 23 Sep, 2015 1 commit
  15. 15 Sep, 2015 1 commit
  16. 01 Sep, 2015 1 commit
  17. 24 Aug, 2015 1 commit
  18. 13 Aug, 2015 1 commit
  19. 23 Jul, 2015 1 commit
    • Robert Lyon's avatar
      Bug 1467368: Allowing the main menu structure to be cached · ec41d0e0
      Robert Lyon authored and Aaron Wells's avatar Aaron Wells committed
      
      
      This will allow the rendering of the main nav to use less resources.
      
      The cached menus are saved for each institution into the
      institution_config table for these types of menus:
      
      adminnav     - site administration navigation
      instadminnav - institution admin navigation
      staffnav     - site staff admin navigation
      inststaffnav - institution staff admin navigation
      standardnav  - navigation seen in normal section of site
      
      To clear cache menus call clear_menu_cache($institution)
      
      Change-Id: I3b58090830b6d28f10f24e23abeef775c6863aa5
      Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
      ec41d0e0
  20. 02 Jul, 2015 1 commit
    • Robert Lyon's avatar
      Bug 853662: Replacing the pear graphing for chartjs graphing. · 23b58ab7
      Robert Lyon authored
      
      
      The system is created so we can either throw pre-generated chartjs json
      data at the canvas to show the chart or we can throw correctly structered
      array data that is then coverted to chartjs json data.
      
      Also we can override the type of chart after the pre-generated chartjs
      json is generated. Eg we can generate the chart as piegraph data and
      then later choose to display it as a doughnut graph.
      
      Change-Id: Idc342a14a9efc4af42f15770fa8dfa93f5e9639b
      Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
      23b58ab7
  21. 16 Jun, 2015 1 commit
  22. 15 Jun, 2015 4 commits
  23. 01 Jun, 2015 1 commit
  24. 28 May, 2015 1 commit
    • Robert Lyon's avatar
      Allowing for non english theme / plugin lang files to be used · 1d7a1fa4
      Robert Lyon authored and Aaron Wells's avatar Aaron Wells committed
      
      
      Bug 1417120
      
      The language location check now goes in this order:
      
      1. /local string in selected language
      2. theme/plugin directory, in selected language
      3. langpack, in selected language
      4. /local string in parent language (if any)
      5. theme/plugin directory, in parent language
      6. langpack, in parent language
      7. /local string in English
      8. theme/plugin directory, in English
      
      Change-Id: I24f61e24fadbca3a62fefa3855f4f444165d750a
      Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
      1d7a1fa4
  25. 26 Mar, 2015 1 commit
  26. 10 Mar, 2015 1 commit
  27. 03 Mar, 2015 1 commit
    • Nigel Cunningham's avatar
      (Bug1352028) Add a JSON progress bar for bulk operations. · 55a8deb8
      Nigel Cunningham authored
      
      
      This patch adds a JSON progress meter (I'll call it that to avoid confusion
      with progress bars) to the bulk uploading of users, groups and group
      memberships and the bulk export and import of users (LEAP), so the user can see
      the progress of the operation and not just the submit button changed to
      'Processing..' and whatever indication their browser gives while waiting for
      content.
      
      The bulk export and import are minor rewrites, replacing the old iframe based
      progress bar and the associated multiple pages and additional template file in
      the case of the bulk export, and the recursive redirect-to-self of the bulk
      import.
      
      To accomplish the display of the progress bar during the operation, we make the
      PHP session be closed (read only) except when changes need to be made. This is
      for the most part a straightforward change in session.php as it's the only
      direct accessor. In other places, we replace direct accessing of the session
      variable ($_SESSION) with use of the session class ($SESSION) so that it can
      reopen the session, make the change and close the session again.
      
      There is one more aspect to all of this: with previous behaviour, multiple
      requests for the same session would queue, taking the session lock in turn.
      After this patch is applied, they can proceed in parallel, allowing greater
      throughput. There is no additional locking requirement because the issues are
      the same as those already dealt with in allowing multiple PHP threads to
      process requests from different sessions at the same time.
      
      I have sought to make the progress meter nice and generic, so it can be used in
      the other bulk imports and exports too.
      
      Paradoxically, these changes don't just make the import seem to be faster, it
      actually is.. at least in the case of users and groups.
      
      Times for importing 1000 users, groups and memberships, averaged over 3 runs
      each (Wall time, not CPU time - but the relationship is the same).
      
                      Without Progress     With Progress
      Users                166s               155s
      Groups                85s                78s
      Memberships           20s                19s
      
      Change-Id: Iec15c57db32c77994edb80c71d65591de51a95e4
      Signed-off-by: default avatarNigel Cunningham <nigelc@catalyst-au.net>
      55a8deb8
  28. 18 Feb, 2015 1 commit
  29. 13 Feb, 2015 1 commit
  30. 09 Feb, 2015 1 commit
  31. 27 Jan, 2015 1 commit
  32. 11 Dec, 2014 1 commit
  33. 03 Dec, 2014 1 commit
  34. 16 Nov, 2014 1 commit
  35. 28 Oct, 2014 1 commit