1. 17 Dec, 2020 1 commit
  2. 16 Oct, 2020 1 commit
  3. 17 Sep, 2020 1 commit
    • Evonne's avatar
      Bug 1845053 Font size and size variable · 1d324796
      Evonne authored and Robert Lyon's avatar Robert Lyon committed
      Base font has been increased to 16px, and as a result, variables
      have had to be recalculated.
      
      Max browser width has been increased to 1440px to allow the
      larger font to have more characters in a line.
      
      As a part of accessibility, headings H1-H6 have had to be rejigged.
      Note that for elements such as popup/modals, the heading restarts
      at H1 again as advised by Julius.
      
      Page heading is H1, block heading is H2, everything else should be
      H3. Trying to attempt to reserve H4-H6 for user content, but it is
      still existing in some places as some things can't be changed.
      
      Attachment markups have been unified and added to styleguide.
      
      Removed H3/H4 from fieldset legends.
      
      behatnotneeded
      
      Change-Id: I69273c9775d658f03738c29be8d230b59c189790
      1d324796
  4. 15 Sep, 2020 1 commit
  5. 24 Jun, 2020 1 commit
    • Cecilia Vela Gurovic's avatar
      Bug 1857936: Lock page and artefact instructions · 479ff998
      Cecilia Vela Gurovic authored
      - A new page setting “Template” is added to the
      “Advanced” panel on all portfolio page areas of
      Mahara (personal, group, institution, site)
      with a Yes/No switch
      - added 2 columns to view table:
      'templatetocopy': indicates if the view is a
        template that can be copied
      'originaltemplate': if it has a value then the view
        is a copy of a template and should have
        the instructions locked.
        The value it contains is the viewid of
        the original template.
      - if a view is a copy of a template: display
      instructions in view settings and text blocks
      but don't allow to edit them. If empty, don't show them.
      - When adding a new text block to a page,
      don't allow to add instructions
      - Allow to remove the lock on a copy for roles:
          site admins in institution and site pages
          institution admins in institution pages
          group admins in group pages
      - If a template view is deleted from the site,
      then all the locked copies it has will remain locked.
      
      behatnotneeded
      
      Change-Id: I47e98cf8413da5ba6d5dea0e29dddbd80c481317
      479ff998
  6. 22 Jun, 2020 1 commit
  7. 15 Jun, 2020 1 commit
  8. 15 May, 2020 1 commit
    • Cecilia Vela Gurovic's avatar
      Bug 1857382: Removing page description tinymce editor · 500d9179
      Cecilia Vela Gurovic authored
      and replace the editor with a textarea to edit the description
      
      For views already on the site that have descriptions:
      - If they can be transform to a simple text, then remove the html
      tags from the view description to make it a simple text and
      update the DB with it.
      - If the description has tables, lists, etc, then create
      a text block with that description and place it above
      the other blocks of the view.
      
      upgrade: only remove description for new layout pages
      and the description must be:
      - more than 160 characters long
      or
      - have styling tags other than <p>, <em>, <br>
      
      translating pages: if the description makes one of the
      two conditions true, then create a new block at the top
      of the page with it. If not, if it's a simple short text
      then leave it as the view description.
      
      import:
      - for new gridstaxc layout pages, add a block at the top if needed.
      - for old layout, the page will be translated. After this, we
      add a block if needed
      
      copy a page:
      - if it has new gridstack layout, it was fixed by the upgrade,
      so we don't need to do anything
      - if it has old layout, the new view will be translated and
      we add a new text bloxk at the top with the description if needed
      
      CHECK what to do
      - the site templates, Dashboard and profile pages have descriptions
      So do the copies for each user.
      But those description don't show when viewing a portfolio or a dashboard.
      And the user can't change the settings for those pages either.
      old pages not translated: display a new block at the top of the page.
      There's no change in the layout on the db, there will be a mock block
      at the top of the page
      
      behatnotneeded
      Change-Id: I7646405a786e823ae486cc325c30b7a713deccee
      500d9179
  9. 15 Apr, 2020 1 commit
    • Cecilia Vela Gurovic's avatar
      Bug 1870444: Cover images for portfolios · a2f56dba
      Cecilia Vela Gurovic authored
      - added cove mage field to view/collection settings
      - it works for personal/group/institution/site portfolios
      - creates the "Cover Images" folder if it doesn't exist to store the cover images
      as default location. This is created when navgating to a view/collection settings section.
      - there is an upgrade to add 'coverimage' column to view and
      collection tables on the db.
      - the cover image is displayed in the view/collection card
      on pages and collections section
      - copy views/collections should copy the cover image
      - display the image in the card of pages and collections if it has one.
      If there's no image it should display the desctiption or nothing if there's
      no description. If it has cover image and a description, then it displays
      the image and when hover over it will display the description.
      On mobile it will display the description when touched
      
      TODO
      - accessibility
      - importing views/collections should import the cover image
      
      behatnotneeded
      Change-Id: I72e305ba437ba20df23f8ede224d399eb97f02d1
      a2f56dba
  10. 07 Apr, 2020 1 commit
  11. 17 Mar, 2020 1 commit
    • Cecilia Vela Gurovic's avatar
      Bug 1833664: Enabling 'lock blocks' in group pages · 4ccfaa8a
      Cecilia Vela Gurovic authored and Robert Lyon's avatar Robert Lyon committed
      When turning on 'Lock blocks' for a group page, prevent group members
      from removing the lock. Added a language string for site and institution
      pages to make it clearer that the locking only affects pages that are
      copied.
      
      behatnotneeded
      
      Change-Id: I26ebccb659f1c05333538dea24735ca11484b360
      4ccfaa8a
  12. 22 Oct, 2019 1 commit
  13. 06 Oct, 2019 1 commit
  14. 04 Oct, 2019 4 commits
    • Cecilia Vela Gurovic's avatar
      Bug 1813987: Accessibility settings and layout · 25082988
      Cecilia Vela Gurovic authored and Robert Lyon's avatar Robert Lyon committed
      - Added an option to set the profile to accessible.
      This can be set in account preferences and
      enables one extra field in the settings
      of a view, in the basic settings section, to make
      the layout accessible.
      
      - by default, if the user account is accessible then
      the pages will be crated as accessible.
      To have a non accessible page, the option un view settings
      needs to be set as 'No'
      
      - Accessible layout only allows to add blocks with width=12
      that is the same with of the grid.
      This makes the blocks show as a sequence one on top of the other
      like a list. The user can only reorder the position
      they have in the list.
      
      - When a page is accessible, the adding a block
      by drag & drop is disabled
      
      - Reordering of blocks is accessible by keyborad
      
      - The 'add block' button is reachable by keyboard
      
      - add an intro to the page for the screen reader
      to explain how the page works
      
      - add identification to each block for screen reader,
      blocktype and title (if it’s set)
      
      TODO
      * When adding a block to the bottom or the top of the page,
      the page should be scrolled to that block
      
      * Floating menu: should have a way to be recognized as a menu
      by the screen reader. Check the access keys for the menu.
      
      behatnotneeded
      
      Change-Id: I08417f0f11d747a67900c88c2f675ef5f85b7499
      25082988
    • Cecilia Vela Gurovic's avatar
      Bug 1813987: Creating a view via tags with gridstack · 1a1d2a69
      Cecilia Vela Gurovic authored and Robert Lyon's avatar Robert Lyon committed
      when creating blocks via tags
      - the position of the copied blocks in the new view
      will be one on top of the other
      - if the block comes from a view with grid layout,
      it will take the width & height from its dimensions
      - if the block comes from an old layout view,
      it will be created with default dimensions
      width = 4
      height = 3
      
      behatnotneeded
      
      Change-Id: I465e09fa4af6742913302c7ef278708c3cb627bc
      1a1d2a69
    • Cecilia Vela Gurovic's avatar
      Bug 1813987: Remove edit layout section · d45aed8d
      Cecilia Vela Gurovic authored and Robert Lyon's avatar Robert Lyon committed
      - also remove the layout pieform
      and the custom layout javascript code
      
      behatnotneeded
      
      Change-Id: I3e2e2b3f09106dd2a341a40d178feca693194e64
      d45aed8d
    • Lisa Seeto's avatar
      Bug 1844470: Move "Display page" and "Return to pages and collections" · 466b4a8a
      Lisa Seeto authored
      
      to right-hand side on "Edit" screen
      
      - create new edit page action buttons for return to <location> button
      - delete references to the old display page link created in file editviewtabs.tpl
      - delete file editviewtabs.tpl
      - change the edit button in editviewpageactions.tpl into a display button
      - change behat tests to reflect the change from Edit to Display page
      - change the Behat instruction for And I display the page to target updated element
      - delete the old display button styling from the style guide
      - move url, title display logic into new func get_return_to_url_and_title in lib/view.php
      - adjust blocks.php, access.php, editlayout.php to assign url, title using new func
      
      behatnotneeded
      
      Change-Id: Iedf2882c42fa1d204e438a23842834fbb9a709f9
      Signed-off-by: default avatarLisa Seeto <lisaseeto@catalyst.net.nz>
      466b4a8a
  15. 10 Sep, 2019 1 commit
  16. 16 Aug, 2019 1 commit
  17. 12 Jun, 2019 1 commit
    • Rebecca Blundell's avatar
      Bug 1827272: move theme dropdown menu to page settings · 33d1f349
      Rebecca Blundell authored and Robert Lyon's avatar Robert Lyon committed
      -move select box from the page edit screen to
      Settings-> Advanced
      -remove no-longer-used code from views.js, blocks.tpl
      and blocks.php
      -update behat test
      -add desc field for the theme chooser
      I also fixed the 'Lock blocks' description, which had a grammatical error.
      
      Change-Id: I4cddf3fe884d11cf950408041daf92d12915b2d3
      33d1f349
  18. 12 Apr, 2019 1 commit
  19. 19 Mar, 2019 1 commit
  20. 06 Nov, 2018 1 commit
  21. 03 Oct, 2018 1 commit
  22. 02 Oct, 2018 2 commits
  23. 09 Sep, 2018 1 commit
    • Cecilia Vela Gurovic's avatar
      Bug 1790543: Display portfolio instructions · 5cedce1f
      Cecilia Vela Gurovic authored
      1) Add an 'instructions' field to view table via install / update.
      
      2) Add 'Instructions' textarea / wysiwyg field to view settings page and
      have it save to the database
      
      3) Move generic "This area shows a preview of what your page looks like.
      Changes are saved automatically. Drag blocks onto the page to add them.
      You can then also drag them around the page to change their position."
      text in edit page to the help icon and in it's place have an expandable
      area to display the saved 'instructions' message.
      
      4) On view display page have an expandable area to display the saved
      'instructions' message
      
      5) in view edit mode, collapsing/uncollapsing the Instruction section
      is remebered automatically for next time the view is edited
      
      behatnotneeded
      
      Change-Id: Ia56323b9b734b8ebe9498c54dce5a3b934d1fd29
      5cedce1f
  24. 06 Sep, 2018 1 commit
  25. 08 Aug, 2018 1 commit
    • Kevin Dibble's avatar
      Bug 1781844: Lock blocks on pages · 3e76e38e
      Kevin Dibble authored and Robert Lyon's avatar Robert Lyon committed
      A lot of users in Mahara create (Template) pages to share out to users.
      This reduces the setup a new user will have to do to. There is an issue
      that on their personal copy, the blocks that were so carefully setup can
      be deleted.
      
      This functionality creates a new column in the database called
      "lockblocks" that can be enabled/disabled on the share page.
      
      When the user copies the page, this setting is copied over and the
      "delete" icon is hidden from view should the lockblocks setting be
      enabled. This only happens on normal portfolio pages.
      
      To unset - the user can edit the page settings and
      disable the lock blocks feature to enable the deletion of the blocks as
      per normal.
      
      behatnotneeded
      Change-Id: I7a2062f77431d6371f95d7f55bedcc499dd7caa2
      3e76e38e
  26. 12 Jul, 2018 1 commit
  27. 09 Jul, 2018 1 commit
  28. 04 Jul, 2018 1 commit
  29. 06 Mar, 2018 1 commit
  30. 22 Feb, 2018 1 commit
    • Robert Lyon's avatar
      Bug 1738303: Remove the obsolete $new variable being passed about when · fef8c68d
      Robert Lyon authored
      
      creating a new page.
      
      It is mostly so we can show 'No title' for page name and to have a
      'back' button instead of 'edit page' when viewing ones own page.
      
      But we don't need it as a page has a title when we click 'add page' as
      we make the new view entry in database straight away and the title
      will be something like 'Untitled v.2'.
      
      And if we change the title on page settings form then block edit screen
      will now show new correct title instead of 'No title'
      
      behatnotneeded
      
      Change-Id: I4630d53fbee734f1f4e903c05aa92b8348f3f41f
      Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
      fef8c68d
  31. 29 Sep, 2017 1 commit
  32. 24 Sep, 2017 1 commit
  33. 07 Sep, 2017 1 commit
  34. 04 Aug, 2017 1 commit
  35. 29 Jun, 2017 1 commit
  36. 27 Jun, 2017 1 commit