GitLab

When an CryptException occurs when sending an XMLRPC request (because the response was using an old key for example), fail in a nicer manner.

Update the message for the primary cause of this (old key) so it's more obvious in the logs.

- put back debug code I had inadvertently removed that didn't belong to
  me
- throw an exception i think is missing (someone please review this)
- better oo & namespacing
- better validation of incoming 'data' per format
- paths to zip and zip args (relies on a patch that i am about to put on
  master)

Prevent warnings if the xmlrpcmaxservertimedifference configuration setting isn't set - which will mostly be the case.

Allow the maximum time difference between servers doing XMLRPC communication to be configured. Fixes #1963.

The setting is called xmlrpcmaxservertimedifference. I can't be arsed putting a default in config-dist.php because people shouldn't use it anyway.

Handle case where remote application sends back a new public key rather than the result we were looking for.

Now Mahara will import the new public key, then re-request the data it wanted.

Also, switched some exceptions to an XMLRPC related exception, to ease error handling.

Signed-off-by: Andrew McMillan

code