Change-Id: If0dbdd62c48b67424785912fcbf9db8176756557
Signed-off-by: Kristina D.C. Hoeppner <kristina@catalyst.net.nz>

Ensure that default behaviour is to match user
to remote user name

Change-Id: Iadabb5c47004786af6fb6e2e6ac0590fb4a887d8
Signed-off-by: Piers Harding <piers@catalyst.net.nz>

If a cron function causes an exception for whatever reason, then the
cron will stop, but the lock isn't removed. The job then isn't tried
again for another 24 hours.

Instead we should try to set the next run time and remove the lock.
Cron functions that run frequently, but fail due to some temporary
problem, will not be forced to stop for 24 hours.  On the other hand,
very frequent cron functions that throw exceptions on every run will
be spammy.

Obviously, this change has no effect on cron functions that fail due
to script timeouts, out-of-memory errors, or which exit for any other
reason.

Change-Id: I3bfe08c2ebba62cbd82045e66438a6442d1f1fe8
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

Having auto-create users essentially turns on self-registration
which could lead to confusion for admins. It's better to force
them to turn it on manually if that's what they want.

Change-Id: If8e24730bca832d50ed4a851f2ffe408c5a7ae0f
Signed-off-by: Francois Marier <francois@catalyst.net.nz>

For filebrowsers inside configuration forms in Chrome, the edit,
select, and file upload buttons appear to have no effect when the
copyright agreement is enabled.

In fact the javascript for these buttons *is* executed, but Chrome
won't display the resulting changes, making it rather difficult to
click on some of the buttons in forms that are opened up.

Adding a slight delay before disabling the file input fixes the issue.

Change-Id: I8cfde0056f0aefc027e3a532488be3c369292b65
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

Change-Id: I4950f3ffc24d8839920c7c999cbe650ff0885959
Signed-off-by: Francois Marier <francois@catalyst.net.nz>

Change-Id: Ia8685b5f7afb102f2e8e41e8639e75b371504200
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

* changes:
  Improve portfolio search (bug #931481)
  Fix portfolio search (bug #931481)
  Fix artefact::get_views_instances (bug #931467)

The 'emaillist' pieform element doesn't appear greyed out or
uneditable when it's disabled.  This means that when the email address
field is locked in institution settings, or because the email address
is imported from Moodle, users may still try to add new addresses
without receiving a useful error message.

When displaying this element on the Edit Profile page, the help item
is hidden whenever the element is locked, because it refers to buttons
and links that don't appear in the form.

Change-Id: Ia9a149e9110932ebac9202a1691d29799d327dc2
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

Bug #900932

Change-Id: I4b3f6e18fb0ab68a8d9e0e5327d672e373f9a291
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

Add the list of views the artefact is associated with.

Change-Id: I62fd21c2d53819de2a57d2aee88aff9dc34191ed
Signed-off-by: Ruslan Kabalin <ruslan.kabalin@luns.net.uk>

Removing get_links output in ArtefactTypeHtml does not seem affect anything, as it only being used
in self_search_make_links.

Change-Id: I4bf3594233eac54e518ed45e9c7798a7782bd799
Signed-off-by: Ruslan Kabalin <ruslan.kabalin@luns.net.uk>

Also ensures that required library is available.

Change-Id: Ieb5e109aa9316c6d53dc3bf4e5e02c04cd5ae821
Signed-off-by: Ruslan Kabalin <ruslan.kabalin@luns.net.uk>

* changes:
  Get unread message count from user table (bug #854403)
  Add column for unread message counts to the usr table (bug #854403)
  Add functions to create and remove database triggers
  Display a useful error message when PL/pgSQL is not available
  New icon for unread notifications

This allows $cfg->maxusercsvlines to be specified in config.php to
stop admins and institutional admins from uploading large csv files.
This is potentially useful on large multi-user sites.

And until such time as we can reduce the amount of memory used by the
create_user function, setting this option will provide the user with
some feedback on csv upload failure (because we can't easily trap the
php out-of-memory error).

See also bug #548042.

This commit also adds a call to set_time_limit() after processing each
user, so that the script doesn't fail due to php's max. execution
time.

Change-Id: I662231288c7d0c6e70602c548123f12c63427a97
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

Also keeps the count in the $USER object up to date whenever the
user deletes or reads a notification.

When new notifications are generated for a live user by another user,
or on cron, the logged-in user's unread count is reloaded from the
database into the session either on hitting the inbox, or whenever
$USER is committed for some other reason.

The code to reload the background fields on commit of the LiveUser
object has been changed to ensure that it still works at upgrade time,
where the 'reload' column doesn't exist in the user table yet, but
*does* exist in the User object.

Change-Id: I9c9a81bf77d0927352902dee0d989d6122757b47
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

The unread message counts are expensive to query in postgres when
notification_internal_activity gets big.  This results in very slow
logins (the first time the query is run).  This patch adds a new
column for each user to store the unread message count.

The counts are updated using a trigger on insert, update and delete
of the notification_internal_activity table.

Change-Id: Ifb24c6892567658584f45825437bb7a8f20cc310
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

Change-Id: Id4f87c1fef835a11bc7413df93d60a6fada59a6a
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

Change-Id: Ib9a72a9e36bb24da5907720242b23e991bb7bf9a
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

Change-Id: I81865ee9c9cd4a47095a1087d452360c7a994008
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

If aspell is found on the system use it for spellchecking.
Otherwise use GoogleSpell.

Bug#812030

Also renamed the error() function in htdocs/js/tinymce/plugins/spellchecker/includes/general.php
to mceError() because it conflicts with the mahara defined error() function.

Change-Id: I71f17cb29c7dfcd5ea9731c2c1b8e2a64fcc46ef
Signed-off-by: Christopher Tombleson <christopher@catalyst.net.nz>

The admin 'manage groups' and user profile pages added users to groups
by changing the group_member table directly rather than using
group_add_user and friends.  It's cleaner to keep this code in one
place, in case we want to make changes to the group_member tables
later.

Change-Id: I687764fb25e8924a3da85da7494cd3fbcad53bc1
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

Bug #897631

This is a small modification to allow group_member table to have
a new field called method. Method can be used to indicate how
that user was added to the group.

It can be useful to implement syncro with other systems.

Change-Id: I92cd64e1fcf72927f16b496a5e17fa5da992a329
Signed-off-by: Juan Segarra Montesinos <juan.segarra@si.uji.es>

When a user is an administrator in one institution, and staff in
another, and performs a search with no results, PHP gives an "Invalid
argument supplied for foreach()" warning.

Change-Id: I3706a639fb11e98cb64c8ef14aede371386e86b4
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

Currently there's no warning if the PHP GD library has been
compiled without one support for a file type. When a user attempts
to upload an image of an unsupported type, it will fail.

Change-Id: I682a39aeaba2d06494868210b9ef9d8f46f1b136
Signed-off-by: Melissa Draper <melissa@catalyst.net.nz>