Maria Sorica authored Jan 24, 2018 and Cecilia Vela Gurovic committed Feb 12, 2018

1. Add the Yes/No switch to the users privacy page that will
allow the user to withdraw their consent if they change their mind.
2. Display the date when a user consented to a privacy statement.

behatnotneeded

Change-Id: If9f85125287a7384e27c1b45aefa98ad37e97776

Maria Sorica authored Jan 19, 2018 and Kristina Hoeppner committed Feb 12, 2018

behatnotneeded

Change-Id: I9d7685dc6c3b0871fa2471ce27c0a4aa67af0b34

* changes:
  Bug 1734169: Use modal for are you sure question
  Bug 1734169: Suspend user if privacy statement is refused
  Bug 1734174: Add the after login privacy page

@TODO
- add a textarea field for reason to not accept
- add test to suspend user when it doesn't accept

Change-Id: I7479e8ac1863f7712d45d92e5b60deced2847391
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

If a privacy switch has the value 'No', a confirmation
form will be displayed to make sure this is really the
users decision.
If yes, the users account is suspended.

behatnotneeded

Change-Id: Ifa7c175569cbad780a449c8431d4d9f981839c21

Upon login, if the user has not yet agreed to the most
recent Privacy statement versions, he will be redirected
to this page.

On install admin user accepts default privacy

behatnotneeded

Change-Id: I6afc3d4d4db0676782a8b1501a962862108eab6b

Created switch in site options. When set to 'yes',
it disables the multiple institution per user switch.

To do: When set to 'yes', force user to accept T&C
and privacy statement. Will be resolved in another
bug report #1741799

behatnotneeded

Change-Id: Ie62fb34a6c7cbf8e5b9bce93e76dc7c4a05376b9

* changes:
  Bug 1740208: Fetch related view for artefacts we can see
  Bug 1740207: Removing obsolete thumbnail images for elasticsearch
  Bug 1738898: Elasticsearch not indexing access changes correctly
  Bug 1734006: Allow the search facet tab links to scroll to tab area
  Bug 1734006: Elasticsearch to work with either elasticsearch 5+ or 6+ server
  Bug 1732565: Allow for faster indexing of large sites into elasticsearch
  Bug 1730530: Elasticsearch use different auths for reading from/writing to index

Niranjan Bandi authored Jan 19, 2018 and Robert Lyon committed Jan 31, 2018

-Made the changes according to the code review.

Copy a page or collection directly from its location via the "Copy" button on the page (not via the "Copy" button on "Pages and Collections").
 Behat test for both single page and collection with multiple pages covering the options there.

    For collections create the base test:
    Don't edit collection settings
    Leave all pages in the collection that you copied and don't add others.

Change-Id: Ia6f464fb1cf6bd5424cd395636242c4e07f02322

Niranjan Bandi authored Jan 18, 2018 and Robert Lyon committed Jan 31, 2018

- made the changes according to the code review.

Change-Id: I136398f7deb63a854341bf274e0ef34d9c527d75

Change-Id: I980836ba6ae08bc69263dcaef6444788fa430cf2
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Cecilia Vela Gurovic authored Jan 11, 2018 and Robert Lyon committed Jan 25, 2018

When a user is logged in the 'Privacy statement' link in the footer should go to
/account/userprivacy.php

when no user is logged in then it should go to
/privacy.php

behatnotneeded

Change-Id: Ic0ded32c71a2f4e0f2238559c4c8a3fb0269f5b9

* changes:
  Bug 1734174: Users Privacy Statement page
  Bug 1734174: Create usr_agreement table
  Bug 1734182: Change menu from 'Privacy statement' to 'Legal'
  Bug 1734182: Displaying the existing site/institution privacy within table
  Bug 1734182: Add view/edit logic to institution privacy statement
  Bug 1734182: Add the first privacy statement of an institution
  Bug 1734182: Display the site privacy on institution privacy page
  Bug 1734182: Add the edit/view logic to the site privacy page
  Bug 1734182: Display the Privacy Statement on page /privacy.php
  Bug 1734182: Display all versions of the site privacy statement
  Bug 1734170: add new admin menu item 'Privacy'
  Bug 1734182: Move privacy to site_content_version table
  Bug 1734182: Add privacy to the site_content_version table

Maria Sorica authored Jan 05, 2018 and Robert Lyon committed Jan 25, 2018

The page displays the current privacy statement that the user has consented to.
behatnotneeded

Change-Id: I03d79f538b0a3775cf49c0ed39a05b3a98c8bf04

Maria Sorica authored Jan 08, 2018 and Robert Lyon committed Jan 24, 2018

behatnotneeded

Change-Id: Ibd10a64a601a38ed88a4c49ce720f0d343d1fe83

That way we can have other things like terms and conditions also part
of this system

Change-Id: I00d44a856142095dc3d48f9953a5c775b06b6891
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Rather than loading page with just existing content we can load table
with table and content displayed together for easier comprehension of
which row relates to which statement

Also added the 'Cancel' link so one can cancel out of the form without
saving

behatnotneeded

Change-Id: Idae22c7659c5ea9f63e98e77b73abccaecd97462
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Maria Sorica authored Jan 04, 2018 and Robert Lyon committed Jan 24, 2018

behatnotneeded

Change-Id: If1d564c309ebf32025299035fb8cca4d0981f603

Maria Sorica authored Jan 04, 2018 and Robert Lyon committed Jan 24, 2018

behatnotneeded

Change-Id: I1330f4975460a5fff7313b0af139735caf8b9d99

Maria Sorica authored Jan 04, 2018 and Robert Lyon committed Jan 24, 2018

behatnotneeded

Change-Id: I50c0bb5767f866ce0a8b5a961cbd0dd177962323

behatnotneeded

Change-Id: I5559d777409f9416e52b911dedd73a3c6fb36fe4

behatnotneeded

Change-Id: If7c5d5b4c0f2da9dfb29a5294cb70f2fbe1c1045

Maria Sorica authored Dec 29, 2017 and Cecilia Vela Gurovic committed Jan 23, 2018

The versions are displayed under Administration -> Configure site ->
Privacy statement in order to have a log of when changes were made
by whom.

behatnotneeded

Change-Id: I9a4e72e9ae97453e171e849bff5c4b8f1204e2e1

Cecilia Vela Gurovic authored Jan 19, 2018 and Robert Lyon committed Jan 23, 2018

Stop the error:  [SimpleSAML_Error_UnserializableException]:
[ARRAY]: The option 'Format' is not a valid string value

And allow the js submit form for the redirect of the POST to IdP

behatnotneeded

Change-Id: Id617e51722d55c286e9b5340cdc3f5922f7320bc

Adjusting ssphp to copy the extlib www/resources/ files into sp/resources/

Change-Id: Ie347d43b64638b4b36a198c5904cee6128ea6f7f
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

behatnotneeded

Change-Id: I2d0e298b6ec4c249f4b3a1ee2d8d4b2e54193f1d

Maria Sorica authored Dec 28, 2017 and Cecilia Vela Gurovic committed Jan 19, 2018

On site update, delete Privacy Statement from the 'site_content'
table and add it to the 'site_content_version' table.

behatnotneeded

Change-Id: Idd765bad0e72165c940e5f6090d3c8861ae8fcd5

Maria Sorica authored Dec 28, 2017 and Cecilia Vela Gurovic committed Jan 19, 2018

Add the site Privacy Statement to the 'site_content_version' table during installation

behatnotneeded

Change-Id: I50016c5d91df776025aa8ebb54077ae953844603

Robert Lyon authored Dec 20, 2017 and Cecilia Vela Gurovic committed Jan 17, 2018

To take advantage of the new things plus the bug fixes

behatnotneeded

Change-Id: Id7033f4c1308ecbfbd38a76e018a1a4ca4327dda
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Gregor Anzelj authored Jan 08, 2018 and Robert Lyon committed Jan 16, 2018

We achieve this by having a new pieform rule called 'requiredby' where
we can reference another field and when a certain value is set in that
field it makes this field required.

requiredby rule needs an array containing:
- the 'reference', a string of the name of the related field within the same form
- the 'required', an array containing the values of 'reference' element as keys
  and true/1 for value if this element is required.
-- If the reference field returns true/false then required array would
   have either 'true' => 1 or 'false' => 1 depending on what setting
   is needed

behatnotneeded

Change-Id: I9bc5d15b4035d4a11b81b9355a32044c66ee2199

- Updated details for behat.yml config to BehatConfigManager and a call
to update the file
- Added BehatHooks to get screenshots on fail. Screenshots are saved in the
Behat maharadata directory at /behat/results/html/screenshots
- Added auto-open of report
- Added some explanatory notes on how to run report

If you set the "html" flag as third parameter of the Behat command, you can
generate the HTML report. The report will be saved in the Behat
dataroot under behat/html_results

If you accidentially set the "html" flag as 2nd parameter it will
instead show help info

behatnotneeded

Change-Id: I76c67a1148278efa049317b526fef760c1a43ded

I have successfully run tests with the new version of chromedriver
(2.35) and chrome (63). I thought the best way to test further was to
let maharabot run the test suite and see if any issues come up.

failing tests are now fixed.

behatnotneeded

Change-Id: I22e45e8a95669e2109ca70ae782aa2c40546db14